Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 327BEC4338F for ; Fri, 20 Aug 2021 10:01:31 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5591660EBD for ; Fri, 20 Aug 2021 10:01:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5591660EBD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1F9B780FB4; Fri, 20 Aug 2021 12:01:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="GSuifXQ8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 67A6181EBD; Fri, 20 Aug 2021 12:01:26 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 361EF80C85 for ; Fri, 20 Aug 2021 12:01:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rogerq@kernel.org Received: by mail.kernel.org (Postfix) with ESMTPSA id CD4F360EBD; Fri, 20 Aug 2021 10:01:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629453680; bh=13ATW+tAIlTXBDP5vThi3cWVkumzr5XrrXLiFtE7ghg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=GSuifXQ8eJ3tAzCsKO2tXhIBrS5Ed89AkglJgSeENy10w43f4I3KfuwCLmWHTZcJs kLv21cbtItIk4uf9c5gS9RC9MlrKfn/zJl5yMNKYRlOkTqbcyUBEgm7PbGNmOZHOVZ F2MSheN7YpuuII2B3s0acUYXcF7rShpTtsOY4IZaxlx3UNV/SmCbtzW+0CXDY/EyBZ nIXBrq9RhP84YPIpyurwxcDdqAauDWrMD6YrBBR0fbMtH3yWsu2Iv23FHCJmVn2oEa UONopzRvKTlM0zj4+JT3c6RW+2wC2ku79LBPeQYO0vXK+70VXsA01ni25ybWpi+CB4 8xgzNBWLdqBxA== Subject: Re: status="ok" treated as disabled by DM To: Nishanth Menon Cc: simon Glass , U-Boot , Lokesh Vutla References: <36759af5-b7b7-bf2a-c9f3-ec95cab470ae@kernel.org> <20210819113713.poiytls4uqdv22di@fencing> From: Roger Quadros Message-ID: Date: Fri, 20 Aug 2021 13:01:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210819113713.poiytls4uqdv22di@fencing> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 19/08/2021 14:37, Nishanth Menon wrote: > On 14:03-20210819, Roger Quadros wrote: >> Hi, >> >> If the device tree node has status="ok" then the u-boot DM will treat the device as disabled. >> There are still quite many devices using "ok" instead of "okay" or no status and those devices will not be bound. >> >> What is the right fix? >> 1) make u-boot DM to treat satus="ok" as enabled. >> 2) fix device tree by changing "ok" to "okay". >> >> cheers, >> -roger > https://github.com/devicetree-org/dt-schema/blob/master/schemas/dt-core.yaml#L36 > > > I believe, the correct fix is (2) change the dt to "okay". > Also in u-boot code it does mention to fix DT node status to "okay". https://elixir.bootlin.com/u-boot/v2021.07/source/lib/fdtdec.c#L278 -- cheers, -roger