Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6452210F995A for ; Wed, 8 Apr 2026 15:50:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D047910E69D; Wed, 8 Apr 2026 15:50:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="iKN35jNY"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1C4F410E69B for ; Wed, 8 Apr 2026 15:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775663402; x=1807199402; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to; bh=rPZhaUrhyGgxj2Kf2XmtiOvLIzNPQ+RGyqpP56pXWQU=; b=iKN35jNYvypRGZ63yHtJHNrkXuxW2+fZ13SppVWnKLu2VTd9936hcWjr E2Dej+jzsqgWxjzify56KiyHtgQrYZdVzsJk3lVhmTCZWKzfbEmvn+VQS KsHtArdAwSbJ1WfPcot013DGfjPf8cfKyEgPaaip2NM8Sk69k8sGG7FD4 fDmMOKddMNsIANC3UR0GUVKP8/js6j+M87LX74UF6apfpSp2by0ySB8hj n/5i3fIs+YHRXHpLtDP9JBNygLh4C7CR7Tl14shVCFtGVznWmb6ETfa+K RSZFby4oLBC3ibAgQJnAgc51o8tLpoAtUQ/0bI1GioIfnL9yfmSdBrAhY g==; X-CSE-ConnectionGUID: IQQdZWzMRL6DgBNh+Vyq/A== X-CSE-MsgGUID: wzUduAXNSSymcF1ymVfMMw== X-IronPort-AV: E=McAfee;i="6800,10657,11753"; a="94233026" X-IronPort-AV: E=Sophos;i="6.23,167,1770624000"; d="scan'208,217";a="94233026" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2026 08:50:01 -0700 X-CSE-ConnectionGUID: gP9/NOT5RxSyYPKyhXtGHQ== X-CSE-MsgGUID: 7yHCSmBNQDGRqRpSPH5XtA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,167,1770624000"; d="scan'208,217";a="223742288" Received: from ijarvine-mobl1.ger.corp.intel.com (HELO [10.245.245.108]) ([10.245.245.108]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2026 08:50:01 -0700 Content-Type: multipart/alternative; boundary="------------R0Tq0GvnscqGqTLdPlU8ykIC" Message-ID: Date: Wed, 8 Apr 2026 17:49:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: =?UTF-8?Q?Re=3A_=E2=9C=97_i915=2ECI=2EFull=3A_failure_for_drm/i915/?= =?UTF-8?Q?display=3A_stop_using_the_configurable_fence_timeout_=28rev2=29?= To: Jani Nikula , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org References: <20251112155612.8320-1-jani.nikula@intel.com> <176310680567.54560.8073003092226406962@10055242dc62> <3692f126b907c442d76a93957073660d7d9ffd12@intel.com> <44f9b69d23678458f0ab3ff4bec5c45cb05535b8@intel.com> <4d0e3bfe-d3e3-43fb-8964-b9647e914a61@intel.com> Content-Language: en-US From: Maarten Lankhorst In-Reply-To: X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" This is a multi-part message in MIME format. --------------R0Tq0GvnscqGqTLdPlU8ykIC Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hey, Den 2026-04-08 kl. 17:14, skrev Jani Nikula: > On Thu, 02 Apr 2026, Maarten Lankhorst wrote: >> Den 2026-04-02 kl. 11:40, skrev Jani Nikula: >>> On Wed, 03 Dec 2025, Maarten Lankhorst wrote: >>>> Hey, >>>> >>>> Den 2025-11-25 kl. 18:24, skrev Ville Syrjälä: >>>>> On Tue, Nov 25, 2025 at 03:55:02PM +0200, Jani Nikula wrote: >>>>>> Maarten, Ville, any ideas what to do about these? >>>>> Looks like we need the timeout to unbreak the modeset vs. reset >>>>> deadlock in a timely fashion. >>>>> >>>>> I'm not where we signal/error the fences the modeset is waiting >>>>> for, but I guess that must be happening after the whole reset >>>>> sequence is done. Doing that earlier would seem like another >>>>> solution, but dunno what other fallout it would have. >>>> intel_prepare_plane_fb() adds all dma-resv fences for old_obj on >>>> intel_crtc_needs_modeset(), does it change anything if we remove that, >>>> at least for the GPU reset commit? >>> We dropped the ball here a bit, and I'm a bit clueless as to what to >>> do. Except we'll need to unify i915 and xe here somehow. >>> >>> Alternatives: >>> >>> - Remove the timeout from i915 (the patch at hand), and fix the fallout >>> somehow. >>> >>> - Add the timeout to xe, and fix the fallout, if any. >>> >>> - Add the timeout to display parent interface, which is a bit meh. >>> >>> >> The mention in the commit is old_obj needs to be wait for flip_done, I do not believe this >> is the case that it was ever used in hardware supported by xe, so for xe the wait can be dropped entirely. >> >> Is this required for i915 still? In that case you can just eliminate >> the wait only for xe. > Trouble is, doing things differently basically means using the parent > interface no matter what. > The specific wait mentioned in intel_plane_prepare_plane_fb is only used in pre-universal plane overlay support, and in xf86-video-intel driver on < gen9. (source: intel_skylake_info specifies gen = 0110, and sna_wait_for_scanline() returns false for gen >= 0110 on sna.) Adding a < GEN9 check would be sufficient, and not driver specific. Kind regards, ~Maarten Lankhorst --------------R0Tq0GvnscqGqTLdPlU8ykIC Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit Hey,

Den 2026-04-08 kl. 17:14, skrev Jani Nikula:
On Thu, 02 Apr 2026, Maarten Lankhorst <maarten.lankhorst@intel.com> wrote:
Den 2026-04-02 kl. 11:40, skrev Jani Nikula:
On Wed, 03 Dec 2025, Maarten Lankhorst <maarten.lankhorst@intel.com> wrote:
Hey,

Den 2025-11-25 kl. 18:24, skrev Ville Syrjälä:
On Tue, Nov 25, 2025 at 03:55:02PM +0200, Jani Nikula wrote:
Maarten, Ville, any ideas what to do about these?
Looks like we need the timeout to unbreak the modeset vs. reset
deadlock in a timely fashion.

I'm not where we signal/error the fences the modeset is waiting
for, but I guess that must be happening after the whole reset
sequence is done. Doing that earlier would seem like another
solution, but dunno what other fallout it would have.
intel_prepare_plane_fb() adds all dma-resv fences for old_obj on
intel_crtc_needs_modeset(), does it change anything if we remove that,
at least for the GPU reset commit?
We dropped the ball here a bit, and I'm a bit clueless as to what to
do. Except we'll need to unify i915 and xe here somehow.

Alternatives:

- Remove the timeout from i915 (the patch at hand), and fix the fallout
  somehow.

- Add the timeout to xe, and fix the fallout, if any.

- Add the timeout to display parent interface, which is a bit meh.


The mention in the commit is old_obj needs to be wait for flip_done, I do not believe this
is the case that it was ever used in hardware supported by xe, so for xe the wait can be dropped entirely.

Is this required for i915 still? In that case you can just eliminate
the wait only for xe.
Trouble is, doing things differently basically means using the parent
interface no matter what.

The specific wait mentioned in intel_plane_prepare_plane_fb is only
used in pre-universal plane overlay support, and in xf86-video-intel
driver on < gen9. (source:
intel_skylake_info specifies gen = 0110,
and sna_wait_for_scanline() returns false for gen >= 0110 on sna.)

Adding a < GEN9 check would be sufficient, and not driver specific.

Kind regards,
~Maarten Lankhorst --------------R0Tq0GvnscqGqTLdPlU8ykIC--