Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52A35C2D0A8 for ; Mon, 28 Sep 2020 14:43:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B4F22076A for ; Mon, 28 Sep 2020 14:43:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726605AbgI1OnG (ORCPT ); Mon, 28 Sep 2020 10:43:06 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:47960 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726466AbgI1OnD (ORCPT ); Mon, 28 Sep 2020 10:43:03 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 5769329A5CD Subject: Re: [PATCH v1 2/2] drm/rockchip: fix warning from cdn_dp_resume To: Sam Ravnborg , dri-devel@lists.freedesktop.org, Heiko Stuebner , Thomas Zimmermann Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Sandy Huang , stable@vger.kernel.org References: <20200925215524.2899527-1-sam@ravnborg.org> <20200925215524.2899527-3-sam@ravnborg.org> From: Enric Balletbo i Serra Message-ID: Date: Mon, 28 Sep 2020 16:42:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200925215524.2899527-3-sam@ravnborg.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Sam, Thank you for your patch. On 25/9/20 23:55, Sam Ravnborg wrote: > Commit 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static") > introduced the following warning in some builds: > > cdn-dp-core.c:1124:12: warning: ‘cdn_dp_resume’ defined but not used > 1124 | static int cdn_dp_resume(struct device *dev) > | ^~~~~~~~~~~~~ > > Fix this by defining cdn_dp_resume __maybe_unused > > Signed-off-by: Sam Ravnborg > Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static") > Cc: Enric Balletbo i Serra > Cc: Heiko Stuebner > Cc: Sandy Huang > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org > Cc: # v5.8+ > --- Hopefully this time this change lands ;-) Similar patches [1], [2], [3], were sent in the past by different authors but for some reason never reached upstream. [1] https://lkml.org/lkml/2020/4/28/1703 [2] https://www.spinics.net/lists/dri-devel/msg268818.html [3] https://lkml.org/lkml/2020/8/10/1412 > drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c > index a4a45daf93f2..1162e321aaed 100644 > --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c > +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c > @@ -1121,7 +1121,7 @@ static int cdn_dp_suspend(struct device *dev) Shouldn't cdn_dp_suspend also have a __maybe_unused? With that, Reviewed-by: Enric Balletbo i Serra > return ret; > } > > -static int cdn_dp_resume(struct device *dev) > +static int __maybe_unused cdn_dp_resume(struct device *dev) > { > struct cdn_dp_device *dp = dev_get_drvdata(dev); > >