Return-Path: Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3BD23C0032 for ; Wed, 2 Aug 2023 14:58:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id F4040814B8 for ; Wed, 2 Aug 2023 14:58:16 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org F4040814B8 Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=JR6N+9ts X-Virus-Scanned: amavisd-new at osuosl.org X-Spam-Flag: NO X-Spam-Score: -4.4 X-Spam-Level: X-Spam-Status: No, score=-4.4 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5NpHBdHKj93M for ; Wed, 2 Aug 2023 14:58:16 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by smtp1.osuosl.org (Postfix) with ESMTPS id 3183181497 for ; Wed, 2 Aug 2023 14:58:16 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3183181497 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690988296; x=1722524296; h=message-id:date:subject:to:references:from:in-reply-to: content-transfer-encoding:mime-version; bh=b4eVq17k04bqP12EJ1nSHfPTSWyZUVZIJ6uOB9Q42FY=; b=JR6N+9tsLHrQ0tNGuRHEdXchGC/bAchY/LAwoQHiWxjY4bCt5agVapTn Z8BGkX3MGo6K33wd8FrEfDfKz5Gkj1nsXxmfNPue7ip5emXTSgPF8pv5q MKW7WKG2t57lLjXtZlU1fNKkxNQvQcx/ZQC5IDFNEQewxHUc8Fcwfd2Pw bMqfXpt28EwoCx7VVeLixsmM6WZc0To4nOy7E855sXM5wVRqMMoa8f7fd tPQWfUmM5S0rPcCcNdUt+9eILi6tzrhjQR9g/se302k0boU2DJXBtnI0p CNdsjhogq98nzNzWMvNSXZV+lgskhYCAQ8JmdzNlv/sCXtS0HwYlzK4FP w==; X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="400555034" X-IronPort-AV: E=Sophos;i="6.01,249,1684825200"; d="scan'208";a="400555034" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2023 07:58:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="722871324" X-IronPort-AV: E=Sophos;i="6.01,249,1684825200"; d="scan'208";a="722871324" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga007.jf.intel.com with ESMTP; 02 Aug 2023 07:58:14 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 2 Aug 2023 07:58:13 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 2 Aug 2023 07:58:13 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 2 Aug 2023 07:58:13 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 2 Aug 2023 07:58:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TeA3DTVqX+h1d+E7FLbkTUxTY6F3auffIp+T7CX/yRvJudm/CM5o7zrIbr5RAkotM9AkKp/iz5iJejramdlun38cl8ApH5bPe6jPIa2u8cJmvqokuc2WdXtS3FxkYTSqbiDv0uCaMZCCOx3YSDOtC356jp3mrWBI3TB+T4yCXttNZ2eqBqTfsFsf9lU7hUE+WgexfTzzI/5ao5JQ6o3Uh+UGWAhoVFPaPXZHCWki0GRTijuVAd07TmdqfZnQ8An5vufIxvoPlcWLgHDAESWXa0OpmSuFz75t4CD9Hu5VQHwltFNTsKtPqAFQ0BcQIjv5BGBdaQlwZf1z5VjSnp7RzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FE5AhqJ5KoPi8Hyho9PmOm85SLP0fTNMCMWyqtGv2J0=; b=lQivRsZjkmcsHeBXxhZ9sGf9Kg4KQXUS9mJ7vcW6GdjYcTi5LfWi5vBe8Gfb26gy4P7ETuQ1I11boPtpzYlxG5JoeZNAY3EfBjTBcipOmBD0TGZ1VcFMrxoMZ9T7T5pF9ShY1tN4nPG+t46biZIEk96Smcv6B5KEJalOpZzRm7/+hyEN2NhZXa6uXEy4RzyqARts0ekAKIh/0IQb2mzghQy6+L7H8CPt7Cz4hCtPAAd2b57wU33WIaH9CXui/HMPI0rMeOxOuB1v1kwMfkv8zjzt9D1eThg9CgIyZ7avlCOM5Zk36AAbZoLhQFCPKLOmrMKCHRYWw0KW/zdIfZR/rQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from IA1PR11MB6097.namprd11.prod.outlook.com (2603:10b6:208:3d7::17) by SJ1PR11MB6106.namprd11.prod.outlook.com (2603:10b6:a03:48b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 14:58:10 +0000 Received: from IA1PR11MB6097.namprd11.prod.outlook.com ([fe80::7109:4aa5:6a6d:c3d4]) by IA1PR11MB6097.namprd11.prod.outlook.com ([fe80::7109:4aa5:6a6d:c3d4%5]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 14:58:10 +0000 Message-ID: Date: Wed, 2 Aug 2023 07:58:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Content-Language: en-US To: Dave Jiang , , Ramesh Thomas , Tony Luck References: <20230801215232.4001749-1-fenghua.yu@intel.com> <20230801215232.4001749-3-fenghua.yu@intel.com> <27ab7ee4-c434-3be3-469b-48a0e52e24ef@intel.com> From: Fenghua Yu In-Reply-To: <27ab7ee4-c434-3be3-469b-48a0e52e24ef@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SJ0PR13CA0076.namprd13.prod.outlook.com (2603:10b6:a03:2c4::21) To IA1PR11MB6097.namprd11.prod.outlook.com (2603:10b6:208:3d7::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR11MB6097:EE_|SJ1PR11MB6106:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d06abe8-32c6-48cc-6dd9-08db9368e385 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qKeRLtqwDkTKikBxtKR0WY5EHkNQRIry4KxD0SF9KwpHzB8x3IPvNKwlo0LGPUEgJKCiOgLUj45+pgzJVztGjoAV5rP3USfh2tOzr91zVV49ZEM2XNfggrH5QO6m+k3aK7Z2zL50M427AKBRtPFjDu2CB5rOhPrGzsgsGQpcX1gjqxIvKj6fBX5aKNlgZzIE8fMSDdEBB0IJOKDN4fUXlYCj+1858PRX/Q83wXoUczN1lz1HmCHTk3MTVuvydItj7UXt/Q4egJQD+b7B3hBTU4drLoUIHA9a98hfum2WUyaf+egitVS3xjlP68SO+HCn7TIhaakbrunojZphfBQSF5msTefF4K/YCs76AL4Ac4Ycy4F4NUKNn3vW369cz2LB+ki1OyHj8UkB+THW8rQO4in4fRhmdPc6u+czJEbksOAgvt1247GMBDsQzB+l6tpfx/NnbZpkeWAPa5F6QFVRMz9asE+39snQdUC8XtGBSY3hSN2HteGT7IzkgZ8R91VcThnGbWWUUEIuJtmwvdiN5IulPPw08GC41spZ3I/qjSY2RSRacyg9PSprkQ9JnGZf1crnfVojIAkiZPoRqLUXtklhJe4RjFST9sNsUINIkglIcjwVRfSlHRxZYdl/pwgsT3k6dny9Soh8+/1etfu7+g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR11MB6097.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(39860400002)(366004)(136003)(396003)(376002)(451199021)(8676002)(5660300002)(83380400001)(2616005)(82960400001)(41300700001)(38100700002)(316002)(186003)(8936002)(53546011)(6506007)(26005)(31686004)(6636002)(86362001)(66946007)(31696002)(66556008)(66476007)(6512007)(2906002)(6486002)(6666004)(36756003)(478600001)(110136005)(44832011)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXQ4bVp4REFHWFZ1QUZyWVFMd01ObUk1V3ZKUDlCeGdHOFBNS29NbXR3VlYz?= =?utf-8?B?enZqR3BBRnpxTTJ2TjIzTDIxbzFVcVhIT1IwRWRMa25BTmV5MmJKaTNWNDEz?= =?utf-8?B?b2U0WnkzOWxNRXpxZEJDUzdyTDdUb1ZGbUFBeUVxVWw0aU1BeitHdkhocVRk?= =?utf-8?B?V3l5azd2aTJLNm9SbERVbC8rYjB2NlNnc25wMnkwWjJ0R2ltL2ZUL1UyK1RT?= =?utf-8?B?eG1wL1E3WDU3YnBuM3EwTFhWa25hdmtDN0p4bGNSYzlGNVZNREpLNmJCSmth?= =?utf-8?B?UDR3ZmRLYVJhUStZM09ycnRhdFB1OVZTYzdmOVZTTTlzcFRRRzEzNFFWT0Ft?= =?utf-8?B?Kyt6YVhRaEljeEdETGowVmVuYWZTMEpnSG5SNmVMdzFtMjJ0RVc1d0xNbHRC?= =?utf-8?B?c1Y0TWFZTUNsUDh2Q0l3SUdQSXFhb2JnWFc4NmpJN3d4czM0ZFRvR05obzdD?= =?utf-8?B?eERnaUw5Mmpob0hGZThyZmNYVEJsbThTbXk3SlBubnRleEFTcExQRHBsZ3ZT?= =?utf-8?B?UVBYdm96QUVjTDJFSGNxakRKWWRJMmV5MldwQ1JSbEFCcnJmZjgwZk1wOUFp?= =?utf-8?B?VDE1R3ZkdG5LbFBuUXA3VEZ6VnAvbmZuYlFWR253aG9zMXFUTG9EdHBzRTRa?= =?utf-8?B?MUErczdBcE5wUmVYdW0zR3Z1d0FkWEFCMDcrazVZRVN5a2VvK0lrY0s3UzZu?= =?utf-8?B?N0NUODQvNjF3UElLYjFmcXV1SzNid3h0c0NXemxGdUFSdDM1bUFnOFpkMDRT?= =?utf-8?B?Y09BK2VQR1Z0SjZ2QlRDUGRyUnlXZFhGVFBac09BODBYb1dFNllsN25ndzNP?= =?utf-8?B?Qmg1dkxGUldjR3BVL3ZabUd1d1didUg5ZjlFaEZqTTN1RGh4Q1l2NVdSZ0hI?= =?utf-8?B?MU1vTjRnRHZQUnc4VHlSYXExY0JqV3hubTZEb0hSbUtKTjNuMU9wS0xKbHJu?= =?utf-8?B?T25DNU9ZSEFXUlVJdGNock9tTU5mZVVzMDVoeFV3QVNZWnF6UjZBTEFFZVpo?= =?utf-8?B?N0g5OFJYOC93TXM2Rkhkd21rd3VvRXZmbHpSdTF6Z0o3RTVtcTRQMVN3NlZv?= =?utf-8?B?ditJcHpiY0h6VzVEUTJvcUlVbjRaV0RUTXo0UnF2TjhFUUVjVmFsT0pVcmFZ?= =?utf-8?B?T3RVVGtDR0VEUEVEckJFMFhwUTB5amhkcUtIUFJjdzBoeEZPZEczbStmWE5Q?= =?utf-8?B?VS81YzBEVW5vSk5aUHhSaE0xL1UzaWw1b0VjMGdWREZucllWeWRKMVNVajBm?= =?utf-8?B?MHdvdW11c0ZhN0ExdmtpUGVpc1ZCQmdiS3p6Zm5hY3k2UmRXZVlqb3hoeHVL?= =?utf-8?B?eWlhR1NWcHNLTWdvZlFSbWNIZUNuYzFuaXJhbmQ5YmtNZnllV0hKQW9XOVUy?= =?utf-8?B?Zm1FbkVBZFJ0Z2ttREh0Zng4R2RXZy9qSjRDY0xHbHJlRklSMmJOajdDcjZJ?= =?utf-8?B?cGJuQ0VXYlpyeTlGVHBmdHpEM1RQVk44WXN5Sk9UcWdpZ0VFZmpsZVdVVmRl?= =?utf-8?B?dG1NNGU0NW5tVnVaTDAvVUNNYlpyZGF3Vy9WSUp4OUg0eFBkSFk0K3lWNEhM?= =?utf-8?B?SmI4cEllQ1dqT2x4cnBvYVVkVG1vY3p0ZWVFbHEyOHZKOTY4em1ZUHBOc3V6?= =?utf-8?B?MVdCdzRtYXFXQUNPeXNDUGl1SU81ZENXVTZCb05oWlppVWJQTnM4WDZlOXdO?= =?utf-8?B?TXByOGlCaUVTdWs5WXZReFpDWlBiQ3V4N0hkZ3FtcFdHa3IzcEdIaG1TSTV3?= =?utf-8?B?Y2U2U2taRDhkcW9YckVPdGQrTms5em9mN2xma1g2L0tQV0l2Sk1xUTljbUxs?= =?utf-8?B?YkQyb2xZWEljSTBHc1hPajJZa2ZyOStidkVoY1dlVkVwaDhDN2ZqVXg1bjZG?= =?utf-8?B?Um5ydEhUSm5IeWY0QXpLR1lta1ljOVRRQjVHOVQrNThXVVVtdUdDY2RLMFlC?= =?utf-8?B?Y0xCb2lYRVpQZXRCazA4bWViSTJtZ3NRaEVTRTNhRTVyVWsrUHNpeGdQUklL?= =?utf-8?B?d2F0Zy9na1BPeU9ZVzN4ai9ITHloYlo0RzB5RU0xdDBMRnlzOTl3RnpCOFhP?= =?utf-8?B?enMwT054bzRwUHYxaHpyRFNpak9ReXBjYURRNmwySDZrc2RXRHJtMDVwZjBk?= =?utf-8?Q?rRm+w2t+iWur5f9TlbHgaVX3K?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8d06abe8-32c6-48cc-6dd9-08db9368e385 X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 14:58:10.8049 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EBmSM5HcjOW6zFgKKtI4o/dnUd8vjV6DfCgFZaqUonpOnj8n7ixS5Gg/ZH5EIDkTrrZO5WPopCpLdp71ikK2eg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6106 X-OriginatorOrg: intel.com Subject: Re: [Accel-config] [PATCH 2/7] accel-config: Add config-user-default command X-BeenThere: accel-config@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: accel-config List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2023 14:58:17 -0000 Hi, Dave, On 8/1/23 17:14, Dave Jiang wrote: > > > On 8/1/23 14:52, Fenghua Yu wrote: >> Although current accel-config provides thorough ways to configure >> IDXD devices and WQs, sometimes user needs an easier way to configure >> and enable them without many knowledges of IDXD. >> >> A new command "config-user-default" is added to configure and enable >> all available devices and WQs for user usage in the following default >> configurations: >> >> 1. Fixed configurations: >>     "mode":"shared", >>     "group_id":0, >>     "priority":10, >>     "block_on_fault":1, >>     "name":"user_default_wq", >>     "ats_disable":0, >>     "prs_disable":1 >>     "type": "user" >>     "driver_name":"user", >> >> 2. Calculated configurations: >>     "size": max WQ size / max WQs >>     "threshold": WQ size >> >> 3. Default configurations that have been set by IDXD driver: >>     "max_batch_size" >>     "max_transfer_size" >>     "op_config" >> >> Signed-off-by: Fenghua Yu >> Reviewed-by: Ramesh Thomas >> --- >>   accfg/accel-config.c    |   1 + >>   accfg/config.c          | 268 ++++++++++++++++++++++++++++++++++++++++ >>   accfg/libaccel_config.h |   1 + >>   builtin.h               |   1 + >>   4 files changed, 271 insertions(+) >> >> diff --git a/accfg/accel-config.c b/accfg/accel-config.c >> index a897608..cf3882e 100644 >> --- a/accfg/accel-config.c >> +++ b/accfg/accel-config.c >> @@ -67,6 +67,7 @@ static struct cmd_struct commands[] = { >>       {"config-group", cmd_config_group}, >>       {"config-wq", cmd_config_wq}, >>       {"config-engine", cmd_config_engine}, >> +    {"config-user-default", cmd_config_default}, >>   #ifdef ENABLE_TEST >>       {"test", cmd_test}, >>   #endif >> diff --git a/accfg/config.c b/accfg/config.c >> index 2631fd9..f3fa83f 100644 >> --- a/accfg/config.c >> +++ b/accfg/config.c >> @@ -119,6 +119,87 @@ static bool is_wq_threshold_writable(struct >> accfg_wq *wq, int val); >>   static bool is_wq_prs_disable_writable(struct accfg_wq *wq, int val); >>   static bool is_wq_ats_disable_writable(struct accfg_wq *wq, int val); >> +static int get_wq_size(struct accfg_device *dev) >> +{ >> +    int max_wq_size, max_wqs; >> + >> +    max_wq_size = accfg_device_get_max_work_queues_size(dev); >> +    max_wqs = accfg_device_get_max_work_queues(dev); >> + >> +    return max_wq_size / max_wqs; >> +} >> + >> +static int config_default_wq_set_prs_disable(struct accfg_wq *wq, int >> val) >> +{ >> +    if (!is_wq_prs_disable_writable(wq, val)) >> +        return -EPERM; >> + >> +    return accfg_wq_set_prs_disable(wq, val); >> +} >> + >> +static int config_default_wq_set_ats_disable(struct accfg_wq *wq, int >> val) >> +{ >> +    if (!is_wq_ats_disable_writable(wq, val)) >> +        return -EPERM; >> + >> +    return accfg_wq_set_ats_disable(wq, val); >> +} >> + >> +static int config_default_wq_set_threshold(struct accfg_wq *wq, int val) >> +{ >> +    if (!is_wq_threshold_writable(wq, val)) >> +        return -EPERM; threshold only be writable on shared group. >> + >> +    return accfg_wq_set_threshold(wq, val); >> +} >> + >> +static struct conf_def_wq_param { >> +    struct wq_parameters param; >> +    bool configured; >> +} conf_def_wq_param[ACCFG_DEVICE_MAX]; >> + >> +/* Return WQ parameter for dev type. */ >> +static struct wq_parameters *get_conf_def_wq_param(enum >> accfg_device_type type) >> +{ >> +    if (type == ACCFG_DEVICE_DSA) >> +        return &conf_def_wq_param[ACCFG_DEVICE_DSA].param; >> +    else if (type == ACCFG_DEVICE_IAX) >> +        return &conf_def_wq_param[ACCFG_DEVICE_IAX].param; >> + >> +    return NULL; >> +} >> + >> +/* Check if dev is configured. */ >> +static bool conf_def_dev_configured(struct accfg_device *dev) >> +{ >> +    if (accfg_device_get_type(dev) == ACCFG_DEVICE_DSA) >> +        return conf_def_wq_param[ACCFG_DEVICE_DSA].configured; >> +    else if (accfg_device_get_type(dev) == ACCFG_DEVICE_IAX) >> +        return conf_def_wq_param[ACCFG_DEVICE_IAX].configured; >> + >> +    return false; >> +} >> + >> +/* Set WQ parameters based on device cap: size and threshold. */ >> +static int config_default_wq_set_on_dev(struct accfg_device *dev) >> +{ >> +    enum accfg_device_type dev_type; >> +    struct wq_parameters *p; >> + >> +    dev_type = accfg_device_get_type(dev); >> +    p = get_conf_def_wq_param(dev_type); >> +    if (!p) >> +        return -EINVAL; >> + >> +    p->wq_size = get_wq_size(dev); >> +    if (p->wq_size <= 0) >> +        return -ENOSPC; >> + >> +    p->threshold = p->wq_size; > > Should check if wq is shared before setting threshold. threshold has no > meaning for dwq. This is just writing an internal parameter. No need to check mode here, right? The mode check happens during writing threshold via sysfs. Please see this functions: >> +static int config_default_wq_set_threshold(struct accfg_wq *wq, int val) >> +{ >> + if (!is_wq_threshold_writable(wq, val)) >> + return -EPERM; Thanks. -Fenghua