From: John Harrison Subject: Re: [PATCH] drm/i915: Engine relative MMIO Date: Thu, 16 May 2019 18:25:42 -0700 Message-ID: References: <20190513194552.6600-1-John.C.Harrison@Intel.com> <2f07e749-7e44-d3ae-08a7-2b45b811419c@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A8BA8916C for ; Fri, 17 May 2019 01:25:44 +0000 (UTC) In-Reply-To: <2f07e749-7e44-d3ae-08a7-2b45b811419c@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , Intel-GFX@Lists.FreeDesktop.Org Cc: Chris P List-Id: intel-gfx@lists.freedesktop.org T24gNS8xNS8yMDE5IDAxOjUyLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPgo+IE9uIDEzLzA1LzIw MTkgMjA6NDUsIEpvaG4uQy5IYXJyaXNvbkBJbnRlbC5jb20gd3JvdGU6Cj4+IEZyb206IEpvaG4g SGFycmlzb24gPEpvaG4uQy5IYXJyaXNvbkBJbnRlbC5jb20+Cj4+Cj4+IFdpdGggdmlydHVhbCBl bmdpbmVzLCBpdCBpcyBubyBsb25nZXIgcG9zc2libGUgdG8ga25vdyB3aGljaCBzcGVjaWZpYwo+ PiBwaHlzaWNhbCBlbmdpbmUgYSBnaXZlbiByZXF1ZXN0IHdpbGwgYmUgZXhlY3V0ZWQgb24gYXQg dGhlIHRpbWUgdGhhdAo+PiByZXF1ZXN0IGlzIGdlbmVyYXRlZC4gVGhpcyBtZWFucyB0aGF0IHRo ZSByZXF1ZXN0IGl0c2VsZiBtdXN0IGJlIGVuZ2luZQo+PiBhZ25vc3RpYyAtIGFueSBkaXJlY3Qg cmVnaXN0ZXIgd3JpdGVzIG11c3QgYmUgcmVsYXRpdmUgdG8gdGhlIGVuZ2luZQo+PiBhbmQgbm90 IGFic29sdXRlIGFkZHJlc3Nlcy4KPj4KPj4gVGhlIExSSSBjb21tYW5kIGhhcyBzdXBwb3J0IGZv ciBlbmdpbmUgcmVsYXRpdmUgYWRkcmVzc2luZy4gSG93ZXZlciwKPj4gdGhlIG1lY2hhbmlzbSBp cyBub3QgdHJhbnNwYXJlbnQgdG8gdGhlIGRyaXZlci4gVGhlIHNjaGVtZSBmb3IgR2VuMTEKPj4g KE1JX0xSSV9BRERfQ1NfTU1JT19TVEFSVCkgcmVxdWlyZXMgdGhlIExSSSBhZGRyZXNzIHRvIGhh dmUgbm8KPj4gYWJzb2x1dGUgZW5naW5lIGJhc2UgY29tcG9uZW50LiBUaGUgaGFyZHdhcmUgdGhl biBhZGRzIG9uIHRoZSBjb3JyZWN0Cj4+IGVuZ2luZSBvZmZzZXQgYXQgZXhlY3V0aW9uIHRpbWUu Cj4+Cj4+IER1ZSB0byB0aGUgbm9uLXRyaXZpYWwgYW5kIGRpZmZlcmluZyBzY2hlbWVzIG9uIGRp ZmZlcmVudCBoYXJkd2FyZSwgaXQKPj4gaXMgbm90IHBvc3NpYmxlIHRvIHNpbXBseSB1cGRhdGUg dGhlIGNvZGUgdGhhdCBjcmVhdGVzIHRoZSBMUkkKPj4gY29tbWFuZHMgdG8gc2V0IGEgcmVtYXAg ZmxhZyBhbmQgbGV0IHRoZSBoYXJkd2FyZSBnZXQgb24gd2l0aCBpdC4KPj4gSW5zdGVhZCwgdGhp cyBwYXRjaCBhZGRzIGZ1bmN0aW9uIHdyYXBwZXJzIGZvciBnZW5lcmF0aW5nIHRoZSBMUkkKPj4g Y29tbWFuZCBpdHNlbGYgYW5kIHRoZW4gZm9yIGNvbnN0cnVjdGluZyB0aGUgY29ycmVjdCBhZGRy ZXNzIHRvIHVzZQo+PiB3aXRoIHRoZSBMUkkuCj4+Cj4+IHYyOiBGaXggYnVpbGQgYnJlYWsgaW4g R1ZULiBSZW1vdmUgZmxhZ3MgcGFyYW1ldGVyIFtyZXZpZXcgZmVlZGJhY2sKPj4gZnJvbSBDaHJp cyBXXS4KPj4KPj4gdjM6IEZpeCBidWlsZCBicmVhayBpbiBzZWxmdGVzdC4gUmViYXNlIHRvIG5l d2VyIGJhc2UgdHJlZSBhbmQgZml4Cj4+IG1lcmdlIGNvbmZsaWN0Lgo+Pgo+PiB2NDogTW9yZSBy ZWJhc2luZy4gUm1vdmVkIHJlbGF0aXZlIGFkZHJlc3Npbmcgc3VwcG9ydCBmcm9tIEdlbjctOSBv bmx5Cj4+IGNvZGUgcGF0aHMgW3JldmlldyBmZWVkYmFjayBmcm9tIENocmlzIFddLgo+Pgo+PiB2 NTogTW9yZSByZWJhc2luZyAobmV3ICdndCcgZGlyZWN0b3J5KS4gRml4IHdoaXRlIHNwYWNlIGlz c3VlLiBVc2UKPj4gQ09QWSBjbGFzcyByYXRoZXIgdGhhbiBCQ1MwIGlkIGZvciBjaGVja2luZyBh Z2FpbnN0IEJDUyBlbmdpbmUuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEpvaG4gSGFycmlzb24gPEpv aG4uQy5IYXJyaXNvbkBJbnRlbC5jb20+Cj4+IENDOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2 aUBpbnRlbC5jb20+Cj4+IENDOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AbGludXgu aW50ZWwuY29tPgo+PiBDQzogV2lsc29uLCBDaHJpcyBQIDxjaHJpcy5wLndpbHNvbkBpbnRlbC5j b20+Cj4+IC0tLQo+PiDCoCBkcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9lbmdpbmUuaMKg wqDCoMKgwqDCoMKgIHzCoCA0ICsKPj4gwqAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxf ZW5naW5lX2NzLmPCoMKgwqDCoCB8IDExICsrKwo+PiDCoCBkcml2ZXJzL2dwdS9kcm0vaTkxNS9n dC9pbnRlbF9ncHVfY29tbWFuZHMuaMKgIHzCoCA2ICstCj4+IMKgIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2d0L2ludGVsX2xyYy5jwqDCoMKgwqDCoMKgwqDCoMKgwqAgfCA3OSArKysrKysrKysrLS0t LS0tLS0tCj4+IMKgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2xyY19yZWcuaMKgwqDC oMKgwqDCoCB8wqAgNCArLQo+PiDCoCBkcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9tb2Nz LmPCoMKgwqDCoMKgwqDCoMKgwqAgfCAxNyArKy0tCj4+IMKgIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2d0L2ludGVsX3JpbmdidWZmZXIuY8KgwqDCoCB8IDQ1ICsrKysrKysrKy0tCj4+IMKgIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX3dvcmthcm91bmRzLmPCoMKgIHzCoCA0ICstCj4+IMKg IC4uLi9ncHUvZHJtL2k5MTUvZ3Qvc2VsZnRlc3Rfd29ya2Fyb3VuZHMuY8KgwqDCoCB8wqAgOSAr Ky0KPj4gwqAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Z0L21taW9fY29udGV4dC5jwqDCoMKgwqDC oMKgIHwgMTYgKysrLQo+PiDCoCBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2NtZF9wYXJzZXIu Y8KgwqDCoMKgwqDCoMKgIHzCoCA0ICstCj4+IMKgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtX2NvbnRleHQuY8KgwqDCoMKgwqDCoCB8IDEyICstLQo+PiDCoCBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmPCoMKgwqAgfMKgIDMgKy0KPj4gwqAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9wZXJmLmPCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8IDE5ICsr Ky0tCj4+IMKgIDE0IGZpbGVzIGNoYW5nZWQsIDE1NCBpbnNlcnRpb25zKCspLCA3OSBkZWxldGlv bnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2Vu Z2luZS5oIAo+PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2VuZ2luZS5oCj4+IGlu ZGV4IDkzNTliM2E3YWQ5Yy4uMzUwNmM5OTIxODJjIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9ndC9pbnRlbF9lbmdpbmUuaAo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9ndC9pbnRlbF9lbmdpbmUuaAo+PiBAQCAtNTQ2LDQgKzU0Niw4IEBAIHN0YXRpYyBpbmxpbmUg Ym9vbCBpbmplY3RfcHJlZW1wdF9oYW5nKHN0cnVjdCAKPj4gaW50ZWxfZW5naW5lX2V4ZWNsaXN0 cyAqZXhlY2xpc3RzKQo+PiDCoCDCoCAjZW5kaWYKPj4gwqAgK2Jvb2wgaTkxNV9lbmdpbmVfaGFz X3JlbGF0aXZlX2xyaShjb25zdCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzIAo+PiAqZW5naW5lKTsK Pj4gK3UzMiBpOTE1X2dldF9scmlfY21kKGNvbnN0IHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVu Z2luZSwgdTMyIAo+PiB3b3JkX2NvdW50KTsKPj4gK3UzMiBpOTE1X2dldF9scmlfcmVnKGNvbnN0 IHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwgCj4+IGk5MTVfcmVnX3QgcmVnKTsKPj4g Kwo+PiDCoCAjZW5kaWYgLyogX0lOVEVMX1JJTkdCVUZGRVJfSF8gKi8KPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2VuZ2luZV9jcy5jIAo+PiBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2d0L2ludGVsX2VuZ2luZV9jcy5jCj4+IGluZGV4IDRjMzc1M2MxYjU3My4u MjMzMjk1ZDY4OWQyIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRl bF9lbmdpbmVfY3MuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9lbmdp bmVfY3MuYwo+PiBAQCAtMjUzLDYgKzI1MywxNyBAQCBzdGF0aWMgdTMyIF9fZW5naW5lX21taW9f YmFzZShzdHJ1Y3QgCj4+IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsCj4+IMKgwqDCoMKgwqAgcmV0 dXJuIGJhc2VzW2ldLmJhc2U7Cj4+IMKgIH0KPj4gwqAgK2Jvb2wgaTkxNV9lbmdpbmVfaGFzX3Jl bGF0aXZlX2xyaShjb25zdCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzIAo+PiAqZW5naW5lKQo+PiAr ewo+PiArwqDCoMKgIGlmIChJTlRFTF9HRU4oZW5naW5lLT5pOTE1KSA8IDExKQo+PiArwqDCoMKg wqDCoMKgwqAgcmV0dXJuIGZhbHNlOwo+PiArCj4+ICvCoMKgwqAgaWYgKGVuZ2luZS0+Y2xhc3Mg PT0gQ09QWV9FTkdJTkVfQ0xBU1MpCj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gZmFsc2U7Cj4+ ICsKPj4gK8KgwqDCoCByZXR1cm4gdHJ1ZTsKPgo+IEkgdGhpbmsgZW5naW5lLT5mbGFncyB3b3Vs ZCBiZSBiZXR0ZXIuIEF0IGxlYXN0IGl0IGlzIG9uZSBjb25kaXRpb25hbCAKPiBpbnN0ZWFkIG9m IHR3byBhdCBydW50aW1lLCBldmVuIG9uZSB0b28gbWFueSBmb3Igc29tZXRoaW5nIHRoYXQgaXMg Cj4gaW52YXJpYW50Lgo+Cj4+ICt9Cj4+ICsKPj4gwqAgc3RhdGljIHZvaWQgX19zcHJpbnRfZW5n aW5lX25hbWUoY2hhciAqbmFtZSwgY29uc3Qgc3RydWN0IAo+PiBlbmdpbmVfaW5mbyAqaW5mbykK Pj4gwqAgewo+PiDCoMKgwqDCoMKgIFdBUk5fT04oc25wcmludGYobmFtZSwgSU5URUxfRU5HSU5F X0NTX01BWF9OQU1FLCAiJXMldSIsCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9ndC9pbnRlbF9ncHVfY29tbWFuZHMuaCAKPj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9p bnRlbF9ncHVfY29tbWFuZHMuaAo+PiBpbmRleCBhMzRlY2U1M2E3NzEuLmU3Nzg0YjNmYjc1OSAx MDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfZ3B1X2NvbW1hbmRz LmgKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfZ3B1X2NvbW1hbmRzLmgK Pj4gQEAgLTEyMyw5ICsxMjMsMTMgQEAKPj4gwqDCoCAqwqDCoCBzaW1wbHkgaWdub3JlcyB0aGUg cmVnaXN0ZXIgbG9hZCB1bmRlciBjZXJ0YWluIGNvbmRpdGlvbnMuCj4+IMKgwqAgKiAtIE9uZSBj YW4gYWN0dWFsbHkgbG9hZCBhcmJpdHJhcnkgbWFueSBhcmJpdHJhcnkgcmVnaXN0ZXJzOiAKPj4g U2ltcGx5IGlzc3VlIHgKPj4gwqDCoCAqwqDCoCBhZGRyZXNzL3ZhbHVlIHBhaXJzLiBEb24ndCBv dmVyZHVlIGl0LCB0aG91Z2gsIHggPD0gMl40IG11c3QgCj4+IGhvbGQhCj4+ICsgKiAtIE5ld2Vy IGhhcmR3YXJlIHN1cHBvcnRzIGVuZ2luZSByZWxhdGl2ZSBhZGRyZXNzZXMgYnV0IG9sZGVyIAo+ PiBoYXJkd2FyZSBkb2VzCj4+ICsgKsKgwqAgbm90LiBTbyBuZXZlciBjYWxsIE1JX0xSSSBkaXJl Y3RseSwgYWx3YXlzIHVzZSB0aGUgCj4+IGk5MTVfZ2V0X2xyaV9jbWQoKQo+PiArICrCoMKgIGFu ZCBpOTE1X2dldF9scmlfcmVnKCkgaGVscGVyIGZ1bmN0aW9ucy4KPj4gwqDCoCAqLwo+PiAtI2Rl ZmluZSBNSV9MT0FEX1JFR0lTVEVSX0lNTSh4KcKgwqDCoCBNSV9JTlNUUigweDIyLCAyKih4KS0x KQo+PiArI2RlZmluZSBfX01JX0xPQURfUkVHSVNURVJfSU1NKHgpwqDCoMKgIE1JX0lOU1RSKDB4 MjIsIDIqKHgpLTEpCj4KPiBTbyB3ZSBlbmQgdXAgd2l0aCBjb2RlIHVzaW5nIF9fTUlfTE9BRF9S RUdJU1RFUl9JTU0gZm9yIGFic29sdXRlLCBhbmQgCj4gaTkxNV9nZXRfbHJpX2NtZCBmb3IgcmVs YXRpdmUgYWRkcmVzc2luZy4gT25lIGlzIGEgbWFjcm8sIGFub3RoZXIgaXMgYSAKPiBmdW5jdGlv biBjYWxsLCBhbmQgbmFtaW5nL2Nhc2UgaXMgZGlmZmVyZW50LgoKTm8uIFRoZSBfX01fTF9SX0lN TSB2ZXJzaW9uIGlzIGZvciBvbGQgY29kZSB0aGF0IGNhbiBvbmx5IHJ1biBvbiAKcHJlLUdlbjEx IGRldmljZXMuIFRoZSBoZWxwZXIgZnVuY3Rpb24gaXMgZm9yIGFsbCBvdGhlciBjb2RlLiBUaGUg Y2FsbGVyIApkb2VzIG5vdCBrbm93IChvciBjYXJlKSB3aGV0aGVyIGl0IHNob3VsZCBiZSB1c2lu ZyBhYnNvbHV0ZSBvciByZWxhdGl2ZSAKYWRkcmVzc2luZy4gVGhhdCBpcyB0aGUgcG9pbnQgb2Yg dGhlIGhlbHBlci4KClNlZSBlYXJsaWVyIGRpc2N1c3Npb24gYWJvdXQgd2FudGluZyB0byBtYWtl IGl0IHRvdGFsbHkgb2J2aW91cyB0aGF0IAp1c2luZyB0aGUgc2ltcGxlIG1hY3JvIHZlcnNpb24g aXMgdGhlIHdyb25nIHRoaW5nIHRvIGRvIGluIG5ldyBjb2RlLgoKCj4gLi4uCj4KPiBUaGVuIGFs bCBjYWxsIHNpdGVzIGNhbiB1c2UganVzdCB0aGlzIHNpbmdsZSBoZWxwZXIgYW5kIHRoZSBuYW1p bmcgCj4gcmVtYWlucyBmYW1pbGlhci4KPgoKSSBvcmlnaW5hbGx5IGhhZCBhIHNpbmdsZSBoZWxw ZXIgdG8gYmUgdXNlZCBpbiBhbGwgY2FsbCBzaXRlcy4gQ2hyaXMgCm9iamVjdGVkIHZpb2xlbnRs eSB0byB0aGUgaWRlYSBvZiBjYWxsaW5nIGEgaGVscGVyIGluIGNvZGUgdGhhdCBpcyAKcHVyZWx5 IHByZS1HZW4xMSBhbmQgdGh1cyBoYXMgbm8gbmVlZCBvZiB0aGUgaGVscGVyLgoKT24gdGhlIG90 aGVyIGhhbmQsIFJvZHJpZ28gYWdyZWVkIHdpdGggeW91IHRoYXQgdXNpbmcgdGhlIGhlbHBlciAK ZXZlcnl3aGVyZSB3YXMgY2xlYW5lci4gU28gaXQgaXMgbm93IGEgMiB2cyAxIHZvdGUuLi4KCkpv aG4uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=