Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=jrey@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47HYbD1F10zDqSt for ; Wed, 20 Nov 2019 05:03:19 +1100 (AEDT) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xAJI3DVr122970; Tue, 19 Nov 2019 13:03:15 -0500 Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com with ESMTP id 2wbxncndvj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Nov 2019 13:03:14 -0500 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id xAJI0fbg026000; Tue, 19 Nov 2019 18:03:07 GMT Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by ppma01wdc.us.ibm.com with ESMTP id 2wa8r65d69-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Nov 2019 18:03:07 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xAJI326O10879334 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Nov 2019 18:03:02 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 84A07C605B; Tue, 19 Nov 2019 18:03:02 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8A6B5C6055; Tue, 19 Nov 2019 18:03:01 +0000 (GMT) Received: from demeter.rchland.ibm.com (unknown [9.80.219.76]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTPS; Tue, 19 Nov 2019 18:03:01 +0000 (GMT) Subject: Re: Redfish OpenBMC OEM To: Gunnar Mills , "openbmc@lists.ozlabs.org" Cc: jason.m.bills@linux.intel.com, apparao.puli@linux.intel.com, james.feist@linux.intel.com References: From: Joseph Reynolds Message-ID: Date: Tue, 19 Nov 2019 12:03:00 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-19_06:2019-11-15,2019-11-19 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 phishscore=0 mlxlogscore=999 clxscore=1011 adultscore=0 malwarescore=0 spamscore=0 mlxscore=0 impostorscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1911190154 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Nov 2019 18:03:20 -0000 On 11/19/19 10:23 AM, Gunnar Mills wrote: > Hi All, > > The process seems a little light for adding OpenBMC OEM Redfish > properties and schemas. Can we establish a little more stringent > process for adding these? Can we try to upstream these to the Redfish > standard first before they are added as OpenBMC OEM? Do we need a > design template or someway to collaborate before the OpenBMC OEM > schema or properties are added? Are we okay if pretty > architectural-specific or company-specific properties and schemas are > under the "OpenBMC" OEM namespace? > I suggest getting started with a survey of what the project has. Given that we have Redfish Oem.OpenBMC Properties, we should document them (suggest: docs/designs/Redfish-Oem-Resources.md and using a format similar to the Redfish spec).  Doing so will help: - users know what to expect from the interfaces, - developers to understand the interface, and - the OpenBMC community to help move these fields into the Redfish spec. The proposed Redfish-Oem-Resources document would serve as a good focal point for collaboration within OpenBMC as to how we want to extend the Redfish spec. Reference: Oem Resources are described in the Redfish spec (DSP0266) in the Data model chapter under multiple section such as OEM Resources and Resource extensibility. It seems to me that "OpenBMC" should be used for common elements and "company name" (such as "OpenPower" or "IBM") used when appropriate.  Once again, the OpenBMC community needs to have a focus in this area to sort this out.  IMHO, having a document like Redfish-Oem-Resources.md would help. > I think a majority of the OEM properties in the "OpenBMC" OEM > currently are things Redfish would take. I would like to see us engage > Redfish first. Agreed.  I understand this statement to mean that we should try to upstream new Resources into the Redfish spec first, before we accept them as Oem.OpenBMC resources.  Also, we should try to upstream the existing OpenBMC resources into Redfish. I think having a Redfish-Oem-Resources document would help provide focus to that effort. - Joseph > > Some examples: > FirmwareProvisioningStatus, > https://github.com/openbmc/bmcweb/commit/a6349918ad2c88533c6d09bb876812375a19f2c4 > > FanZones, > https://github.com/openbmc/bmcweb/blob/a6349918ad2c88533c6d09bb876812375a19f2c4/static/redfish/v1/JsonSchemas/OemManager/index.json#L248 > > Thanks, > Gunnar >