From: Florian Fainelli Date: Tue, 19 Jan 2021 17:47:38 +0000 Subject: Re: [PATCH net-next] net: dsa: Fix off by one in dsa_loop_port_vlan_add() Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: ", Andrew Lunn" , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org On 1/19/2021 6:53 AM, Dan Carpenter wrote: > The > comparison is intended to be >= to prevent reading beyond the > end of the ps->vlans[] array. It doesn't affect run time though because > the ps->vlans[] array has VLAN_N_VID (4096) elements and the vlan->vid > cannot be > 4094 because it is checked earlier. > > Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver") > Signed-off-by: Dan Carpenter Acked-by: Florian Fainelli -- Florian