Return-Path: virtio-comment-return-1614-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 57DA19863F9 for ; Wed, 30 Dec 2020 08:16:03 +0000 (UTC) References: <20201218042302.8884-1-jasowang@redhat.com> <20201221223338.7b5a21e6.pasic@linux.ibm.com> <20201222075005.69d1cc6e.pasic@linux.ibm.com> <20201222131404.61e4a136.cohuck@redhat.com> <7da54d5b-0787-c78f-4b35-6a4f7ed2f5bf@redhat.com> <20201222165431.3f49de29.cohuck@redhat.com> <3cf88dc9-4053-0f24-854f-6cc6df2aaac4@redhat.com> <20201225083835.62efb230.pasic@linux.ibm.com> <20201227044431-mutt-send-email-mst@kernel.org> <20201228072104.08339352.pasic@linux.ibm.com> <30369ca4-6621-ea70-abbf-01c62666044b@redhat.com> <20201229143511.403fdefd.pasic@linux.ibm.com> From: Jason Wang Message-ID: Date: Wed, 30 Dec 2020 16:15:47 +0800 MIME-Version: 1.0 In-Reply-To: <20201229143511.403fdefd.pasic@linux.ibm.com> Subject: Re: [virtio-comment] [PATCH RFC] virtio: introduce VIRTIO_F_DEVICE_STOP Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable To: Halil Pasic Cc: "Michael S. Tsirkin" , Cornelia Huck , stefanha@redhat.com, virtio-comment@lists.oasis-open.org, eperezma@redhat.com, sgarzare@redhat.com List-ID: On 2020/12/29 =E4=B8=8B=E5=8D=889:35, Halil Pasic wrote: > On Mon, 28 Dec 2020 15:01:57 +0800 > Jason Wang wrote: > >> Some part of the virtio has enforced an asynchronous interface during re= set: >> >> For MMIO the spec said: >> >> """ >> >> To stop using the queue the driver MUST write zero (0x0) to this >> QueueReady and MUST read the value back to ensure synchronization. >> >> """ > I read the MMIO quote like a single read is sufficient to ensure > synchronization. I.e. it does not require a loop which waits for > the read to yield the expected value. > >> For PCI it said: >> >> """ >> >> After writing 0 to device_status, the driver MUST wait for a read of >> device_status to return 0 before reinitializing the device. >> >> """ > Yes, this does sound like a loop. And that's what Linux does. But this > is transport (PCI) specific. On a spec level, a reset is a distinct > operation from setting device status (to 0). I'm not sure or it looks unclear to me for this point. E.g the device reset is mentioned in "Device Status Field" belongs to=20 "Basic Facilities of a Virtio Device". But there's no "Device Reset" in=20 "Basic Facilities of a Virtio Device". > It just happens to be > mapped to the PCI transport as setting the status to 0. MMIO did the same. And it makes sense since using a single API to=20 configure/change device status looks simpler. > > For the channel IO transport it is mapped via CCW_CMD_VDEV_RESET while > setting the status is mapped via CCW_CMD_WRITE_STATUS. Yes, but I think actually there's no limitation if we want to tread 0 as=20 a reset command for CCW_CMD_WRITE_STATUS. Thanks > > Regards, > Halil > This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lis= ts Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/