Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA10FC4363A for ; Thu, 29 Oct 2020 14:59:49 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 250FD2067C for ; Thu, 29 Oct 2020 14:59:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="nwg2bDHZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 250FD2067C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.14253.35345 (Exim 4.92) (envelope-from ) id 1kY9Os-0004dB-GW; Thu, 29 Oct 2020 14:59:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 14253.35345; Thu, 29 Oct 2020 14:59:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kY9Os-0004d4-DH; Thu, 29 Oct 2020 14:59:38 +0000 Received: by outflank-mailman (input) for mailman id 14253; Thu, 29 Oct 2020 14:59:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kY9Or-0004cz-Ng for xen-devel@lists.xenproject.org; Thu, 29 Oct 2020 14:59:37 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 55834bec-813f-4c16-b3c8-dcd05ba059fa; Thu, 29 Oct 2020 14:59:37 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 44104AF0C; Thu, 29 Oct 2020 14:59:36 +0000 (UTC) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kY9Or-0004cz-Ng for xen-devel@lists.xenproject.org; Thu, 29 Oct 2020 14:59:37 +0000 X-Inumbo-ID: 55834bec-813f-4c16-b3c8-dcd05ba059fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 55834bec-813f-4c16-b3c8-dcd05ba059fa; Thu, 29 Oct 2020 14:59:37 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1603983576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=muZq2HFe/2X2/+Rl35meEsnwYY1hrkMD6PECAcGQ1ws=; b=nwg2bDHZPvU1YdtTm+cJCgOmhQOjBvI+2RLm3dkfr5R5ptpD4uRKqDOhWquf3sS2UuJPoJ Fq/K1uQotcsjppVL4IgKqckt3JQDWcySxXACArsReZh7wkGbH0tN+tRNi8eolp5oIM49WK PsTl6byEt8kQG35dkZkQ5HsYShDnmBE= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 44104AF0C; Thu, 29 Oct 2020 14:59:36 +0000 (UTC) Subject: Re: [PATCH 12/12] xen/cpupool: make per-cpupool sched-gran hypfs node writable To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Dario Faggioli , xen-devel@lists.xenproject.org References: <20201026091316.25680-1-jgross@suse.com> <20201026091316.25680-13-jgross@suse.com> <18acae1b-eebc-26db-e11c-1847e4221e69@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Thu, 29 Oct 2020 15:59:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <18acae1b-eebc-26db-e11c-1847e4221e69@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 29.10.20 15:58, Jan Beulich wrote: > On 26.10.2020 10:13, Juergen Gross wrote: >> @@ -1088,13 +1098,58 @@ static int cpupool_gran_read(const struct hypfs_entry *entry, >> return copy_to_guest(uaddr, name, strlen(name) + 1) ? -EFAULT : 0; >> } >> >> +static int cpupool_gran_write(struct hypfs_entry_leaf *leaf, >> + XEN_GUEST_HANDLE_PARAM(void) uaddr, >> + unsigned int ulen) >> +{ >> + const struct hypfs_dyndir_id *data; >> + struct cpupool *cpupool; >> + enum sched_gran gran; >> + unsigned int sched_gran; >> + char name[SCHED_GRAN_NAME_LEN]; >> + int ret = 0; >> + >> + if ( ulen > SCHED_GRAN_NAME_LEN ) >> + return -ENOSPC; >> + >> + if ( copy_from_guest(name, uaddr, ulen) ) >> + return -EFAULT; >> + >> + sched_gran = sched_gran_get(name, &gran) ? 0 >> + : cpupool_check_granularity(gran); >> + if ( memchr(name, 0, ulen) != (name + ulen - 1) || sched_gran == 0 ) >> + return -EINVAL; > > I guess the memchr() check wants to happen before the call to > sched_gran_get()? Yes. Juergen