From: "flichtenheld (Code Review)" Date: Wed, 9 Jul 2025 12:14:54 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., heiko@...515..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="+xouQJIYF3Q="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: move macOS dns-updown common code into functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: d12fk Cc: plaisthos , openvpn-devel --+xouQJIYF3Q= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/1074?usp=3Demail ) Change subject: move macOS dns-updown common code into functions ...................................................................... Patch Set 3: Code-Review-1 (2 comments) Patchset: PS3: generally lgtm File distro/dns-scripts/macos-dns-updown.sh: http://gerrit.openvpn.net/c/openvpn/+/1074/comment/3d691171_78bf5722 : PS3, Line 242: local addresses=3D"$(addresses_string $n)" addresses seems to be unused? --=20 To view, visit http://gerrit.openvpn.net/c/openvpn/+/1074?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id6f70237c7205063b001528a40391678b0d093ac Gerrit-Change-Number: 1074 Gerrit-PatchSet: 3 Gerrit-Owner: d12fk Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: d12fk Gerrit-Comment-Date: Wed, 09 Jul 2025 12:14:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --+xouQJIYF3Q= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: d12fk, plaisthos.

Patch set 3:Code-Review -1=

V= iew Change

2 comments:

  • Patchset:

  • File distro/dns-scripts/macos-dns-updown.sh:=

    To view, visit change 1074. To unsubscribe, or for help writing= mail filters, visit setting= s.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: Id6f70237c7205063b001528a403= 91678b0d093ac
    Gerrit-Change-Number: 1074
    Gerrit-PatchSet: 3
    Gerrit-Owner: d12fk <heiko@...515...>
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: d12fk <heiko@...515...>= ;
    Gerrit-Comment-Date: Wed, 09 Jul 2025 12:14:54= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment
    --+xouQJIYF3Q=--