From: Sagar Arun Kamble Subject: Re: [PATCH v2 06/15] drm/i915/guc: Merge log relay file and channel creation Date: Fri, 9 Mar 2018 13:59:36 +0530 Message-ID: References: <20180308154707.21716-1-michal.winiarski@intel.com> <20180308154707.21716-6-michal.winiarski@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2FCDF6E326 for ; Fri, 9 Mar 2018 08:29:39 +0000 (UTC) In-Reply-To: <20180308154707.21716-6-michal.winiarski@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?Q?Micha=c5=82_Winiarski?= , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SGkgTWljaGFsLAoKT25lIGNvbW1lbnQgd2FzIG1pc3NlZCBhbmQgYW5vdGhlciBjb21tZW50IHVw ZGF0ZSBzdWdnZXN0ZWQuCgpPbiAzLzgvMjAxOCA5OjE2IFBNLCBNaWNoYcWCIFdpbmlhcnNraSB3 cm90ZToKPiBXZSBoYXZlIGFsbCB0aGUgaW5mb3JtYXRpb24gd2UgbmVlZCBhdCByZWxheV9vcGVu IGNhbGwgdGltZS4KPiBTaW5jZSB0aGVyZSdzIG5vIHJlYXNvbiB0byBzcGxpdCB0aGUgcHJvY2Vz cyBpbnRvIHJlbGF5X29wZW4gYW5kCj4gcmVsYXlfbGF0ZV9zZXR1cF9maWxlcywgbGV0J3MgcmVt b3ZlIHRoZSBleHRyYSBjb2RlLgo+Cj4gdjI6IFJlbW92ZSBvYnNvbGV0ZWQgY29tbWVudHMgKFNh Z2FyKQo+Cj4gU2lnbmVkLW9mZi1ieTogTWljaGHFgiBXaW5pYXJza2kgPG1pY2hhbC53aW5pYXJz a2lAaW50ZWwuY29tPgo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51 az4KPiBDYzogRGFuaWVsZSBDZXJhb2xvIFNwdXJpbyA8ZGFuaWVsZS5jZXJhb2xvc3B1cmlvQGlu dGVsLmNvbT4KPiBDYzogU2FnYXIgQXJ1biBLYW1ibGUgPHNhZ2FyLmEua2FtYmxlQGludGVsLmNv bT4KPiBDYzogTWljaGFsIFdhamRlY3prbyA8bWljaGFsLndhamRlY3prb0BpbnRlbC5jb20+Cj4g UmV2aWV3ZWQtYnk6IFNhZ2FyIEFydW4gS2FtYmxlIDxzYWdhci5hLmthbWJsZUBpbnRlbC5jb20+ Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9nLmMgfCA2NCArKyst LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA1IGlu c2VydGlvbnMoKyksIDU5IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2d1Y19sb2cuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1 Y19sb2cuYwo+IGluZGV4IDRlYjNlYmQ4ZDZjMy4uZWUwOTgxZjVhMjA4IDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2cuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2d1Y19sb2cuYwo+IEBAIC0xMjEsMTQgKzEyMSw3IEBAIHN0YXRpYyBz dHJ1Y3QgZGVudHJ5ICpjcmVhdGVfYnVmX2ZpbGVfY2FsbGJhY2soY29uc3QgY2hhciAqZmlsZW5h bWUsCj4gICAJaWYgKCFwYXJlbnQpCj4gICAJCXJldHVybiBOVUxMOwo+ICAgCj4gLQkvKgo+IC0J ICogTm90IHVzaW5nIHRoZSBjaGFubmVsIGZpbGVuYW1lIHBhc3NlZCBhcyBhbiBhcmd1bWVudCwg c2luY2UgZm9yIGVhY2gKPiAtCSAqIGNoYW5uZWwgcmVsYXkgYXBwZW5kcyB0aGUgY29ycmVzcG9u ZGluZyBDUFUgbnVtYmVyIHRvIHRoZSBmaWxlbmFtZQo+IC0JICogcGFzc2VkIGluIHJlbGF5X29w ZW4oKS4gVGhpcyBzaG91bGQgYmUgZmluZSBhcyByZWxheSBqdXN0IG5lZWRzIGEKPiAtCSAqIGRl bnRyeSBvZiB0aGUgZmlsZSBhc3NvY2lhdGVkIHdpdGggdGhlIGNoYW5uZWwgYnVmZmVyIGFuZCB0 aGF0IGZpbGUncwo+IC0JICogbmFtZSBuZWVkIG5vdCBiZSBzYW1lIGFzIHRoZSBmaWxlbmFtZSBw YXNzZWQgYXMgYW4gYXJndW1lbnQuCj4gLQkgKi8KPiAtCWJ1Zl9maWxlID0gZGVidWdmc19jcmVh dGVfZmlsZSgiZ3VjX2xvZyIsIG1vZGUsCj4gKwlidWZfZmlsZSA9IGRlYnVnZnNfY3JlYXRlX2Zp bGUoZmlsZW5hbWUsIG1vZGUsCj4gICAJCQkJICAgICAgIHBhcmVudCwgYnVmLCAmcmVsYXlfZmls ZV9vcGVyYXRpb25zKTsKPiAgIAlyZXR1cm4gYnVmX2ZpbGU7Cj4gICB9Cj4gQEAgLTE0OSw0MyAr MTQyLDYgQEAgc3RhdGljIHN0cnVjdCByY2hhbl9jYWxsYmFja3MgcmVsYXlfY2FsbGJhY2tzID0g ewo+ICAgCS5yZW1vdmVfYnVmX2ZpbGUgPSByZW1vdmVfYnVmX2ZpbGVfY2FsbGJhY2ssCj4gICB9 Owo+ICAgCj4gLXN0YXRpYyBpbnQgZ3VjX2xvZ19yZWxheV9maWxlX2NyZWF0ZShzdHJ1Y3QgaW50 ZWxfZ3VjICpndWMpCj4gLXsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9 IGd1Y190b19pOTE1KGd1Yyk7Cj4gLQlzdHJ1Y3QgZGVudHJ5ICpsb2dfZGlyOwo+IC0JaW50IHJl dDsKPiAtCj4gLQlsb2NrZGVwX2Fzc2VydF9oZWxkKCZndWMtPmxvZy5ydW50aW1lLmxvY2spOwo+ IC0KPiAtCS8qIEZvciBub3cgY3JlYXRlIHRoZSBsb2cgZmlsZSBpbiAvc3lzL2tlcm5lbC9kZWJ1 Zy9kcmkvMCBkaXIgKi8KPiAtCWxvZ19kaXIgPSBkZXZfcHJpdi0+ZHJtLnByaW1hcnktPmRlYnVn ZnNfcm9vdDsKPiAtCj4gLQkvKgo+IC0JICogSWYgL3N5cy9rZXJuZWwvZGVidWcvZHJpLzAgbG9j YXRpb24gZG8gbm90IGV4aXN0LCB0aGVuIGRlYnVnZnMgaXMKPiAtCSAqIG5vdCBtb3VudGVkIGFu ZCBzbyBjYW4ndCBjcmVhdGUgdGhlIHJlbGF5IGZpbGUuCj4gLQkgKiBUaGUgcmVsYXkgQVBJIHNl ZW1zIHRvIGZpdCB3ZWxsIHdpdGggZGVidWdmcyBvbmx5LCBmb3IgYXZhaWxpbmcgcmVsYXkKPiAt CSAqIHRoZXJlIGFyZSAzIHJlcXVpcmVtZW50cyB3aGljaCBjYW4gYmUgbWV0IGZvciBkZWJ1Z2Zz IGZpbGUgb25seSBpbiBhCj4gLQkgKiBzdHJhaWdodGZvcndhcmQvY2xlYW4gbWFubmVyIDotCj4g LQkgKiBpKSAgIE5lZWQgdGhlIGFzc29jaWF0ZWQgZGVudHJ5IHBvaW50ZXIgb2YgdGhlIGZpbGUs IHdoaWxlIG9wZW5pbmcgdGhlCj4gLQkgKiAgICAgIHJlbGF5IGNoYW5uZWwuCj4gLQkgKiBpaSkg IFNob3VsZCBiZSBhYmxlIHRvIHVzZSAncmVsYXlfZmlsZV9vcGVyYXRpb25zJyBmb3BzIGZvciB0 aGUgZmlsZS4KPiAtCSAqIGlpaSkgU2V0IHRoZSAnaV9wcml2YXRlJyBmaWVsZCBvZiBmaWxlJ3Mg aW5vZGUgdG8gdGhlIHBvaW50ZXIgb2YKPiAtCSAqCXJlbGF5IGNoYW5uZWwgYnVmZmVyLgo+IC0J ICovCj4gLQlpZiAoIWxvZ19kaXIpIHsKPiAtCQlEUk1fRVJST1IoIkRlYnVnZnMgZGlyIG5vdCBh dmFpbGFibGUgeWV0IGZvciBHdUMgbG9nIGZpbGVcbiIpOwo+IC0JCXJldHVybiAtRU5PREVWOwo+ IC0JfQo+IC0KPiAtCXJldCA9IHJlbGF5X2xhdGVfc2V0dXBfZmlsZXMoZ3VjLT5sb2cucnVudGlt ZS5yZWxheV9jaGFuLCAiZ3VjX2xvZyIsIGxvZ19kaXIpOwo+IC0JaWYgKHJldCA8IDAgJiYgcmV0 ICE9IC1FRVhJU1QpIHsKPiAtCQlEUk1fRVJST1IoIkNvdWxkbid0IGFzc29jaWF0ZSByZWxheSBj aGFuIHdpdGggZmlsZSAlZFxuIiwgcmV0KTsKPiAtCQlyZXR1cm4gcmV0Owo+IC0JfQo+IC0KPiAt CXJldHVybiAwOwo+IC19Cj4gLQo+ICAgc3RhdGljIHZvaWQgZ3VjX21vdmVfdG9fbmV4dF9idWYo c3RydWN0IGludGVsX2d1YyAqZ3VjKQo+ICAgewo+ICAgCS8qCj4gQEAgLTI3MSw3ICsyMjcsNiBA QCBzdGF0aWMgdm9pZCBndWNfcmVhZF91cGRhdGVfbG9nX2J1ZmZlcihzdHJ1Y3QgaW50ZWxfZ3Vj ICpndWMpCj4gICAJLyogR2V0IHRoZSBwb2ludGVyIHRvIHNoYXJlZCBHdUMgbG9nIGJ1ZmZlciAq Lwo+ICAgCWxvZ19idWZfc3RhdGUgPSBzcmNfZGF0YSA9IGd1Yy0+bG9nLnJ1bnRpbWUuYnVmX2Fk ZHI7Cj4gICAKPiAtCj4gICAJLyogR2V0IHRoZSBwb2ludGVyIHRvIGxvY2FsIGJ1ZmZlciB0byBz dG9yZSB0aGUgbG9ncyAqLwo+ICAgCWxvZ19idWZfc25hcHNob3Rfc3RhdGUgPSBkc3RfZGF0YSA9 IGd1Y19nZXRfd3JpdGVfYnVmZmVyKGd1Yyk7Cj4gICAKPiBAQCAtNDQzLDggKzM5OCwxMCBAQCBz dGF0aWMgaW50IGd1Y19sb2dfcmVsYXlfY3JlYXRlKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAg IAkgKiB0aGUgR3VDIGZpcm13YXJlIGxvZ3MsIHRoZSBjaGFubmVsIHdpbGwgYmUgbGlua2VkIHdp dGggYSBmaWxlCj4gICAJICogbGF0ZXIgb24gd2hlbiBkZWJ1Z2ZzIGlzIHJlZ2lzdGVyZWQuCj4g ICAJICovCkFib3ZlIGNvbW1lbnQgbmVlZHMgdG8gYmUgcmVtb3ZlZC91cGRhdGVkLgo+IC0JZ3Vj X2xvZ19yZWxheV9jaGFuID0gcmVsYXlfb3BlbihOVUxMLCBOVUxMLCBzdWJidWZfc2l6ZSwKPiAt CQkJCQluX3N1YmJ1ZnMsICZyZWxheV9jYWxsYmFja3MsIGRldl9wcml2KTsKPiArCWd1Y19sb2df cmVsYXlfY2hhbiA9IHJlbGF5X29wZW4oImd1Y19sb2ciLAo+ICsJCQkJCWRldl9wcml2LT5kcm0u cHJpbWFyeS0+ZGVidWdmc19yb290LAo+ICsJCQkJCXN1YmJ1Zl9zaXplLCBuX3N1YmJ1ZnMsCj4g KwkJCQkJJnJlbGF5X2NhbGxiYWNrcywgZGV2X3ByaXYpOwo+ICAgCWlmICghZ3VjX2xvZ19yZWxh eV9jaGFuKSB7Cj4gICAJCURSTV9FUlJPUigiQ291bGRuJ3QgY3JlYXRlIHJlbGF5IGNoYW4gZm9y IEd1QyBsb2dnaW5nXG4iKTsKPiAgIAo+IEBAIC02NDksMTEgKzYwNiw2IEBAIGludCBpbnRlbF9n dWNfbG9nX3JlZ2lzdGVyKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAgIAo+ICAgCUdFTV9CVUdf T04oZ3VjX2xvZ19oYXNfcnVudGltZShndWMpKTsKPiAgIAo+IC0JLyoKPiAtCSAqIElmIGxvZyB3 YXMgZGlzYWJsZWQgYXQgYm9vdCB0aW1lLCB0aGVuIHNldHVwIG5lZWRlZCB0byBoYW5kbGUKPiAt CSAqIGxvZyBidWZmZXIgZmx1c2ggaW50ZXJydXB0cyB3b3VsZCBub3QgaGF2ZSBiZWVuIGRvbmUg eWV0LCBzbwo+IC0JICogZG8gdGhhdCBub3cuCj4gLQkgKi8KTWF5IGJlIHRoaXMgY29tbWVudCBz aG91bGQgbm90IGhhdmUgYmVlbiBhZGRlZCBhcyBwYXJ0IG9mIHBhdGNoIDUvMTUKPiAgIAlyZXQg PSBndWNfbG9nX3JlbGF5X2NyZWF0ZShndWMpOwo+ICAgCWlmIChyZXQpCj4gICAJCWdvdG8gZXJy Owo+IEBAIC02NjIsMTggKzYxNCwxMiBAQCBpbnQgaW50ZWxfZ3VjX2xvZ19yZWdpc3RlcihzdHJ1 Y3QgaW50ZWxfZ3VjICpndWMpCj4gICAJaWYgKHJldCkKPiAgIAkJZ290byBlcnJfcmVsYXk7Cj4g ICAKPiAtCXJldCA9IGd1Y19sb2dfcmVsYXlfZmlsZV9jcmVhdGUoZ3VjKTsKPiAtCWlmIChyZXQp Cj4gLQkJZ290byBlcnJfdW5tYXA7Cj4gLQo+ICAgCWd1Y19sb2dfZmx1c2hfaXJxX2VuYWJsZShn dWMpOwo+ICAgCj4gICAJbXV0ZXhfdW5sb2NrKCZndWMtPmxvZy5ydW50aW1lLmxvY2spOwo+ICAg Cj4gICAJcmV0dXJuIDA7Cj4gICAKPiAtZXJyX3VubWFwOgo+IC0JZ3VjX2xvZ191bm1hcChndWMp Owo+ICAgZXJyX3JlbGF5Ogo+ICAgCWd1Y19sb2dfcmVsYXlfZGVzdHJveShndWMpOwo+ICAgZXJy OgoKLS0gClRoYW5rcywKU2FnYXIKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo=