From: Simon Goldschmidt Date: Sat, 16 Mar 2019 22:16:24 +0100 Subject: [U-Boot] [PATCH] arm: socfpga: make SPL_TEXT_BASE overridable In-Reply-To: References: <20190315194432.31597-1-simon.k.r.goldschmidt@gmail.com> <67d2935d-876e-4cdd-ffd5-8b4becaff7f5@denx.de> <0ceb8701-bd3d-ee73-1916-a9a473870595@gmail.com> <0f7b308c-f72b-bed8-d424-678254fb4485@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 16.03.19 13:50, Marek Vasut wrote: > On 3/16/19 1:36 PM, Simon Goldschmidt wrote: >> >> >> On Saturday, March 16, 2019, Marek Vasut > > wrote: >> >> On 3/16/19 9:23 AM, Simon Goldschmidt wrote: >> > Am 15.03.2019 um 22:20 schrieb Marek Vasut: >> >> On 3/15/19 8:44 PM, Simon Goldschmidt wrote: >> >>> To boot from fpga on socfpga gen5, we need to set >> >>> CONFIG_SPL_TEXT_BASE to >> >>> 0xC0000000 (hps2fpgaslaves base address). >> >>> >> >>> Since converting CONFIG_SPL_TEXT_BASE to Kconfig hasn't been >> >>> successful so >> >>> far, let's make this value overridable in socfpga_common.h, so that >> >>> we can >> >>> have different board configs override this in socfpga_common.h. >> >>> >> >>> Signed-off-by: Simon Goldschmidt >> > > >> >> >> >> Is this a fix for current release or new feature for next ? >> > >> > Yes, it's a fix for the current release. It's the only thing >> missing to >> > *finally* get mainline SPL booting from FPGA (on socfpga gen5). >> > >> > As written in the log, the original plan was to move >> > CONFIG_SPL_TEXT_BASE to Kconfig completely, but that didn't work out >> > (still), which is why we have to do it in a different way. >> > >> > I could provide a new board config to boot from FPGA if you want, but >> > that did not make much sense to me as the FPGA image would be >> missing... >> >> Well, applied. >> >> >> Thanks. >> >> >> >> That said, do you plan to work on the Kconfig conversion further ? >> What's the problem there ? >> >> >> I started that conversion (still in patchwork) but Tom said it produced >> errors >> and he kind of took it further. I'm not really on track what's still >> missing. >> >> But of course I would still prefer the Kconfig version instead of this >> #ifndef... > > Always :) > What's the status here, Tom? Anything I can do? Should I try again now with my original approach of just using moveconfig.py? Regards, Simon