Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42D00C388F7 for ; Fri, 13 Nov 2020 14:30:55 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D818C20715 for ; Fri, 13 Nov 2020 14:30:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="Kj8ilPr5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D818C20715 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.26540.54972 (Exim 4.92) (envelope-from ) id 1kda64-0001pi-Ez; Fri, 13 Nov 2020 14:30:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 26540.54972; Fri, 13 Nov 2020 14:30:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kda64-0001pb-Bg; Fri, 13 Nov 2020 14:30:40 +0000 Received: by outflank-mailman (input) for mailman id 26540; Fri, 13 Nov 2020 14:30:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kda63-0001pW-BB for xen-devel@lists.xenproject.org; Fri, 13 Nov 2020 14:30:39 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ab0613d7-a5ef-4e46-befe-8b7e9a70e382; Fri, 13 Nov 2020 14:30:38 +0000 (UTC) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kda63-0001pW-BB for xen-devel@lists.xenproject.org; Fri, 13 Nov 2020 14:30:39 +0000 X-Inumbo-ID: ab0613d7-a5ef-4e46-befe-8b7e9a70e382 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ab0613d7-a5ef-4e46-befe-8b7e9a70e382; Fri, 13 Nov 2020 14:30:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1605277838; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=ni6uFxlookvwWxTeqxXDYqjhj5r2NpQO4zQ6Y7g1xrc=; b=Kj8ilPr5CkjA0lT7jUM/dTGARks/z4njiV+Hxo5E/HJSYjF3Hf0ARn/Q UBznh0BDN8AXCuDhxLyv6rHqHeX7VCrwCXxY4+1Y64vDeJxku4iUhnrK9 U/kKS1yOfzRYCVhngSyPpDVayjfKZEP2Rth90f6QRSlV3Xg1Sb8mCxyJS c=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: Yk5nvlNlIf1/NvTnizdS9gf4vQXQxr/pgDrwWahazrT6Pid/u6kQ2a5E2MQv8T2iMqU/DBrFxE 4+ZSovmEEpoPJx5/66XoUrrTkHoY0Ieqqox8g+8HM6x3qqXTGELLnD7YZuGH1RXRrxsekwVIF3 2cxiE9qMDQVs337t2gCPwaaMTEAg0JUSSICnRqHFO8ghoKa1LPPKVjSNuumwon3WmG1JkrODy9 vvENEOOIbQU713DL41cM9saoXXIeqhJ4EWG4r7htvCqCcH+ZZG7wcwryc+ik1vonCc0JH1GeFJ Ptw= X-SBRS: None X-MesageID: 31098301 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.77,475,1596513600"; d="scan'208";a="31098301" Subject: Re: [XEN PATCH] tools/xenstore: Log xenstored build ID on startup To: Bjoern Doebel , CC: Julien Grall , Eslam Elnikety , Ian Jackson , Wei Liu References: <20201113141823.58712-1-doebel@amazon.de> From: Andrew Cooper Message-ID: Date: Fri, 13 Nov 2020 14:30:23 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201113141823.58712-1-doebel@amazon.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To FTLPEX02CL04.citrite.net (10.13.108.177) On 13/11/2020 14:18, Bjoern Doebel wrote: > Right now we do not have a mechanism to determine the version of the > currently running xenstored at runtime. As xenstored runs throughout the > lifetime of a Xen host, this may lead to problems when newer user space > builds are staged. Then, the running xenstored will no longer match the > version of the installed xenstored. > > To allow users to always identify the running version of xenstored, add > a linker-generated unique build ID to every xenstored build. Add > functionality to log this build ID into a file upon service startup. > > Signed-off-by: Bjoern Doebel > Reviewed-by: Martin Mazein > Reviewed-by: Paul Durrant I understand the problem you're trying to solve, but why is this anything more than just enabling build-id's by default across tools/ ? There are already standard ways of interacting with the build id of running executables on the system.  I'd strongly discourage doing anything custom in xenstored specifically. ~Andrew