From: "flichtenheld (Code Review)" Date: Thu, 10 Jul 2025 09:39:46 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="a/UzOaaQllA="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Fix compiler warning in reliable.c with --disable-debug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --a/UzOaaQllA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1082?usp=3Demail to review the following change. Change subject: Fix compiler warning in reliable.c with --disable-debug ...................................................................... Fix compiler warning in reliable.c with --disable-debug Use the easy way out. Using pre-compiler to completely avoid n_active seems like overkill. Change-Id: Icad1a52d14311a6f06bda081cab2f4bded8d47ed Signed-off-by: Frank Lichtenheld --- M src/openvpn/reliable.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/82/1082/1 diff --git a/src/openvpn/reliable.c b/src/openvpn/reliable.c index 6aef112..424d194 100644 --- a/src/openvpn/reliable.c +++ b/src/openvpn/reliable.c @@ -648,6 +648,7 @@ } } } + (void)n_active; /* dmsg might not generate code */ dmsg(D_REL_DEBUG, "ACK reliable_can_send active=3D%d current=3D%d : %s= ", n_active, n_current, -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1082?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Icad1a52d14311a6f06bda081cab2f4bded8d47ed Gerrit-Change-Number: 1082 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-MessageType: newchange --a/UzOaaQllA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

Fix compiler warning in reliable.c with --disable-debug
<= br>Use the easy way out. Using pre-compiler to completely
avoid n_active= seems like overkill.

Change-Id: Icad1a52d14311a6f06bda081cab2f4bded= 8d47ed
Signed-off-by: Frank Lichtenheld <frank@...2641...>
---<= br>M src/openvpn/reliable.c
1 file changed, 1 insertion(+), 0 deletions(= -)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/8=
2/1082/1
diff --git a/src/openvpn/reliable.c b/src/openvpn/reliable=
.c
index 6aef112..424d194 100644
--- a/src/= openvpn/reliable.c
+++ b/src/openvpn/reliable.c
<= span>@@ -648,6 +648,7 @@
}
= }
}
+ (void)n_active; /* dmsg might not generate code */ dmsg(D_REL_DEBUG, "ACK reliable_can_send active=3D%d curre= nt=3D%d : %s",
n_active,
= n_current,

To view, visit change 1082. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Icad1a52d14311a6f06bda081cab= 2f4bded8d47ed
Gerrit-Change-Number: 1082
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-MessageType: newchange
--a/UzOaaQllA=--