From: "plaisthos (Code Review)" Date: Sat, 4 Jan 2025 22:49:22 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., max@...2606..., lstipakov@...277... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="ieAryPGSC+w="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Add methods to read/write packet ids for epoch data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: MaxF , flichtenheld , stipa , openvpn-devel --ieAryPGSC+w= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: MaxF, flichtenheld, stipa. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/803?usp=3Demail ) Change subject: Add methods to read/write packet ids for epoch data ...................................................................... Patch Set 10: (2 comments) File src/openvpn/packet_id.h: http://gerrit.openvpn.net/c/openvpn/+/803/comment/d417abd6_3a14c47d : PS8, Line 331: packed > I'm thinking this is a typo. [=E2=80=A6] typo. Will fix. File tests/unit_tests/openvpn/test_packet_id.c: http://gerrit.openvpn.net/c/openvpn/+/803/comment/9930dda9_9f758def : PS8, Line 241: /* test writing/checking the 48 bit overflow */ > I don't get it, what overflow? Epoch packet counter is max 48 bit. This is 2**48-1. Will extend the commen= t. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/803?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2a104decdb1e77a460f7a6976bcd0560b67a07b5 Gerrit-Change-Number: 803 Gerrit-PatchSet: 10 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: MaxF Gerrit-CC: openvpn-devel Gerrit-CC: stipa Gerrit-Attention: flichtenheld Gerrit-Attention: stipa Gerrit-Attention: MaxF Gerrit-Comment-Date: Sat, 04 Jan 2025 22:49:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: MaxF Gerrit-MessageType: comment --ieAryPGSC+w= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: MaxF, flichtenheld, stipa.

View C= hange

2 comments:

  • File tests/unit_tests/ope= nvpn/test_packet_id.c:

  • To view, vi= sit chang= e 803. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I2a104decdb1e77a460f7a6976bc= d0560b67a07b5
    Gerrit-Change-Number: 803
    Gerrit-PatchSet: 10
    Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-CC: MaxF <max@...2606...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-CC: stipa <lstipakov@...277...> <= /div>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Attention: stipa <lstipakov@...1663...= .>
    Gerrit-Attention: MaxF <max@...2606...> =
    Gerrit-Comment-Date: Sat, 04 Jan 2025 22:49:22= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: MaxF <max@...2606...&g= t;
    Gerrit-MessageType: comment
    --ieAryPGSC+w=--