Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BFB1C43331 for ; Wed, 25 Mar 2020 14:17:22 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 680CB20658 for ; Wed, 25 Mar 2020 14:17:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 680CB20658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jH6q6-00077m-2a; Wed, 25 Mar 2020 14:17:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jH6q4-00077f-Ql for xen-devel@lists.xenproject.org; Wed, 25 Mar 2020 14:17:00 +0000 X-Inumbo-ID: 49e1ed16-6ea3-11ea-8626-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 49e1ed16-6ea3-11ea-8626-12813bfff9fa; Wed, 25 Mar 2020 14:16:59 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 227D6AC4A; Wed, 25 Mar 2020 14:16:58 +0000 (UTC) To: Andrew Cooper References: <20200323101724.15655-1-andrew.cooper3@citrix.com> <20200323101724.15655-8-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: Date: Wed, 25 Mar 2020 15:16:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200323101724.15655-8-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Xen-devel] [PATCH 7/7] x86/ucode/intel: Fold structures together X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 23.03.2020 11:17, Andrew Cooper wrote: > Currently, we allocate an 8 byte struct microcode_patch to point at a > separately allocated struct microcode_intel. This is wasteful. As indicated elsewhere I'm very much in favor of this, but I think it wants doing in one of the earlier series, and then for AMD at the same time. Possibly, to limit code churn there, ... > --- a/xen/arch/x86/cpu/microcode/intel.c > +++ b/xen/arch/x86/cpu/microcode/intel.c > @@ -32,17 +32,12 @@ > > #define pr_debug(x...) ((void)0) > > -struct microcode_header_intel { > +struct microcode_patch { ... accompanying this with #define microcode_header_intel microcode_patch or even ... > - union { > - struct { > - uint16_t year; > - uint8_t day; > - uint8_t month; > - }; > - unsigned int date; > - }; > + uint16_t year; > + uint8_t day; > + uint8_t month; > unsigned int sig; > unsigned int cksum; > unsigned int ldrver; > @@ -57,10 +52,7 @@ struct microcode_header_intel { > unsigned int _datasize; > unsigned int _totalsize; > unsigned int reserved[3]; > -}; > > -struct microcode_intel { > - struct microcode_header_intel hdr; > uint8_t data[]; > }; ... keeping the two structures separate until here, which would make this one what would initially become struct microcode_patch. This is in particular because ... > static void free_patch(struct microcode_patch *patch) > { > - if ( patch ) > - { > - xfree(patch->mc_intel); > - xfree(patch); > - } > + xfree(patch); > } ... in that earlier series you've moved the 2nd xfree() here just to now delete it again. Jan