From: "flichtenheld (Code Review)"
Date: Fri, 22 Nov 2024 14:41:26 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, lstipakov@...277...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="/WVCNFHKH70="; charset=UTF-8
Subject: [Openvpn-devel] [XS] Change in openvpn[master]: mudp.c: keep offset
value when reset buffer
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: stipa
Cc: plaisthos , openvpn-devel
--/WVCNFHKH70=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos, stipa.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne=
t/c/openvpn/+/814?usp=3Demail )
Change subject: mudp.c: keep offset value when reset buffer
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
http://gerrit.openvpn.net/c/openvpn/+/814/comment/e9f0fd7c_69e29b82 :
PS1, Line 7: mudp.c: keep offset value when reset buffer
"resetting"
File src/openvpn/mudp.c:
http://gerrit.openvpn.net/c/openvpn/+/814/comment/fcb8e952_68fe37ee :
PS1, Line 57: /* dco-win server requres prepend with sockaddr, so prese=
rve offset */
"requires"
http://gerrit.openvpn.net/c/openvpn/+/814/comment/dfafbbbe_9d592c2d :
PS1, Line 58: buf_init(&c->c2.buffers->aux_buf, buf.offset);
buf_init can fail (buf_reset_len cannot). Do we need error handling here?
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/814?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I145573555aaace5e94774b5f977d032d3747ed72
Gerrit-Change-Number: 814
Gerrit-PatchSet: 1
Gerrit-Owner: stipa
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: stipa
Gerrit-Comment-Date: Fri, 22 Nov 2024 14:41:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--/WVCNFHKH70=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos, stipa.
View C=
hange
3 comments:
=
"resetting"
File src/openvpn/mudp.c:
Patch Set #1, Line 57: /* dco-win server requres prepend with sockaddr, so preserve=
offset */
"requires"
Patch Set #1, Line 58: buf_init(&c->c2.buffe=
rs->aux_buf, buf.offset);
buf_init can fail (buf_reset_len cannot). Do we need=
error handling here?
To view, visit change 814. To un=
subscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I145573555aaace5e94774b5f977=
d032d3747ed72
Gerrit-Change-Number: 814
Gerrit-PatchSet: 1
Gerrit-Owner: stipa <lstipakov@...277...>=
;
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: stipa <lstipakov@...1663...=
.>
Gerrit-Comment-Date: Fri, 22 Nov 2024 14:41:26=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--/WVCNFHKH70=--