From: Keerthy Date: Fri, 4 Jan 2019 10:09:01 +0530 Subject: [U-Boot] [PATCH 2/2] lib: fdtdec: fixup fdtdec_get_addr_size In-Reply-To: References: <9062dea9-1e48-1428-cc1e-4dbd43c6ba3c@wwwdotorg.org> <1545409471-10036-1-git-send-email-j-keerthy@ti.com> <1545409471-10036-3-git-send-email-j-keerthy@ti.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 03 January 2019 11:44 PM, sjg at google.com wrote: > On 12/21/18 9:24 AM, Keerthy wrote: >> fix up fdtdec_get_addr_size to use fdtdec_get_addr_size_auto_noparent >> so that the address cells and size cells are obtained from the >> parent instead of going by the fixed length. > > This patch makes perfect sense to me. However, I am worried about the > potential existence of code that assumes the current fixed-size logic; > in the past when fixing similar issues like this we've often run into > code that was use "get addr" functions when it should have been using > "get u32" functions and similar, which then broke when we fixed the > implementation to do the right thing. I guess we should still apply the > patch, and fix up any fallout as it appears. Thanks Simon! > > Applied to u-boot-dm/next, thanks! >