Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95CA5C32771 for ; Wed, 21 Sep 2022 05:31:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 36E9784C90; Wed, 21 Sep 2022 07:31:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="jcUpjT+3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7D13184C8B; Wed, 21 Sep 2022 07:31:00 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2088.outbound.protection.outlook.com [40.107.21.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1155884C72 for ; Wed, 21 Sep 2022 07:30:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=peng.fan@oss.nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TFF+W76+vNgYsmtSYKh8DL+nd8t3GziumeeC4FPR8YQQP1Xrg3XxStCwFYWL4W7uAegYXbj8jnZLzYjCWVIZL5e/vYD7P98196MbxqPeWpVT3LF4lJgjUFNPylogY1tVmf4/6xRMpYA5rrCr6Gu3iv31pLGxQu3l6NNGtiCwZaIdd332j7j/ygJg7ZfovkchHbi8NHVt0DODBzgIQK36TUqiFlzpfY2e5DeojC5/8LqzUIAdqXPKiMuLU1y0XNQVRgfVKFAh/4IIViQM0EZojVgGnK2dQ/wApTmCb2duRlMffTm7u8I3a7Rw6ayo5exQW4pQ4vd/0dYSwtcO6XdfVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gko92US9WeNP7sECf2aDreYt7pPw9v61ggqPEkrvQYc=; b=jzjq4V761mD1+G6DrBqqZXtRpn8iIyXOitXj4d4TMQoLviHQHrHHbVEQhwJq7FS4CczIm2uQKlmITpMvF4RplftzfIeOxLlGj4frYl/sluLoTOC7n4ibE+sy+HyjFtxw4F82W6LkXGvLDxuJctbZDUH/l+JdG6YmmT/dM38HTA/KfM1hYjvSVE2gqvH63KrnWfxjessi5ltQel9XWLxylH/qBRMLcv3wr9mWtyqQy/dannnPOUqcwkwu3Bjv63wjHxKOWHmM+jizAp7f3VxBKlRFWzCeycM5QSPRop11gYABUA0y4xMw/UnXRQQA5hFwdUGUE8YXwqMMfGrjyjnPJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gko92US9WeNP7sECf2aDreYt7pPw9v61ggqPEkrvQYc=; b=jcUpjT+3N10K+mRbA7Ksueu345pe/zHNSNtpccn8HhhQUQPgnY+RS0+sjt6G8HdyMZZBZGtg7xxTBx+HWeje6J04JYxiTFQi3xXb8gECGXJlws9dY7NiUV8O29ccx47OjZfq6lJtCNRbq6F5gB2PMWFCHmgBI5cgOBgihlBKZ9s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PR3PR04MB7291.eurprd04.prod.outlook.com (2603:10a6:102:8c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Wed, 21 Sep 2022 05:30:56 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::1eb:dcf:8fd7:867]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::1eb:dcf:8fd7:867%5]) with mapi id 15.20.5632.018; Wed, 21 Sep 2022 05:30:56 +0000 Message-ID: Date: Wed, 21 Sep 2022 13:30:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0 Subject: Re: [PATCH 4/4] ARM: dts: imx8m: imx8mm-mx8menlo: Enable SPL SDP support Content-Language: en-US To: Marek Vasut , u-boot@lists.denx.de Cc: Fabio Estevam , Marcel Ziswiler , Max Krummenacher , Peng Fan , Stefano Babic References: <20220919194118.105820-1-marex@denx.de> <20220919194118.105820-4-marex@denx.de> From: Peng Fan In-Reply-To: <20220919194118.105820-4-marex@denx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SI2PR02CA0018.apcprd02.prod.outlook.com (2603:1096:4:194::18) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PR3PR04MB7291:EE_ X-MS-Office365-Filtering-Correlation-Id: cbf685c1-2832-4dfe-c6d3-08da9b92752f X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E6K9WsfHzdeMWr3efXbK5PJ+j6MFZmL+lE6x49qvNLsL/S0x9mEk0XkmZGFxwpvPpWEjouJCYpKQ4/JwJ7sOWVBU4TThkrNYag4AuHoRWhC2nH+mEFZA9Kc/WuvWwhxwOUAdZnhBK90x+nOH3JzDiMtBLy8HNJ62MJ2PZi3AnaRQY2pcJDcpRmVpvwqyNWsw5Rqn1KHP7lcRhE8mXcezWSuygVDnKHdKUPXNjUG1bKWgnffiDxU+0okP83XjNInBow+Rsd8VLGtmPAwWQoHKAJn5l1whRr4chW3vh0dW2tCgPpyUgjMAH8ZULu7e0xXZwNKN1dt5FzgsaM0vrIIfZET7rUIsHyGLd25+C9BNLT9IuOvV63hYqEbhRTDw2+GpUTrpAnIbbwnCEqD01r8jJaLWcvU7QlBckhA8+nJlI+cj0rCg0eyitKl0cwdb7t5mHiMRpBhGBAn4ADmYQtgwOr8a16mYNsp9QKt+QBweUZbfvp1CnTmPWqz6KwubyF8dUw+ZF2ptF5n2acCm5pTAzgHBQcG1qZpJcbf9IgdtKE/3qt0z5ii2jiV9Icgj8IdswmMsVsTq+EHTZ5AbeI/xIzcxNDRUTlMtZc930msdMoJn4XFFxNfaS35a7Wjf6IW+aRNHu12++LTJomTwC8dNGqgoLJkX/05QkJrWiGwntWP202ktNJr+OsWCUlrmd1S5Z+8DdsUNdaIY8K+Xv13+Zdb4bEATRoVkzMWmQY/LQnrtFA6SSTuR0gaFnNsHrzl08LxwWIxw7RdyaA6CgpBUCQLJW12EVlP7NJIN5THzHTKMnWDo+hqKlzSMomF9Dke0V102nSIySEva2vuj8ozbMMdxeJsL/H30buBpG3P6riI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9417.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(346002)(376002)(366004)(39860400002)(396003)(451199015)(38350700002)(38100700002)(31696002)(86362001)(66556008)(66476007)(4326008)(8676002)(66946007)(41300700001)(54906003)(316002)(8936002)(44832011)(5660300002)(186003)(83380400001)(2616005)(478600001)(6486002)(2906002)(53546011)(6512007)(26005)(52116002)(6506007)(31686004)(6666004)(32563001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c1ZGSExXY3pqOU5WZmU3eTZmNU9HaGliMndrWFM2LzFYTTN3MTB5UlFXOGd0?= =?utf-8?B?Z2R0cmFDU3RiSnliQzRRWU9ZckdtZTJ4QUord0ovZHFMVEwzeVNBQUFDNndk?= =?utf-8?B?Zkc1UzhRVzZQYXJoU3I2ZGVwYTZaMS9Dcm9sR0dLUEhOTzc3eHRaMzJJSHhz?= =?utf-8?B?YXZMbE9vUWtnR0kxRVlwTHNzRStOcWg3ZmFkcElXYkJiZFlsaDJ1NjRuLzc5?= =?utf-8?B?Z0llV0dWeS9tbjQ4S2NGSXJBR1JxVHhzdUhJa3NialM1MUNLQ0hNcklaSHBi?= =?utf-8?B?aWJOTWNDSHprU3FPK2U0OUcyd1hYWWkvUHdBYkFhcnVaQkxOZEdEbE5Hd1RJ?= =?utf-8?B?U2Raa0d1M2ZWNXc1OHB5RHZWQ0JYajB3UUJNdWo2WmcyK1R6MzVEckhiY2Zy?= =?utf-8?B?czdzbmZQMnh6T0liaG5VSjlBNm90RVBJRGFwcnJqTytjVVdScHN4WHRhOGtI?= =?utf-8?B?UVc2ZE8va2paZDk5aDZyOEZiR1dXTit5WFRJK2E0b2lVTUpJcXk4bXRQYm5u?= =?utf-8?B?SURwa1V6cjU4T0lYMFZJaXZXRkxKaTBGZHRyM1phNmUyaWRBQWxYMEJjZjZv?= =?utf-8?B?VGR5UmFhbVh1ZWRUdndPWHpLVjhMOGs2TFRVNVJHc3dncjRjamRvRFJudUVH?= =?utf-8?B?ZGxtOE5ac3h3aUpWRU9xdHIySFJUU1ZFWDVGWE1lcW1CM1RqcFZhWUJQbEdk?= =?utf-8?B?SVdYUFFnSHplbjRQcFRqbUJiMXlzZWNTbkNKaFBMdHU3N1pGUSs4b3IzYzd6?= =?utf-8?B?SjgyYk9aQzV6M1JUUG9HR1Q2NEhnSCtEWjRmY2Rab3lnSDNDWFVENW1RUW5y?= =?utf-8?B?T2k2OGE3dDBpZURoL0YyZFJIMjdUeWNZbHRnNGpkT1A2aHE2dVd6OEFZUk9p?= =?utf-8?B?MEJvdWZvSTBuSUxUVmQyOXJKYXJxd0xhdmFMOVFKbGZuNW11aGo2N3hPeVZM?= =?utf-8?B?dGgzSDBWNzF2MmIrMXhQWnBhekJnOFFTcDJNRWtDS2Z2VkJzRkNzNFk2Ykpz?= =?utf-8?B?c25nS2dXQWJGbDZMQ2htUzlzSkxvL3ZubUQ0ZFpQUDEvTG5BWlNOc3F3VUxj?= =?utf-8?B?SXRiUFJhZ1VsU2U2YVhMNnhHVTVMMEFhZnVNNDJjVlI4a2FSTHBTSkdBMHY2?= =?utf-8?B?TFZwdmFmZzlZbTNaYlBVNGR5S09xa2prUi82c1k2NWZmeEF3TU9NcVRwK1Y2?= =?utf-8?B?cU5EOGs5WFd0ZHFzaHBZV3cvZTRucVZxN0J4NVFCb1NRb2txMm5qQ3YzYnlL?= =?utf-8?B?dUFjL1pjQVNNZVlWOFF1TkVVY3h5NUM3NzB4OWJwNCtsdTRacDBBejNaMmxN?= =?utf-8?B?ZXJvOHpkOENublE2YWNMaDhzVDJXbkdKV1FFVVEyelhva2VwWjFWOHE1Vjc4?= =?utf-8?B?NjlRWHdLZDV4WnVuN0thcDU1b1pJWFUrVWgwWjBrU21RMEd5VFovRVloVEE3?= =?utf-8?B?QmMrNkIrbmptZW55RGV4bUdjaXhWZVhzQnpjS0xrbVdGZ3BIS3BpNWlNWWxa?= =?utf-8?B?Z3RuY0RWeFVxU1A4YzRyTEdoamplazltenVNaW5uZUtiZno0aHB3b0o4VjE1?= =?utf-8?B?S0YvV2wrYUw4TlhYMEZKNWZrRnI1OXNxdzhZZXI4a0ZhYkxNQTZVOXJ4QU9m?= =?utf-8?B?UzNLUTVsamdDYXJqdkcyb0U5VVd0Y1p1emZDZGxlUkY5SXNmNkRONHZjZG5M?= =?utf-8?B?VGx3c3lZbTM0TXFGUXF3ZDVxejRiZlBvd0J5UkVPM2gxYlJpeU1QRnlKU0ll?= =?utf-8?B?VnRVVWxRVThUY29QN0l3OG1qN3AzSUJRaHdGbjFkaXMrVSt2RG5LT0p0bW9m?= =?utf-8?B?aW56UWowTGZqbkV3SDFMMUZ2dWI3cXNHUVh4d2J3VEJHUjNOcEM1aFdwelRL?= =?utf-8?B?bitLMEVIZ3p4Q0ZqT1pxWWRlRlJiMWVlbUN3MExrcEd0cnE2bDZ4eldxYjcw?= =?utf-8?B?RFRXWVFDNFhzRzZyTEVTSXE3NWY3SU9SRTRCL1VnZW1PNEg1UEhhdWJBNFEv?= =?utf-8?B?dWUvMlhDM1VmYkc1MnZoY2R3QUNrcHBuTDZqelpGMVRxTFFSTWJuL2V2NThO?= =?utf-8?B?WVFjZ0wrdHEzYWxLVmVrV0NhOEVteEl1Ylh3QXpZTHAzQ3M5cTJST3NxS1ZS?= =?utf-8?Q?t0j4UiaHYA1XxOm+GMsOZ/Ynr?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: cbf685c1-2832-4dfe-c6d3-08da9b92752f X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 05:30:56.3535 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VMXA1oztehAl3a5R3PzP8/oOaZf4uw2rtBL9QxfF80SIMm23xucLzDIhdFR4qL8nvsSDAqPIRxVbOyiSLf9Aqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7291 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 9/20/2022 3:41 AM, Marek Vasut wrote: > Enable DM USB, DM PHY and USB gadget support in imx8mm-mx8menlo SPL > to let the board continue SDP loading of second stage after the first > stage was loaded by BootROM SDP implementation. It is not possible to > jump back into BootROM v1 and let the BootROM implementation continue > the SDP loading, all this has to be performed by the U-Boot CI HDRC > controller driver and SDP protocol implementation, both of which fit > into the SPL just barely. > > With this patch, it is possible to start both U-Boot SPL and U-Boot > using e.g. uuu on this board as follows: > > $ uuu -brun spl flash.bin > > Signed-off-by: Marek Vasut > --- > Cc: Fabio Estevam > Cc: Marcel Ziswiler > Cc: Max Krummenacher > Cc: Peng Fan > Cc: Stefano Babic > --- > arch/arm/dts/imx8mm-mx8menlo-u-boot.dtsi | 20 ++++++++++++++++++++ > configs/imx8mm-mx8menlo_defconfig | 17 ++++++++++++++++- > 2 files changed, 36 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/dts/imx8mm-mx8menlo-u-boot.dtsi b/arch/arm/dts/imx8mm-mx8menlo-u-boot.dtsi > index 484d493e33c..7f5f8c384e8 100644 > --- a/arch/arm/dts/imx8mm-mx8menlo-u-boot.dtsi > +++ b/arch/arm/dts/imx8mm-mx8menlo-u-boot.dtsi > @@ -17,6 +17,26 @@ > }; > }; > > +&aips4 { > + u-boot,dm-spl; > +}; > + > &i2c4 { > /delete-node/ codec@1a; > }; > + > +®_usb_otg1_vbus { > + u-boot,dm-spl; > +}; > + > +&usbmisc1 { > + u-boot,dm-spl; > +}; > + > +&usbphynop1 { > + u-boot,dm-spl; > +}; > + > +&usbotg1 { > + u-boot,dm-spl; > +}; > diff --git a/configs/imx8mm-mx8menlo_defconfig b/configs/imx8mm-mx8menlo_defconfig > index 929ff382f27..ad6885942d3 100644 > --- a/configs/imx8mm-mx8menlo_defconfig > +++ b/configs/imx8mm-mx8menlo_defconfig > @@ -50,6 +50,9 @@ CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR=y > CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x300 > CONFIG_SPL_I2C=y > CONFIG_SPL_POWER=y > +CONFIG_SPL_USB_HOST=y Nitpick, would this option required? Otherwise looks good to me, Reviewed-by: Peng Fan > +CONFIG_SPL_USB_GADGET=y > +CONFIG_SPL_USB_SDP_SUPPORT=y > CONFIG_SPL_WATCHDOG=y > CONFIG_SYS_MAXARGS=64 > CONFIG_SYS_CBSIZE=2048 > @@ -65,6 +68,8 @@ CONFIG_CMD_GPIO=y > CONFIG_CMD_I2C=y > CONFIG_CMD_MMC=y > CONFIG_CMD_USB=y > +CONFIG_CMD_USB_SDP=y > +CONFIG_CMD_USB_MASS_STORAGE=y > CONFIG_CMD_BOOTCOUNT=y > CONFIG_CMD_CACHE=y > CONFIG_CMD_UUID=y > @@ -106,6 +111,8 @@ CONFIG_PHY_MICREL=y > CONFIG_PHY_MICREL_KSZ90X1=y > CONFIG_FEC_MXC=y > CONFIG_MII=y > +CONFIG_SPL_PHY=y > +CONFIG_SPL_NOP_PHY=y > CONFIG_PINCTRL=y > CONFIG_SPL_PINCTRL=y > CONFIG_PINCTRL_IMX8M=y > @@ -125,7 +132,15 @@ CONFIG_SYSRESET_PSCI=y > CONFIG_SYSRESET_WATCHDOG=y > CONFIG_DM_THERMAL=y > CONFIG_USB=y > -# CONFIG_SPL_DM_USB is not set > CONFIG_USB_EHCI_HCD=y > +CONFIG_MXC_USB_OTG_HACTIVE=y > +# CONFIG_USB_STORAGE is not set > +CONFIG_USB_GADGET=y > +CONFIG_USB_GADGET_MANUFACTURER="Menlo" > +CONFIG_USB_GADGET_VENDOR_NUM=0x0525 > +CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 > +CONFIG_CI_UDC=y > +CONFIG_SDP_LOADADDR=0x40400000 > +CONFIG_USB_GADGET_DOWNLOAD=y > CONFIG_IMX_WATCHDOG=y > CONFIG_OF_LIBFDT_OVERLAY=y