From: Michel Thierry Subject: Re: [PATCH v4 05/13] drm/i915/guc: Make event handler a virtual function Date: Fri, 23 Mar 2018 15:25:58 -0700 Message-ID: References: <20180323144728.61548-1-michal.wajdeczko@intel.com> <20180323144728.61548-6-michal.wajdeczko@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B81C6E071 for ; Fri, 23 Mar 2018 22:26:02 +0000 (UTC) In-Reply-To: <20180323144728.61548-6-michal.wajdeczko@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michal Wajdeczko , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gMy8yMy8yMDE4IDc6NDcgQU0sIE1pY2hhbCBXYWpkZWN6a28gd3JvdGU6Cj4gT24gcGxhdGZv cm1zIHdpdGggQ1RCIGJhc2VkIEd1QyBjb21tdW5pY2F0aW9ucywgd2Ugd2lsbCBoYW5kbGUKPiBH dUMgZXZlbnRzIGluIGEgZGlmZmVyZW50IHdheS4gTGV0J3MgbWFrZSBldmVudCBoYW5kbGVyIGEg dmlydHVhbAo+IGZ1bmN0aW9uIHRvIGFsbG93IGVhc3kgc3dpdGNoIGJldHdlZW4gdGhvc2UgdmFy aWFudHMuCj4gCj4gQ3JlZGl0cy10bzogT3NjYXIgTWF0ZW8gPG9zY2FyLm1hdGVvQGludGVsLmNv bT4KPiBTaWduZWQtb2ZmLWJ5OiBNaWNoYWwgV2FqZGVjemtvIDxtaWNoYWwud2FqZGVjemtvQGlu dGVsLmNvbT4KPiBDYzogRGFuaWVsZSBDZXJhb2xvIFNwdXJpbyA8ZGFuaWVsZS5jZXJhb2xvc3B1 cmlvQGludGVsLmNvbT4KPiBDYzogT3NjYXIgTWF0ZW8gPG9zY2FyLm1hdGVvQGludGVsLmNvbT4K PiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5jIHwgIDggKysrKysrKy0K PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oIHwgMTAgKysrKysrKysrKwo+ICAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYyAgfCAgMiArKwo+ICAgMyBmaWxlcyBjaGFu Z2VkLCAxOSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCgpJJ3ZlIGdvdHRlbiB1c2Vk IHRvICdyZWNlaXZlJywgYnV0ICdoYW5kbGVyJyBtYWtlcyBzZW5zZSB0b28uCgpSZXZpZXdlZC1i eTogTWljaGVsIFRoaWVycnkgPG1pY2hlbC50aGllcnJ5QGludGVsLmNvbT4KCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZ3VjLmMKPiBpbmRleCA5Y2UwMWU1Li4xMThkYjgxIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZ3VjLmMKPiBAQCAtNjksNiArNjksNyBAQCB2b2lkIGludGVsX2d1Y19pbml0X2Vh cmx5KHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAgICAgICAgICBtdXRleF9pbml0KCZndWMtPnNl bmRfbXV0ZXgpOwo+ICAgICAgICAgIHNwaW5fbG9ja19pbml0KCZndWMtPmlycV9sb2NrKTsKPiAg ICAgICAgICBndWMtPnNlbmQgPSBpbnRlbF9ndWNfc2VuZF9ub3A7Cj4gKyAgICAgICBndWMtPmhh bmRsZXIgPSBpbnRlbF9ndWNfdG9faG9zdF9ldmVudF9oYW5kbGVyX25vcDsKPiAgICAgICAgICBn dWMtPm5vdGlmeSA9IGdlbjhfZ3VjX3JhaXNlX2lycTsKPiAgIH0KPiAKPiBAQCAtMzE3LDYgKzMx OCwxMSBAQCBpbnQgaW50ZWxfZ3VjX3NlbmRfbm9wKHN0cnVjdCBpbnRlbF9ndWMgKmd1YywgY29u c3QgdTMyICphY3Rpb24sIHUzMiBsZW4sCj4gICAgICAgICAgcmV0dXJuIC1FTk9ERVY7Cj4gICB9 Cj4gCj4gK3ZvaWQgaW50ZWxfZ3VjX3RvX2hvc3RfZXZlbnRfaGFuZGxlcl9ub3Aoc3RydWN0IGlu dGVsX2d1YyAqZ3VjKQo+ICt7Cj4gKyAgICAgICBXQVJOKDEsICJVbmV4cGVjdGVkIGV2ZW50OiBu byBzdWl0YWJsZSBoYW5kbGVyXG4iKTsKPiArfQo+ICsKPiAgIC8qCj4gICAgKiBUaGlzIGZ1bmN0 aW9uIGltcGxlbWVudHMgdGhlIE1NSU8gYmFzZWQgaG9zdCB0byBHdUMgaW50ZXJmYWNlLgo+ICAg ICovCj4gQEAgLTM4OCw3ICszOTQsNyBAQCBpbnQgaW50ZWxfZ3VjX3NlbmRfbW1pbyhzdHJ1Y3Qg aW50ZWxfZ3VjICpndWMsIGNvbnN0IHUzMiAqYWN0aW9uLCB1MzIgbGVuLAo+ICAgICAgICAgIHJl dHVybiByZXQ7Cj4gICB9Cj4gCj4gLXZvaWQgaW50ZWxfZ3VjX3RvX2hvc3RfZXZlbnRfaGFuZGxl cihzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4gK3ZvaWQgaW50ZWxfZ3VjX3RvX2hvc3RfZXZlbnRf aGFuZGxlcl9tbWlvKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAgIHsKPiAgICAgICAgICBzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBndWNfdG9faTkxNShndWMpOwo+ICAgICAg ICAgIHUzMiBtc2csIHZhbDsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZ3VjLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaAo+IGluZGV4IDdlZTA3 MzIuLjZkYzEwOWEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3Vj LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaAo+IEBAIC05MSw2ICs5 MSw5IEBAIHN0cnVjdCBpbnRlbF9ndWMgewo+ICAgICAgICAgIGludCAoKnNlbmQpKHN0cnVjdCBp bnRlbF9ndWMgKmd1YywgY29uc3QgdTMyICpkYXRhLCB1MzIgbGVuLAo+ICAgICAgICAgICAgICAg ICAgICAgIHUzMiAqcmVzcG9uc2VfYnVmLCB1MzIgcmVzcG9uc2VfYnVmX3NpemUpOwo+IAo+ICsg ICAgICAgLyogR3VDJ3MgRlcgc3BlY2lmaWMgZXZlbnQgaGFuZGxlciBmdW5jdGlvbiAqLwo+ICsg ICAgICAgdm9pZCAoKmhhbmRsZXIpKHN0cnVjdCBpbnRlbF9ndWMgKmd1Yyk7Cj4gKwo+ICAgICAg ICAgIC8qIEd1QydzIEZXIHNwZWNpZmljIG5vdGlmeSBmdW5jdGlvbiAqLwo+ICAgICAgICAgIHZv aWQgKCpub3RpZnkpKHN0cnVjdCBpbnRlbF9ndWMgKmd1Yyk7Cj4gICB9Owo+IEBAIC0xMTMsNiAr MTE2LDExIEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBpbnRlbF9ndWNfbm90aWZ5KHN0cnVjdCBpbnRl bF9ndWMgKmd1YykKPiAgICAgICAgICBndWMtPm5vdGlmeShndWMpOwo+ICAgfQo+IAo+ICtzdGF0 aWMgaW5saW5lIHZvaWQgaW50ZWxfZ3VjX3RvX2hvc3RfZXZlbnRfaGFuZGxlcihzdHJ1Y3QgaW50 ZWxfZ3VjICpndWMpCj4gK3sKPiArICAgICAgIGd1Yy0+aGFuZGxlcihndWMpOwo+ICt9Cj4gKwo+ ICAgLyogR3VDIGFkZHJlc3NlcyBhYm92ZSBHVUNfR0dUVF9UT1AgYWxzbyBkb24ndCBtYXAgdGhy b3VnaCB0aGUgR1RUICovCj4gICAjZGVmaW5lIEdVQ19HR1RUX1RPUCAgIDB4RkVFMDAwMDAKPiAK PiBAQCAtMTUzLDYgKzE2MSw4IEBAIGludCBpbnRlbF9ndWNfc2VuZF9ub3Aoc3RydWN0IGludGVs X2d1YyAqZ3VjLCBjb25zdCB1MzIgKmFjdGlvbiwgdTMyIGxlbiwKPiAgIGludCBpbnRlbF9ndWNf c2VuZF9tbWlvKHN0cnVjdCBpbnRlbF9ndWMgKmd1YywgY29uc3QgdTMyICphY3Rpb24sIHUzMiBs ZW4sCj4gICAgICAgICAgICAgICAgICAgICAgICAgIHUzMiAqcmVzcG9uc2VfYnVmLCB1MzIgcmVz cG9uc2VfYnVmX3NpemUpOwo+ICAgdm9pZCBpbnRlbF9ndWNfdG9faG9zdF9ldmVudF9oYW5kbGVy KHN0cnVjdCBpbnRlbF9ndWMgKmd1Yyk7Cj4gK3ZvaWQgaW50ZWxfZ3VjX3RvX2hvc3RfZXZlbnRf aGFuZGxlcl9ub3Aoc3RydWN0IGludGVsX2d1YyAqZ3VjKTsKPiArdm9pZCBpbnRlbF9ndWNfdG9f aG9zdF9ldmVudF9oYW5kbGVyX21taW8oc3RydWN0IGludGVsX2d1YyAqZ3VjKTsKPiAgIGludCBp bnRlbF9ndWNfc2FtcGxlX2ZvcmNld2FrZShzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpOwo+ICAgaW50 IGludGVsX2d1Y19hdXRoX2h1YyhzdHJ1Y3QgaW50ZWxfZ3VjICpndWMsIHUzMiByc2Ffb2Zmc2V0 KTsKPiAgIGludCBpbnRlbF9ndWNfc3VzcGVuZChzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpOwo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Yy5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfdWMuYwo+IGluZGV4IDM0ZjhhMmMuLjhkYzZhOWMgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3VjLmMKPiBAQCAtMjM0LDYgKzIzNCw3IEBAIHN0YXRpYyBpbnQgZ3VjX2Vu YWJsZV9jb21tdW5pY2F0aW9uKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAgICAgICAgICAgICAg ICAgIHJldHVybiBpbnRlbF9ndWNfY3RfZW5hYmxlKCZndWMtPmN0KTsKPiAKPiAgICAgICAgICBn dWMtPnNlbmQgPSBpbnRlbF9ndWNfc2VuZF9tbWlvOwo+ICsgICAgICAgZ3VjLT5oYW5kbGVyID0g aW50ZWxfZ3VjX3RvX2hvc3RfZXZlbnRfaGFuZGxlcl9tbWlvOwo+ICAgICAgICAgIHJldHVybiAw Owo+ICAgfQo+IAo+IEBAIC0yNDcsNiArMjQ4LDcgQEAgc3RhdGljIHZvaWQgZ3VjX2Rpc2FibGVf Y29tbXVuaWNhdGlvbihzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4gICAgICAgICAgZ2VuOV9kaXNh YmxlX2d1Y19pbnRlcnJ1cHRzKGRldl9wcml2KTsKPiAKPiAgICAgICAgICBndWMtPnNlbmQgPSBp bnRlbF9ndWNfc2VuZF9ub3A7Cj4gKyAgICAgICBndWMtPmhhbmRsZXIgPSBpbnRlbF9ndWNfdG9f aG9zdF9ldmVudF9oYW5kbGVyX25vcDsKPiAgIH0KPiAKPiAgIGludCBpbnRlbF91Y19pbml0X21p c2Moc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+IC0tCj4gMS45LjEKPiAKPiBf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdm eCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKPiAKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==