Content-Type: multipart/mixed; boundary="===============1426973686620345085==" MIME-Version: 1.0 From: Daniel Scally To: kbuild-all@lists.01.org Subject: Re: [PATCH v3 15/15] media: i2c: Add vblank control to ov7251 driver Date: Thu, 05 May 2022 10:10:14 +0100 Message-ID: In-Reply-To: List-Id: --===============1426973686620345085== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 05/05/2022 09:32, Sakari Ailus wrote: > On Thu, May 05, 2022 at 09:04:32AM +0100, Daniel Scally wrote: >> Argh - I screwed up a rebase here, not sure how I missed that. Sorry >> all, let me resend > If it's just that, I can fix it. No need to resend. > Thanks...there's two problems shown though actually, I used 1 instead of vblank_def in the __v4l2_ctrl_modify_range() call in ov7251_set_format(), and the other problem (ov7251_pll1_cfg_24_mhz_319_2_mhz defined but not used) was actually introduced in patch #7 (media: i2c: Add support for new frequencies to ov7251). This change: |static const struct ov7251_pll_cfgs ov7251_pll_cfgs_24_mhz =3D { .pll2 =3D &ov7251_pll2_cfg_24_mhz, .pll1 =3D { [OV7251_LINK_FREQ_240_MHZ] =3D &ov7251_pll1_cfg_24_mhz_240_mhz, + [OV7251_LINK_FREQ_319_2_MHZ] =3D &ov7251_pll1_cfg_19_2_mhz_319_2_mhz, }, }; Should have referred to |ov7251_= pll1_cfg_24_mhz_319_2_mhz. I can fix them, but it wouldn't be until tonight= (sorry, I expected to have this ready much earlier by the end of the weeke= nd!) || --===============1426973686620345085==--