From: "cron2 (Code Review)" Date: Wed, 29 Jan 2025 09:40:47 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641..., a@...2181... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="C7sDLQEgOV8="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: mroute/management: fix uninitialized variable (UNINIT) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: plaisthos , flichtenheld , openvpn-devel --C7sDLQEgOV8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, its_Giaan, ordex, plais= thos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/880?usp=3Demail ) Change subject: mroute/management: fix uninitialized variable (UNINIT) ...................................................................... Patch Set 2: Code-Review-1 (3 comments) Patchset: PS2: close :-) File doc/management-notes.txt: http://gerrit.openvpn.net/c/openvpn/+/880/comment/5aaed102_183dab88 : PS2, Line 211: Thanks for this. I overlooked this in v1, though - I think we should have = protocol at the start `tcp:1.2.3.4:4000`, as this is really the "most commo= n way", and since we *print* the addresses that way now this would be more = logical. Sorry for not spotting this earlier. Also, we might mention "this isn't working for IPv6-connected clients (yet)= , kill by CN or CID instead". File src/openvpn/manage.c: http://gerrit.openvpn.net/c/openvpn/+/880/comment/898e15ca_959b2a49 : PS2, Line 564: As discussed in the management-notes.txt comment, I am convinced that it's = more logical to do protocol first, so p1 -> protocol, p2 -> IP, p3 -> port = then. Sorry again. We do the msg() in that format already ;-) Besides this, the new version & error handling look acceptable (we discusse= d getting rid of ascii2proto() and just checking for "udp" or "tcp" here, b= ut it does not make much of a difference). -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/880?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4be0ff4d308213d2ef8ba66bd3178eee1f60fff1 Gerrit-Change-Number: 880 Gerrit-PatchSet: 2 Gerrit-Owner: its_Giaan Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: ordex Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Attention: flichtenheld Gerrit-Attention: ordex Gerrit-Comment-Date: Wed, 29 Jan 2025 09:40:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --C7sDLQEgOV8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, its_Giaan, ordex, p= laisthos.

Patch set 2:Code-Review -1=

Vi= ew Change

3 comments:

  • Patchset:

  • File doc/management-notes.txt:

    • Patch Set #2, Line 211:

      Thanks for this. I overlooked this in v1, = though - I think we should have protocol at the start `tcp:1.2.3.4:4000`, a= s this is really the "most common way", and since we *print* the = addresses that way now this would be more logical.

      Sorry for not spotting this earlier.<= /p>

      Also, we migh= t mention "this isn't working for IPv6-connected clients (yet), ki= ll by CN or CID instead".

  • File src/openvpn/manage.c:

    • Patch Set #2, Line 564:

      As discussed in the management-notes.txt comment, I am co= nvinced that it's more logical to do protocol first, so p1 -> protoc= ol, p2 -> IP, p3 -> port then. Sorry again.

      We do the msg() in that format alread= y ;-)

      Besides= this, the new version & error handling look acceptable (we discussed g= etting rid of ascii2proto() and just checking for "udp" or "= tcp" here, but it does not make much of a difference).

To view, visit change 880. To unsubscribe, or for help writing mail f= ilters, visit settings.<= /p>

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4be0ff4d308213d2ef8ba66bd31= 78eee1f60fff1
Gerrit-Change-Number: 880
Gerrit-PatchSet: 2
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: ordex <a@...2181...>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: ordex <a@...2181...> <= /div>
Gerrit-Comment-Date: Wed, 29 Jan 2025 09:40:47= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--C7sDLQEgOV8=--