Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE543C54EBD for ; Thu, 12 Jan 2023 10:53:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D479A84A16; Thu, 12 Jan 2023 11:53:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="cFaHV6j4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3483884A16; Thu, 12 Jan 2023 11:53:28 +0100 (CET) Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 971818431A for ; Thu, 12 Jan 2023 11:53:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=prvs=937690b042=patrice.chotard@foss.st.com Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30C80WZA003553; Thu, 12 Jan 2023 11:53:24 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=RMRhbPVCWD1Egpfrk0uEStofVTXH1YvJgSL80DG0tYI=; b=cFaHV6j4dReE2176iqUar0khad4MPt3qjpt+6nRfG7ptaxpLBlviezDumrUFusczXf+Y eL7eAvRaKlY0V9dp0Dd75ng7O7u2lQFPsdDgni02HHVr032F+CE/7whz3f37BtZxrmoU eKX2Dht5ftq67o5dMtrJ5XvOFxscNCK5NYDSJJBPNhaycpyfWdP6OPloqk4nuxcQLHMY nn+AMP+bCphwnpr4O8ve7faT3lFZn2DwRrdtuSV0TAzPS4i+nUtVRgUkedR47uRvSeZ8 +5B30BzzlJQXN9Pk3eVwc9y/5abp2xxaRyZIcM7P4y0yWoRIubmESzz8utOnD7Z1SUc1 qQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3n1k64j8n0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Jan 2023 11:53:24 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 10CC010002A; Thu, 12 Jan 2023 11:53:24 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 0B9E2214D06; Thu, 12 Jan 2023 11:53:24 +0100 (CET) Received: from [10.201.21.26] (10.201.21.26) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.13; Thu, 12 Jan 2023 11:53:23 +0100 Message-ID: Date: Thu, 12 Jan 2023 11:53:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/6] stm32mp: cosmetic: Update of bsec driver Content-Language: en-US To: Patrick Delaunay , CC: Etienne CARRIERE , U-Boot STM32 References: <20230106122020.1110552-1-patrick.delaunay@foss.st.com> <20230106131952.1.Id87d79fb5d89d09c18a30daf4e27b1c78f2ea268@changeid> From: Patrice CHOTARD In-Reply-To: <20230106131952.1.Id87d79fb5d89d09c18a30daf4e27b1c78f2ea268@changeid> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.201.21.26] X-ClientProxiedBy: EQNCAS1NODE4.st.com (10.75.129.82) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-12_06,2023-01-12_01,2022-06-22_01 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Patrick On 1/6/23 13:20, Patrick Delaunay wrote: > Remove unnecessary return in stm32mp_bsec_write_lock and replace tab > by space for plat_auto opts. > > Signed-off-by: Patrick Delaunay > --- > > arch/arm/mach-stm32mp/bsec.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/arm/mach-stm32mp/bsec.c b/arch/arm/mach-stm32mp/bsec.c > index c00130b08b36..51ccff9aa560 100644 > --- a/arch/arm/mach-stm32mp/bsec.c > +++ b/arch/arm/mach-stm32mp/bsec.c > @@ -468,8 +468,6 @@ static int stm32mp_bsec_write_lock(struct udevice *dev, u32 val, u32 otp) > plat = dev_get_plat(dev); > > return bsec_permanent_lock_otp(dev, plat->base, otp); > - > - return -EINVAL; > } > > static int stm32mp_bsec_read(struct udevice *dev, int offset, > @@ -608,7 +606,7 @@ U_BOOT_DRIVER(stm32mp_bsec) = { > .id = UCLASS_MISC, > .of_match = stm32mp_bsec_ids, > .of_to_plat = stm32mp_bsec_of_to_plat, > - .plat_auto = sizeof(struct stm32mp_bsec_plat), > + .plat_auto = sizeof(struct stm32mp_bsec_plat), > .ops = &stm32mp_bsec_ops, > .probe = stm32mp_bsec_probe, > }; Reviewed-by: Patrice Chotard Thanks Patrice