From: Dave Hansen Date: Mon, 05 Mar 2018 19:23:27 +0000 Subject: Re: [PATCH v12 08/11] mm: Clear arch specific VM flags on protection change Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Khalid Aziz , akpm@linux-foundation.org, davem@davemloft.net Cc: mhocko@suse.com, jack@suse.cz, kirill.shutemov@linux.intel.com, ross.zwisler@linux.intel.com, willy@infradead.org, hughd@google.com, n-horiguchi@ah.jp.nec.com, mgorman@suse.de, jglisse@redhat.com, dave.jiang@intel.com, dan.j.williams@intel.com, anthony.yznaga@oracle.com, nadav.amit@gmail.com, zi.yan@cs.rutgers.edu, aarcange@redhat.com, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, henry.willard@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, Khalid Aziz On 02/21/2018 09:15 AM, Khalid Aziz wrote: > +/* Arch-specific flags to clear when updating VM flags on protection change */ > +#ifndef VM_ARCH_CLEAR > +# define VM_ARCH_CLEAR VM_NONE > +#endif > +#define VM_FLAGS_CLEAR (ARCH_VM_PKEY_FLAGS | VM_ARCH_CLEAR) Shouldn't this be defining # define VM_ARCH_CLEAR ARCH_VM_PKEY_FLAGS on x86?