From: "flichtenheld (Code Review)" Date: Wed, 25 Sep 2024 14:12:42 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net, a@...2181... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="Jn2SE42s2nM="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: allow user to specify 'local' multiple times in config files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: plaisthos , openvpn-devel --Jn2SE42s2nM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: its_Giaan, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/436?usp=3Demail ) Change subject: allow user to specify 'local' multiple times in config files ...................................................................... Patch Set 2: Code-Review-1 (4 comments) Patchset: PS2: Need to look into the macOS build failures. File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/436/comment/d52e4152_214d8bc0 : PS2, Line 127: "--local host|* [port] : Local host name or ip address a= nd port. '*' can be used\n" Some of this should move to the documentation instead. http://gerrit.openvpn.net/c/openvpn/+/436/comment/84cfb07a_49de2180 : PS2, Line 997: befor "be for"? File src/openvpn/socket.c: http://gerrit.openvpn.net/c/openvpn/+/436/comment/cbf102c9_02a57533 : PS2, Line 345: int i, j; For new code please move the declaration to the actual first use. No need t= o stay in pre-C99 style. --=20 To view, visit http://gerrit.openvpn.net/c/openvpn/+/436?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20adde09529e2764 Gerrit-Change-Number: 436 Gerrit-PatchSet: 2 Gerrit-Owner: ordex Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Attention: ordex Gerrit-Comment-Date: Wed, 25 Sep 2024 14:12:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --Jn2SE42s2nM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: its_Giaan, ordex, plaisthos.

Patch set 2:Code-Review -1=

Vi= ew Change

4 comments:

  • Patchset:

  • File src/openvpn/o= ptions.c:

  • File src/openvpn/socket.c:

    • Patch Set #2, Line 345: int i, j;

      For new code please move the declaration= to the actual first use. No need to stay in pre-C99 style.

To view, visit change 436. To unsubscribe, or for help writing mail f= ilters, visit settings.<= /p>

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20a= dde09529e2764
Gerrit-Change-Number: 436
Gerrit-PatchSet: 2
Gerrit-Owner: ordex <a@...2181...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Attention: ordex <a@...2181...> <= /div>
Gerrit-Comment-Date: Wed, 25 Sep 2024 14:12:42= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--Jn2SE42s2nM=--