Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31669C433EF for ; Wed, 27 Oct 2021 14:08:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 13C0560F9B for ; Wed, 27 Oct 2021 14:08:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242427AbhJ0OLV (ORCPT ); Wed, 27 Oct 2021 10:11:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:35573 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237672AbhJ0OLV (ORCPT ); Wed, 27 Oct 2021 10:11:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635343735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wgdeyFxPGuqP7X+NdKI/OrLvd/C9GODgzNmDVSEMqQ0=; b=ddMso1YfRgns/yFsL/t0JgYog9fRtfgJ+lVYU5qnZArMlUbkJO6S69MVnrjQqqc80YJxXi Vcm9R7T5p5RVhti51ks8QTMPlbxb1M7WJDWMvlAAmtq0qOHvi8CXGjpD/YAPjaHHWRbM+2 txWWL5jE2FCdOw8HOp83Q1r7tF1VYr0= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-58-VJ-VBIRKMOe-xdsbUxDZMg-1; Wed, 27 Oct 2021 10:08:54 -0400 X-MC-Unique: VJ-VBIRKMOe-xdsbUxDZMg-1 Received: by mail-ed1-f72.google.com with SMTP id o22-20020a056402439600b003dd4f228451so2390227edc.16 for ; Wed, 27 Oct 2021 07:08:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=wgdeyFxPGuqP7X+NdKI/OrLvd/C9GODgzNmDVSEMqQ0=; b=ONwsAxpkNVyFA2VFENyjWR+MCA/Bpc/xY1Q/qARfyOSAIcQqFuoTEjQIzwupwHvxC5 K1hPFFQRqkedfi9L5QBw2wxmp8Kr/7jQg6JvK8Z2hH7EnYqx/5SmEix6oKwAS996/gDT 3oIvpfAwYoxNBabGwVAvOA/E2Pvzh2Dxg89PV8HEq8QZpXMedDr7AKA2N/8Kuff9J9u9 PxwnraQYWvtl/bOZHLshKhlSAQKnhQW7VSRnRHT5NVMV2wA33ftg06s/Mtp7t4EhFQRU 01FSLOk1RKpwPemj8s66a33CrKcYg6z8xQb2m9yhCa8MpYpNK0jQeLwnMaW0gsOKLWmc Mr7Q== X-Gm-Message-State: AOAM530txJXYq/tJ7gM3NPMHjIoQG4Lphc9uYxmVlxH2MqYVXRIqf3/z AIcsxMcrmsz1MYZ/Fu1PjP59ofxVfHHpA8PvHHloWcXCOfkpunGLItGjXma5ORoIPqI+WmNr4FI oerhSKorbQ5dwE2TJWn29lwyUFQl4hEmPAQ== X-Received: by 2002:aa7:de83:: with SMTP id j3mr45938570edv.312.1635343732838; Wed, 27 Oct 2021 07:08:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+UUV3Yl/79WVSquPk3+QAo+NRVNHuOpU1mwgdsycapt1Wdqf2kPi7xam7IHCPbkuKpJIyEQ== X-Received: by 2002:aa7:de83:: with SMTP id j3mr45938552edv.312.1635343732644; Wed, 27 Oct 2021 07:08:52 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:1054:9d19:e0f0:8214? (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id c5sm69098eds.81.2021.10.27.07.08.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Oct 2021 07:08:52 -0700 (PDT) Message-ID: Date: Wed, 27 Oct 2021 16:08:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v4 2/3] platform/x86: asus-wmi: rename platform_profile_* function symbols Content-Language: en-US To: Mario Limonciello , Mark Gross , "Rafael J . Wysocki" Cc: "open list:X86 PLATFORM DRIVERS" , markpearson@lenovo.com, linux-acpi@vger.kernel.org References: <20211026190835.10697-1-mario.limonciello@amd.com> <20211026190835.10697-3-mario.limonciello@amd.com> From: Hans de Goede In-Reply-To: <20211026190835.10697-3-mario.limonciello@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Hi, On 10/26/21 21:08, Mario Limonciello wrote: > An upcoming change to platform profiles will export `platform_profile_get` > as a symbol that can be used by other drivers. Avoid the collision. > > Signed-off-by: Mario Limonciello Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/asus-wmi.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c > index e14fb5fa7324..8f067ac4e952 100644 > --- a/drivers/platform/x86/asus-wmi.c > +++ b/drivers/platform/x86/asus-wmi.c > @@ -2169,8 +2169,8 @@ static ssize_t throttle_thermal_policy_store(struct device *dev, > static DEVICE_ATTR_RW(throttle_thermal_policy); > > /* Platform profile ***********************************************************/ > -static int platform_profile_get(struct platform_profile_handler *pprof, > - enum platform_profile_option *profile) > +static int asus_wmi_platform_profile_get(struct platform_profile_handler *pprof, > + enum platform_profile_option *profile) > { > struct asus_wmi *asus; > int tp; > @@ -2196,8 +2196,8 @@ static int platform_profile_get(struct platform_profile_handler *pprof, > return 0; > } > > -static int platform_profile_set(struct platform_profile_handler *pprof, > - enum platform_profile_option profile) > +static int asus_wmi_platform_profile_set(struct platform_profile_handler *pprof, > + enum platform_profile_option profile) > { > struct asus_wmi *asus; > int tp; > @@ -2236,8 +2236,8 @@ static int platform_profile_setup(struct asus_wmi *asus) > > dev_info(dev, "Using throttle_thermal_policy for platform_profile support\n"); > > - asus->platform_profile_handler.profile_get = platform_profile_get; > - asus->platform_profile_handler.profile_set = platform_profile_set; > + asus->platform_profile_handler.profile_get = asus_wmi_platform_profile_get; > + asus->platform_profile_handler.profile_set = asus_wmi_platform_profile_set; > > set_bit(PLATFORM_PROFILE_QUIET, asus->platform_profile_handler.choices); > set_bit(PLATFORM_PROFILE_BALANCED, >