Received: by 2002:a17:906:da85:b0:8b1:202f:4753 with SMTP id xh5csp1467570ejb; Tue, 14 Feb 2023 09:20:55 -0800 (PST) X-Google-Smtp-Source: AK7set+wl0Nq9QbkWnZpUwJOAD+HxjpwngwUHFOI6za3pDDcgXfxZC4b1UXymbSmYEmfIjMDujRA X-Received: by 2002:ad4:5dca:0:b0:56e:99f2:1bb0 with SMTP id m10-20020ad45dca000000b0056e99f21bb0mr6277370qvh.48.1676395255735; Tue, 14 Feb 2023 09:20:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676395255; cv=none; d=google.com; s=arc-20160816; b=WVerKIvt3fJy8fVR5M5K1sjzU4YbS7aje/HA8DFGDIwM1s3t9voUcMVq8E9B5w3akG s/aSDPHNInnZL7b7wxV1d1mnRal0c4SPCXLXRpUUM109JhaRy8zoBkod3U70tIFweV/L fY7yebh60EzciCZ0oSaSm/X4k62IbAz3uAVm2wCvtx0WYa6KlPvU7P/dAI2WxeU+3sud YpgDo3rHqpjxl/XAY5viO1MH0Hg86jp3vAeezZypFi/8T2sgpPypcZK/jLYUh+8oM9t0 oJcxoyuHOaph6S2oPWe9Fwt62MjuLTH0qamaGjoXtT2M2eQiuGtzzRTHIEueY9N1tq4I oEDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:references:subject:to:from:user-agent:mime-version:date :message-id:dkim-signature:dkim-filter; bh=iJ9UAc0X8dkcScaZD5oh+EryDu9xLZ9cykkbg9dQTPg=; b=yKjGlWWNoQjQVJ/F/htQ8pR05BocDT1TgDV5j59AzZRTBMSKG3cF7ZA8O15cOnIe71 C07hQWQaneiWcvpAF1Z1yY2eb4jsRJSsVcYNi9BlTN2EqrUIEJJl5Df5u4xeX1RtNLNY Qrg3zf9rDHdI0rxFnoXdh/nISHYU4ce7h4GfKmJ56h1tITr8eHVtHUDP4S24/Hx8XoLg dmWrQf5G6lwuVzbR6hEOEstSiIUUvd2jc3UliBnLgKVAFHv52vpFmR2hOSrVk6HtnbPd sOmKgjKQkBp9Tzj1VeaWJLFrM/Lb4wa078urc9eE+7rUn15amRRfcmRmkdgndMtGXj7K bjNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=F2xGcc3n; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g18-20020a0cdf12000000b0056ea6cf0fc2si6689398qvl.352.2023.02.14.09.20.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Feb 2023 09:20:55 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=F2xGcc3n; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRyxp-0002Ad-Jh; Tue, 14 Feb 2023 12:19:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRyxn-00029e-9g; Tue, 14 Feb 2023 12:19:31 -0500 Received: from linux.microsoft.com ([13.77.154.182]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRyxl-0004ue-I3; Tue, 14 Feb 2023 12:19:31 -0500 Received: from [192.168.0.20] (unknown [77.64.253.114]) by linux.microsoft.com (Postfix) with ESMTPSA id 7713720E2D36; Tue, 14 Feb 2023 09:19:25 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7713720E2D36 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1676395166; bh=iJ9UAc0X8dkcScaZD5oh+EryDu9xLZ9cykkbg9dQTPg=; h=Date:From:To:Subject:References:In-Reply-To:From; b=F2xGcc3n8XVdUlst/on6U8sGoEU75OWXH5j18pDyyj6JC4N2Ldz48iFbVfrBUlgi/ zO59rg1LBoomzUGIBy0q4SwXqqTGpTx6UeGYMWWZ1x22mFny7e5himzVpy3AEilg2V 4S66lP+NoEYsoUBnOzvowg80Hdza8mfR8y8/nr30= Message-ID: Date: Tue, 14 Feb 2023 18:19:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 From: eiakovlev@linux.microsoft.com To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org, philmd@linaro.org Subject: Re: [PATCH v4 0/5] Series of fixes for PL011 char device References: <20230123162304.26254-1-eiakovlev@linux.microsoft.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=13.77.154.182; envelope-from=eiakovlev@linux.microsoft.com; helo=linux.microsoft.com X-Spam_score_int: -201 X-Spam_score: -20.2 X-Spam_bar: -------------------- X-Spam_report: (-20.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, NICE_REPLY_A=-0.35, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: DyCgEjuTv0Po On 2/2/23 6:54 PM, Peter Maydell wrote: > On Mon, 23 Jan 2023 at 16:23, Evgeny Iakovlev > wrote: > > > > v4: > > * Fixed post_load hook to be backwards-migratable > > * Refactored some code in 5/5 as per review comments > > > > v3: > > * Introduced a post_load hook for PL011State migration for > > backwards-compatibility due to some input state fragility. > > * No longer touching irq lines in reset method > > * Minor changes based on review feedback. > > > > v2: > > * Moved FIFO depth refactoring part of FIFO flags change into its own > > commit. > > * Added a reset method for PL011 > > Patch 5 in this series breaks "make check" for both the > boot-serial-test and the migration-test (both of which > have some simple code that writes to the serial port). > I suspect in both cases that the guest code is just not > bothering to set the UART control register correctly, > because it's never needed to do so in the past. > > (This does make me wonder about the utility of making > this change -- it seems likely that we're going to break > naive bare-metal intended-to-work-on-QEMU code and not > really benefit any real-world runs-on-real-hardware > code, which is presumably just enabling TX and RX and > leaving it that way.) > > I've taken patches 1-4 into target-arm.next. > > thanks > -- PMM > Thanks Peter! I'll investigate the failures you've mentioned. Maybe you are correct in that regard. Although i have not seen any problems running NTOS.