From: Yu-cheng Yu Subject: Re: [PATCH v10 05/26] x86/cet/shstk: Add Kconfig option for user-mode Shadow Stack Date: Thu, 07 May 2020 09:59:02 -0700 Message-ID: References: <20200429220732.31602-1-yu-cheng.yu@intel.com> <20200429220732.31602-6-yu-cheng.yu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com ([192.55.52.115]:26106 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726320AbgEGQ7A (ORCPT ); Thu, 7 May 2020 12:59:00 -0400 In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz On Thu, 2020-05-07 at 08:55 -0700, Dave Hansen wrote: > On 4/29/20 3:07 PM, Yu-cheng Yu wrote: > > +config X86_INTEL_SHADOW_STACK_USER > > + prompt "Intel Shadow Stacks for user-mode" > > + def_bool n > > + depends on CPU_SUP_INTEL && X86_64 > > + depends on AS_HAS_SHADOW_STACK > > + select ARCH_USES_HIGH_VMA_FLAGS > > + select X86_INTEL_CET > > + select ARCH_HAS_SHADOW_STACK > > I called protection keys: X86_INTEL_MEMORY_PROTECTION_KEYS > > AMD recently posted documentation which shows them implementing it as > well. The "INTEL_" is feeling now like a mistake. > > Going forward, we should probably avoid sticking the company name on > them, if for no other reason than avoiding confusion and/or churn in the > future. > > Shadow stacks, for instance, seem like something that another vendor > might implement one day. So, let's at least remove the "INTEL_" from > the config option names themselves. Mentioning Intel in the changelog > and the Kconfig help text is fine. Yes, sure. Yu-cheng