From: "flichtenheld (Code Review)" Date: Tue, 14 Jan 2025 14:44:19 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="i/+6ejObgfA="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: tls_crypt_v2_write_client_key_file: Fix missing-field-initializers co... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --i/+6ejObgfA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/867?usp=3Demail to review the following change. Change subject: tls_crypt_v2_write_client_key_file: Fix missing-field-initi= alizers compiler warning ...................................................................... tls_crypt_v2_write_client_key_file: Fix missing-field-initializers compiler= warning GCC wants us to be more explicit here. Change-Id: Iaaf80c688ddff79ac9472d7237003713637c140b Signed-off-by: Frank Lichtenheld --- M src/openvpn/tls_crypt.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/67/867/1 diff --git a/src/openvpn/tls_crypt.c b/src/openvpn/tls_crypt.c index 24df930..4c421aa 100644 --- a/src/openvpn/tls_crypt.c +++ b/src/openvpn/tls_crypt.c @@ -691,7 +691,7 @@ struct buffer client_key_pem =3D { 0 }; struct buffer dst =3D alloc_buf_gc(TLS_CRYPT_V2_CLIENT_KEY_LEN + TLS_CRYPT_V2_MAX_WKC_LEN, &gc); - struct key2 client_key =3D { 2 }; + struct key2 client_key =3D { .n =3D 2 }; if (!rand_bytes((void *)client_key.keys, sizeof(client_key.keys))) { -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/867?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iaaf80c688ddff79ac9472d7237003713637c140b Gerrit-Change-Number: 867 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-MessageType: newchange --i/+6ejObgfA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

Vi= ew Change

tls_crypt_v2_write_client_key_file: Fix missing-field-initial=
izers compiler warning

GCC wants us to be more explicit here.
Change-Id: Iaaf80c688ddff79ac9472d7237003713637c140b
Signed-off-by: Fra= nk Lichtenheld <frank@...2641...>
---
M src/openvpn/tls_crypt.c=
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh:=
//gerrit.openvpn.net:29418/openvpn refs/changes/67/867/1
diff --git=
 a/src/openvpn/tls_crypt.c b/src/openvpn/tls_crypt.c
index = 24df930..4c421aa 100644
--- a/src/openvpn/tls_crypt.c
+++ b/src/openvpn/tls_crypt.c
@@ -691,7 +691,7 @= @
struct buffer client_key_pem =3D { 0 };
struct buffer dst =3D alloc_buf_gc(TLS_CRYPT_V2_CLIENT_KEY_LEN
+ TLS_CRYPT_V2_MAX_WKC_L= EN, &gc);
- stru= ct key2 client_key =3D { 2 };
+ struct key2 client_key =3D { .n =3D 2 };

if (!rand_bytes((void *)client_key.keys, sizeof(client_k= ey.keys)))
{

To vi= ew, visit change 867. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iaaf80c688ddff79ac9472d72370= 03713637c140b
Gerrit-Change-Number: 867
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-MessageType: newchange
--i/+6ejObgfA=--