From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m_=28VMware=29?= Subject: Re: [PATCH v2 3/4] drm/ttm, drm/vmwgfx: Correctly support support AMD memory encryption Date: Wed, 4 Sep 2019 15:05:53 +0200 Message-ID: References: <20190903131504.18935-1-thomas_os@shipmail.org> <20190903131504.18935-4-thomas_os@shipmail.org> <6d0fafcc-b596-481b-7b22-1f26f0c02c5c@intel.com> <7fa3b178-b9b4-2df9-1eee-54e24d48342e@intel.com> <94113acc-1f99-2386-1d42-4b9930b04f73@shipmail.org> <7eec2c11-d0d4-4c81-6ed2-d0932bf5af33@amd.com> <9ca29de8-0c9b-65b2-52e8-8668a1517ac5@shipmail.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <9ca29de8-0c9b-65b2-52e8-8668a1517ac5@shipmail.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: "Koenig, Christian" , Dave Hansen , Daniel Vetter Cc: dri-devel , "pv-drivers@vmware.com" , VMware Graphics , Linux Kernel Mailing List , "Lendacky, Thomas" , Thomas Hellstrom , Peter Zijlstra , Dave Hansen , Heiko Carstens , Christian Borntraeger , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , Thomas Gleixner List-Id: dri-devel@lists.freedesktop.org On 9/4/19 2:35 PM, Thomas Hellström (VMware) wrote: > >> >> I've already talked with Christoph that we probably want to switch TTM >> over to using that instead to also get rid of the ttm_io_prot() hack. > > OK, would that mean us ditching other memory modes completely? And > on-the-fly caching transitions? or is it just for the special case of > cached coherent memory? Do we need to cache the coherent kernel > mappings in TTM as well, for ttm_bo_kmap()? Reading this again, I wanted to point out that I'm not against this. Just curious. /Thomas