Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFE0CC433DB for ; Sun, 27 Dec 2020 12:26:57 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF02D207D1 for ; Sun, 27 Dec 2020 12:26:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF02D207D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=perex.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 399E11760; Sun, 27 Dec 2020 13:26:02 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 399E11760 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1609072012; bh=2lioiQr5+0c0aCDfLNTyTSt+fpBj7H0JDWChTDh9j4I=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ms4fTE1kZpXwluryecWWHNp2V/zEyC5Sgp+wDu1GIolS7SJrsOxmmY2jnjHi9FMPm hwUlsZClGN/fUeX/SKycfypTSF3SIfQ215rdA5w7b6DLnVKV/+BdHcuI2Pi2In/Hz6 U/U50Trqq7YpZk2hAmBgi4OrQxKjFCBuESq7m70w= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AD31AF8020C; Sun, 27 Dec 2020 13:26:01 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CFD38F8022B; Sun, 27 Dec 2020 13:25:59 +0100 (CET) Received: from mail1.perex.cz (mail1.perex.cz [77.48.224.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8C08CF800C8 for ; Sun, 27 Dec 2020 13:25:57 +0100 (CET) Received: from mail1.perex.cz (localhost [127.0.0.1]) by smtp1.perex.cz (Perex's E-mail Delivery System) with ESMTP id AA212A003F; Sun, 27 Dec 2020 13:25:55 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.perex.cz AA212A003F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=perex.cz; s=default; t=1609071955; bh=EmOt0A6PHLu32fXP2vwKVSM5PzkFHcqaQzCYF5FQwJo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ukuP/mt0l2FwRLFGE6FzwdntU2kkeaD0QmTmvF38Octi5vh/4g4rrlx7yYulejr/h 2YacJwwCCvoyMSBScXT/Fyr5007M/xNJuzyt0RyG+4YvczpqJNLZIck4tFhY/L73JF Q5ZkeuQacbZMA63j9PZyZKKW8EJ9MG6hIEzik8i8= Received: from p1gen2.localdomain (unknown [192.168.100.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: perex) by mail1.perex.cz (Perex's E-mail Delivery System) with ESMTPSA; Sun, 27 Dec 2020 13:25:52 +0100 (CET) Subject: Re: [PATCH 9/9] conf: remove dead code from get_hexachar To: Takashi Iwai , Alex Henrie References: <20201226213547.175071-1-alexhenrie24@gmail.com> <20201226213547.175071-10-alexhenrie24@gmail.com> From: Jaroslav Kysela Message-ID: Date: Sun, 27 Dec 2020 13:25:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Dne 27. 12. 20 v 9:37 Takashi Iwai napsal(a): > On Sat, 26 Dec 2020 22:35:47 +0100, > Alex Henrie wrote: >> >> Signed-off-by: Alex Henrie >> --- >> src/conf.c | 9 +-------- >> 1 file changed, 1 insertion(+), 8 deletions(-) >> >> diff --git a/src/conf.c b/src/conf.c >> index 44d1bfde..970ad643 100644 >> --- a/src/conf.c >> +++ b/src/conf.c >> @@ -877,16 +877,9 @@ static int get_nonwhite(input_t *input) >> >> static inline int get_hexachar(input_t *input) >> { >> - int c, num = 0; >> - >> + int c; >> c = get_char(input); >> - if (c >= '0' && c <= '9') num |= (c - '0') << 4; >> - else if (c >= 'a' && c <= 'f') num |= (c - 'a') << 4; >> - else if (c >= 'A' && c <= 'F') num |= (c - 'A') << 4; >> c = get_char(input); >> - if (c >= '0' && c <= '9') num |= (c - '0') << 0; >> - else if (c >= 'a' && c <= 'f') num |= (c - 'a') << 0; >> - else if (c >= 'A' && c <= 'F') num |= (c - 'A') << 0; >> return c; > > The current code is obviously wrong and the suggested fix goes even to > a wronger direction :) The function should return num instead. > > I wonder how this did't hit any problem, so far. Maybe 0x prefix was > rarely used, fortunately. It's a bit recent code. I fixed the return value now. It's for \xFF not for 0xFF prefix. Thank you for your investigation, Alex. Jaroslav -- Jaroslav Kysela Linux Sound Maintainer; ALSA Project; Red Hat, Inc.