Message-ID: <e1ab1e44-e5ed-4a6a-821f-859bf54816fb@gmail.com>
Date: Tue, 27 Aug 2024 20:37:26 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] staging: rtl8192e: Fix alignment parenthesis
To: Nilo Alexandre <n1lux.comp@gmail.com>, gregkh@linuxfoundation.org,
 linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
 ~lkcamp/patches@lists.sr.ht
References: <20240827162910.15459-1-n1lux.comp@gmail.com>
Content-Language: en-US
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
In-Reply-To: <20240827162910.15459-1-n1lux.comp@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 8/27/24 18:29, Nilo Alexandre wrote:
> Fix alignment parenthesis in _rtl92e_read_eeprom_info
> 
> CHECK: Alignment should match open parenthesis
> 
> ---
> Changes in v2:
>      - Using tabs instead of spaces
> 
> Signed-off-by: Nilo Alexandre <n1lux.comp@gmail.com>
> ---
>   drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index b767dc00100aa..2d17d8e8898e7 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -322,7 +322,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
>   		if (priv->epromtype == EEPROM_93C46) {
>   			if (!priv->autoload_fail_flag) {
>   				usValue = rtl92e_eeprom_read(dev,
> -					                     EEPROM_TxPwDiff_CrystalCap >> 1);
> +								EEPROM_TxPwDiff_CrystalCap >> 1);
>   				priv->eeprom_ant_pwr_diff = usValue & 0x0fff;
>   				priv->eeprom_crystal_cap = (usValue & 0xf000)
>   							 >> 12;

Hi Nilo,

please make your "Subject" line more unique. Consider that we may end up 
with having dozen of commits like yours, all of them referring to 
different removals and all without the necessary information to tell 
what they differ in (except the driver/subsystem). So it would help if 
you add the changed file or function to make it more unique.

Please answer the why in the description and not so much what you did. 
Why do we need an empty line? Please use a dot to end the sentences.
I propose:
Align parenthesis to improve readability.

You can mention the tool which gave you the hint but you do not have to.

Thanks for your support.

Bye Philipp