From: "flichtenheld (Code Review)" Date: Wed, 8 Jan 2025 14:56:05 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., samuli@...515..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="GJ84D6tF/cI="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Add lwip support to t_server_null List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mattock Cc: plaisthos , openvpn-devel --GJ84D6tF/cI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: mattock, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/811?usp=3Demail ) Change subject: Add lwip support to t_server_null ...................................................................... Patch Set 4: Code-Review-2 (3 comments) File doc/t_server_null.rst: http://gerrit.openvpn.net/c/openvpn/+/811/comment/cfcc4062_edab2a5a : PS4, Line 129: Note that all ovpnlwip test names need to include a "_lwip" = suffix: without if "without it" File tests/lwip_client_up.sh: http://gerrit.openvpn.net/c/openvpn/+/811/comment/a46c4c72_23d0241a : PS4, Line 4: if ! grep "$ifconfig_local" ./$test_name.ips; then Should use grep -q File tests/t_server_null_default.rc: http://gerrit.openvpn.net/c/openvpn/+/811/comment/d4f73210_6228eae2 : PS4, Line 22: LWIPOVPN_PATH=3D"${LWIPOVPN_PATH:-lwipovpn}" This is extremely misleading. This seems to indicate that you can override = `LWIPOVPN_PATH`. However you can definitely not do so in t_server_null.rc s= ince that is loaded after t_server_null_default.rc and it is too late. Even= more when you set LWIPOVPN_PATH in t_server_null.rc it actually allows to = start the lwip tests since the test whether lwipovpn is available does use = the updated LWIPOVPN_PATH. We either need to clearly define that LWIPOVPN_PATH can not be overridden o= r we need to fix it so that it can. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/811?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca6b8c029f0d250 Gerrit-Change-Number: 811 Gerrit-PatchSet: 4 Gerrit-Owner: mattock Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: mattock Gerrit-Comment-Date: Wed, 08 Jan 2025 14:56:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --GJ84D6tF/cI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: mattock, plaisthos.

Patch set 4:Code-Review -2=

Vi= ew Change

3 comments:

  • File doc/t_server_null.rst:

    =
    • Patch Set #4, Line 129= : Note that all ovpnlwi= p test names need to include a "_lwip" suffix: without if<= /p>

      "without= it"

  • File te= sts/lwip_client_up.sh:

    • <= a href=3D"http://gerrit.openvpn.net/c/openvpn/+/811/comment/a46c4c72_23d024= 1a">Patch Set #4, Line 4: if ! grep "$ifconfig_local" ./$test_name.ips; then

      <= p style=3D"white-space: pre-wrap; word-wrap: break-word;">Should use grep -= q

  • File tests/t_se= rver_null_default.rc:

    • Patch Set #4, Line 22: LWIPOVPN_PATH=3D"${LWIPOVPN_PATH:-lwipovpn}"

      This is extremely misle= ading. This seems to indicate that you can override `LWIPOVPN_PATH`. Howeve= r you can definitely not do so in t_server_null.rc since that is loaded aft= er t_server_null_default.rc and it is too late. Even more when you set LWIP= OVPN_PATH in t_server_null.rc it actually allows to start the lwip tests si= nce the test whether lwipovpn is available does use the updated LWIPOVPN_PA= TH.

      We either= need to clearly define that LWIPOVPN_PATH can not be overridden or we need= to fix it so that it can.

To view, visit change 811. = To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca= 6b8c029f0d250
Gerrit-Change-Number: 811
Gerrit-PatchSet: 4
Gerrit-Owner: mattock <samuli@...515...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: mattock <samuli@...515...= >
Gerrit-Comment-Date: Wed, 08 Jan 2025 14:56:05= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--GJ84D6tF/cI=--