Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ADCC4211EB815 for ; Mon, 6 May 2019 15:14:04 -0700 (PDT) From: "Verma, Vishal L" Subject: Re: [ndctl PATCH 0/8] daxctl: add a new reconfigure-device command Date: Mon, 6 May 2019 22:14:02 +0000 Message-ID: References: <20190503213231.12280-1-vishal.l.verma@intel.com> <12edf619-be22-8ae9-77c0-8a81cb353a87@intel.com> In-Reply-To: <12edf619-be22-8ae9-77c0-8a81cb353a87@intel.com> Content-Language: en-US Content-ID: MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "linux-nvdimm@lists.01.org" , "Hansen, Dave" Cc: "dave.hansen@linux.intel.com" , "pasha.tatashin@soleen.com" List-ID: On Mon, 2019-05-06 at 14:50 -0700, Dave Hansen wrote: > This all looks quite nice to me. Thanks, Vishal! > > One minor nit: for those of us new to daxctl and friends, they can be > a > bit hard to get started with. Could you maybe add a few example > invocations to the Documentation, or even this cover letter to help us > newbies get started? Yes, good idea, I'll add an examples section to the Documentation page (other commands do this, and this should too), and add those to the cover letter as well for v2. Thanks! -Vishal _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm