From: "cron2 (Code Review)" Date: Sun, 3 Aug 2025 15:16:58 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., lstipakov@...277... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="5ww1Ny67Iw4="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Log setting DNS via NRPT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: stipa Cc: plaisthos , flichtenheld , openvpn-devel --5ww1Ny67Iw4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/11= 26?usp=3Demail ) Change subject: Log setting DNS via NRPT ...................................................................... Log setting DNS via NRPT Unlike other ways of setting DNS, we don't log anything when we use NRPT. Since dco-win/--dns is the recommended configuration and it uses NRPT to set DNS, let's log it. Change-Id: Ib2f30fe69cb676e347e4d59cd2db68db7568ba5b Signed-off-by: Lev Stipakov Acked-by: Gert Doering Message-Id: <20250803144950.21034-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32= 480.html Signed-off-by: Gert Doering --- M src/openvpn/dns.c 1 file changed, 5 insertions(+), 0 deletions(-) diff --git a/src/openvpn/dns.c b/src/openvpn/dns.c index 2952a8a..22f4cec 100644 --- a/src/openvpn/dns.c +++ b/src/openvpn/dns.c @@ -460,6 +460,11 @@ make_domain_list("dns search domains", search_domains, false, nrpt.search_domains, sizeof(nrpt.search_domains)); + msg(D_LOW, "%s NRPT DNS%s%s on '%s' (if_index =3D %d) using service", + (add ? "Setting" : "Deleting"), nrpt.resolve_domains[0] !=3D 0 ? "= , resolve domains" : "", + nrpt.search_domains[0] !=3D 0 ? ", search domains" : "", + nrpt.iface.name, nrpt.iface.index); + send_msg_iservice(o->msg_channel, &nrpt, sizeof(nrpt), &ack, "DNS"); } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1126?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib2f30fe69cb676e347e4d59cd2db68db7568ba5b Gerrit-Change-Number: 1126 Gerrit-PatchSet: 2 Gerrit-Owner: stipa Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: merged --5ww1Ny67Iw4= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 submitted this change.

View Change

Log setting DNS via NRPT

Unlike other = ways of setting DNS, we don't log anything
when we use NRPT. Since d= co-win/--dns is the recommended
configuration and it uses NRPT to set DN= S, let's log it.

Change-Id: Ib2f30fe69cb676e347e4d59cd2db68db756= 8ba5b
Signed-off-by: Lev Stipakov <lev@...515...>
Acked-by: Ger= t Doering <gert@...1296...>
Message-Id: <20250803144950.21034-1= -gert@...1296...>
URL: https://www.mail-archive.com/openvpn-devel@...1484...= ts.sourceforge.net/msg32480.html
Signed-off-by: Gert Doering <gert@...1186...= .1296...>
---
M src/openvpn/dns.c
1 file changed, 5 insertions(= +), 0 deletions(-)

diff --git a/src/openvpn/dns.c b/src/openvpn/dns.c
index= 2952a8a..22f4cec 100644
--- a/src/openvpn/dns.c
= +++ b/src/openvpn/dns.c
@@ -460,6 +460,11 @@ make_domain_list("dns search domains", search_domain= s, false,
nrpt.search_domains, sizeof= (nrpt.search_domains));

+ msg(D_LOW, "%s NRPT DNS%s%s on '%s' = (if_index =3D %d) using service",
+ (add ? "Setting" : "Deleting"= ;), nrpt.resolve_domains[0] !=3D 0 ? ", resolve domains" : "= ",
+ nrpt= .search_domains[0] !=3D 0 ? ", search domains" : "",
+ nrpt.iface.nam= e, nrpt.iface.index);
+
send_msg_iservice(o->msg_channel, &nrpt, siz= eof(nrpt), &ack, "DNS");
}
=

To view, visit change 1126. To unsubscribe= , or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib2f30fe69cb676e347e4d59cd2d= b68db7568ba5b
Gerrit-Change-Number: 1126
Gerrit-PatchSet: 2
Gerrit-Owner: stipa <lstipakov@...277...>= ;
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: merged
--5ww1Ny67Iw4=--