From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Subject: Re: [PATCH v2 0/4] Remove 32-bit Xen PV guest support Date: Thu, 2 Jul 2020 17:45:23 +0200 Message-ID: References: <20200701110650.16172-1-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" To: Brian Gerst Cc: Stefano Stabellini , "VMware, Inc." , the arch/x86 maintainers , Linux Kernel Mailing List , Linux Virtualization , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , xen-devel , Thomas Gleixner , Boris Ostrovsky List-Id: virtualization@lists.linuxfoundation.org On 02.07.20 16:48, Brian Gerst wrote: > On Wed, Jul 1, 2020 at 7:07 AM Juergen Gross wrote: >> >> The long term plan has been to replace Xen PV guests by PVH. The first >> victim of that plan are now 32-bit PV guests, as those are used only >> rather seldom these days. Xen on x86 requires 64-bit support and with >> Grub2 now supporting PVH officially since version 2.04 there is no >> need to keep 32-bit PV guest support alive in the Linux kernel. >> Additionally Meltdown mitigation is not available in the kernel running >> as 32-bit PV guest, so dropping this mode makes sense from security >> point of view, too. > > One thing that you missed is removing VDSO_NOTE_NONEGSEG_BIT from > vdso32/note.S. With that removed there is no difference from the > 64-bit version. Oh, this means we can probably remove arch/x86/xen/vdso.h completely. > > Otherwise this series looks good to me. Thanks, Juergen