Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6609C2D0EA for ; Wed, 8 Apr 2020 12:54:59 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 789532072F for ; Wed, 8 Apr 2020 12:54:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 789532072F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jMAE7-0003m6-Jq; Wed, 08 Apr 2020 12:54:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jMAE6-0003m1-8i for xen-devel@lists.xenproject.org; Wed, 08 Apr 2020 12:54:42 +0000 X-Inumbo-ID: 1c7c2e72-7998-11ea-81e1-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1c7c2e72-7998-11ea-81e1-12813bfff9fa; Wed, 08 Apr 2020 12:54:41 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 3F373ACB8; Wed, 8 Apr 2020 12:54:39 +0000 (UTC) Subject: Re: [XEN PATCH v4 14/18] xen,symbols: rework file symbols selection To: Anthony PERARD References: <20200331103102.1105674-1-anthony.perard@citrix.com> <20200331103102.1105674-15-anthony.perard@citrix.com> From: Jan Beulich Message-ID: Date: Wed, 8 Apr 2020 14:54:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200331103102.1105674-15-anthony.perard@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 31.03.2020 12:30, Anthony PERARD wrote: > We want to use the same rune to build mm/*/guest_*.o as the one use to > build every other *.o object. The consequence it that file symbols that > the program ./symbols prefer changes with CONFIG_ENFORCE_UNIQUE_SYMBOLS=y. > > (1) Currently we have those two file symbols: > guest_walk.c > guest_walk_2.o > (2) with CONFIG_ENFORCE_UNIQUE_SYMBOLS used on guest_walk.c, we will have: > arch/x86/mm/guest_walk.c > guest_walk_2.o > > The order in which those symbols are present may be different. > > Currently, in case (1) ./symbols chooses the *.o symbol (object file > name). But in case (2), may choose the *.c symbol (source file name with > path component) if it is first > > We want to have ./symbols choose the object file name symbol in both > cases. I guess the reason for wanting this is somehow connected to the statement at the beginning of the description, but I can't seem to be able to make the connection. > So this patch changes that ./symbols prefer the "object file > name" symbol over the "source file name with path component" symbols. > > The new intended order of preference is: > - first object file name symbol > - first source file name with path components symbol > - last source file name without any path component symbol Isn't this going to lead to ambiguities again when CONFIG_ENFORCE_UNIQUE_SYMBOLS? Several object files (in different dirs) are named the same, after all. Static symbols with the same name in such objects would hence resolve to the same kallsyms name. Jan