From: "its_Giaan (Code Review)"
Date: Mon, 26 Feb 2024 18:29:07 +0000
In-Reply-To:
References:
Reply-To: gianmarco@...2726..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="WvBmSeF4Q5Q="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: Http-proxy: fix bug
preventing proxy credentials caching
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: flichtenheld , plaisthos , openvpn-devel
--WvBmSeF4Q5Q=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/523?usp=3Demail )
Change subject: Http-proxy: fix bug preventing proxy credentials caching
......................................................................
Patch Set 2:
(4 comments)
File src/openvpn/options.c:
http://gerrit.openvpn.net/c/openvpn/+/523/comment/2fba2993_384c818e :
PS1, Line 1861: SHOW_BOOL(ce.http_proxy_options->nocache);
> This belongs into show_connection_entry like the other o->ce options
Acknowledged
File src/openvpn/proxy.c:
http://gerrit.openvpn.net/c/openvpn/+/523/comment/0fc15362_dde1eff3 :
PS1, Line 275: if (!static_proxy_user_pass.defined || (is_first_time &&=
!p->options.nocache) )
> This condition feels wrong to me. [=E2=80=A6]
Acknowledged
http://gerrit.openvpn.net/c/openvpn/+/523/comment/eda88547_5919fdf8 :
PS1, Line 278: p->options.auth_file,
> I think you messed up a rebase on top of a634cc5eccd55f1d14197da7376bb819=
bdf72cb6 here. [=E2=80=A6]
Acknowledged
http://gerrit.openvpn.net/c/openvpn/+/523/comment/607aa2a9_08aea895 :
PS1, Line 546: get_user_pass_http(p);
> So previously this forced a reset of the credentials. This you removed. [=
=E2=80=A6]
Acknowledged
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/523?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a
Gerrit-Change-Number: 523
Gerrit-PatchSet: 2
Gerrit-Owner: its_Giaan
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Mon, 26 Feb 2024 18:29:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld
Gerrit-MessageType: comment
--WvBmSeF4Q5Q=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
View C=
hange
4 comments:
Acknowledged
File src/openvpn/proxy.c:
Patch Set #1, Line 275:=
if (!static_proxy_user=
_pass.defined || (is_first_time && !p->options.nocache) )=
This condition feels wrong to me. [=E2=80=A6]
<=
/p>Acknowledged<=
/p>
Patch Set #1, Line 278: p->options.auth_file,
=
I think you messed up a rebase on top of a634cc5eccd55f1d14197d=
a7376bb819bdf72cb6 here. [=E2=80=A6]
Acknowledged
Patch Se=
t #1, Line 546: =
get_user_pass_http(p);
So previously this forced a r=
eset of the credentials. This you removed. [=E2=80=A6]
Acknowledged
To view, visit change 523. To unsubscribe, or for help writin=
g mail filters, visit settin=
gs.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279=
fb71c01a1a78a
Gerrit-Change-Number: 523
Gerrit-PatchSet: 2
Gerrit-Owner: its_Giaan <gianmarco@...2786...=
..>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Mon, 26 Feb 2024 18:29:07=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Gerrit-MessageType: comment
--WvBmSeF4Q5Q=--