Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E702EC43381 for ; Sat, 30 Mar 2019 16:13:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B5A012184D for ; Sat, 30 Mar 2019 16:13:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tU1uvK8p" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730985AbfC3QNd (ORCPT ); Sat, 30 Mar 2019 12:13:33 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:39983 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730824AbfC3QNd (ORCPT ); Sat, 30 Mar 2019 12:13:33 -0400 Received: by mail-wr1-f65.google.com with SMTP id h4so6281857wre.7 for ; Sat, 30 Mar 2019 09:13:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=nocZLBMvxy0FJxeC3JNNlqdNutWGNxe5PyyrsaY3zuo=; b=tU1uvK8pUXkqU53+JBGSJSdG8GJnUpfNO+6k6E8rBqz99oC5327pBB3ll/gaY07/KH TDgGGHynBuFYuf/lUL8dMKcelTkK+O5EKNxc3JeT0JtI5FsOrxIiTVhw4qiWvbmTpZ/Y xfIetVTTSDcd1xXc9M/E3y7OtIlliwbP3OSWew0DFeHfbildyu7+saIe13KLzjR5JfDi EyL8VztEw7d3njrjDe14+4KdzfP1y3aEwpQRuOJzsfwePo9VBNI6/ZWBZom8l5aFAS92 r96QhL1985FAXq4aaF+yisR16q5IAoBYihuhVEvePPVTWK7UWC7aEiCfi4wIo8RxtJJJ Yolg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=nocZLBMvxy0FJxeC3JNNlqdNutWGNxe5PyyrsaY3zuo=; b=V34vz7kT0FXHHNYwrVRRlV9moVR0saCV3klnK2B4bLte+HQNlP/IJj5liGdKSeB13k wDIyIu54VqUThMyVJ8fgv1ls0B819+dx+6r3ArjPtyJRlABYLPONG/K2hZKMrkbN2kbN aR4I8maCtWM0U60KvL4E9P0n1SO6WkduVV/cLuUBP8kkrg4fW9AJN1CIi+DbJFl1Z5Zg 0K4oyb/9VsyPOTCE+lIzClvAEtGsslCB7Ta3gaq17JgdQ3jRGR6JjxJDUKGE7l2K1CMZ k2Td22lLeiauvXIjOap477+Wi2ZxJLJBlMh5kgKbxu6Ych3geWZXGH7Oz4oIaTSyFco7 FwGA== X-Gm-Message-State: APjAAAXUX8WRQVYMI5i4DlzGtpbOtmf/bB3HavW5jeXoAkpmSGuQ9sbM TSFHSJiK4/KCBFnPZNWDjpl5HLH2 X-Google-Smtp-Source: APXvYqzCnZjnNiWWD3bn4ugqZ4yhxHbU+1s56x7SRXdCx0LD2QrFMssq3FlgJB/Dny4YaQOCLMmMWQ== X-Received: by 2002:a05:6000:124a:: with SMTP id j10mr36560364wrx.24.1553962411320; Sat, 30 Mar 2019 09:13:31 -0700 (PDT) Received: from ?IPv6:2003:ea:8be1:dd00:7ccd:5549:2050:93de? (p200300EA8BE1DD007CCD5549205093DE.dip0.t-ipconnect.de. [2003:ea:8be1:dd00:7ccd:5549:2050:93de]) by smtp.googlemail.com with ESMTPSA id v14sm4570024wrr.20.2019.03.30.09.13.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 30 Mar 2019 09:13:30 -0700 (PDT) To: David Miller , Realtek linux nic maintainers Cc: "netdev@vger.kernel.org" , Mike Crowe From: Heiner Kallweit Subject: [PATCH net] r8169: disable default rx interrupt coalescing on RTL8168 Message-ID: Date: Sat, 30 Mar 2019 17:13:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org It was reported that re-introducing ASPM, in combination with RX interrupt coalescing, results in significantly increased packet latency, see [0]. Disabling ASPM or RX interrupt coalescing fixes the issue. Therefore change the driver's default to disable RX interrupt coalescing. Users still have the option to enable RX coalescing via ethtool. [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=925496 Fixes: a99790bf5c7f ("r8169: Reinstate ASPM Support") Reported-by: Mike Crowe Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index c9ee1c8eb..8a8a4f70d 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -5460,7 +5460,7 @@ static void rtl_hw_start_8168(struct rtl8169_private *tp) tp->cp_cmd |= PktCntrDisable | INTT_1; RTL_W16(tp, CPlusCmd, tp->cp_cmd); - RTL_W16(tp, IntrMitigate, 0x5151); + RTL_W16(tp, IntrMitigate, 0x5100); /* Work around for RxFIFO overflow. */ if (tp->mac_version == RTL_GIGA_MAC_VER_11) { -- 2.21.0