From: Jiangyifei Date: Fri, 10 Dec 2021 10:03:40 +0000 Subject: [PATCH v1 12/12] target/riscv: Support virtual time context synchronization In-Reply-To: References: <20211120074644.729-1-jiangyifei@huawei.com> <20211120074644.729-13-jiangyifei@huawei.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit > -----Original Message----- > From: Richard Henderson [mailto:richard.henderson at linaro.org] > Sent: Sunday, November 21, 2021 6:35 AM > To: Jiangyifei ; qemu-devel at nongnu.org; > qemu-riscv at nongnu.org > Cc: bin.meng at windriver.com; limingwang (A) ; > kvm at vger.kernel.org; libvir-list at redhat.com; anup.patel at wdc.com; wanbo (G) > ; Alistair.Francis at wdc.com; > kvm-riscv at lists.infradead.org; Wanghaibin (D) > ; palmer at dabbelt.com; Fanliang (EulerOS) > ; Wubin (H) > Subject: Re: [PATCH v1 12/12] target/riscv: Support virtual time context > synchronization > > On 11/20/21 8:46 AM, Yifei Jiang wrote: > > const VMStateDescription vmstate_riscv_cpu = { > > .name = "cpu", > > .version_id = 3, > > .minimum_version_id = 3, > > + .post_load = cpu_post_load, > > .fields = (VMStateField[]) { > > VMSTATE_UINTTL_ARRAY(env.gpr, RISCVCPU, 32), > > VMSTATE_UINT64_ARRAY(env.fpr, RISCVCPU, 32), @@ -211,6 > > +221,10 @@ const VMStateDescription vmstate_riscv_cpu = { > > VMSTATE_UINT64(env.mtohost, RISCVCPU), > > VMSTATE_UINT64(env.timecmp, RISCVCPU), > > > > + VMSTATE_UINT64(env.kvm_timer_time, RISCVCPU), > > + VMSTATE_UINT64(env.kvm_timer_compare, RISCVCPU), > > + VMSTATE_UINT64(env.kvm_timer_state, RISCVCPU), > > + > > VMSTATE_END_OF_LIST() > > }, > > Can't alter VMStateDescription.fields without bumping version. > > If this is really kvm-only state, consider placing it into a subsection. But I > worry about kvm-only state because ideally we'd be able to migrate between > tcg and kvm (if only for debugging). > > > r~ Thanks, I will update the version in the next series and place it into a subsection. Yifei