Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1m3jt6-00070i-C2 for mharc-grub-devel@gnu.org; Wed, 14 Jul 2021 14:45:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41606) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3jt5-00070Z-76 for grub-devel@gnu.org; Wed, 14 Jul 2021 14:45:39 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:54598) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3jt2-0002FJ-H2 for grub-devel@gnu.org; Wed, 14 Jul 2021 14:45:38 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16EIXfCp135564; Wed, 14 Jul 2021 14:45:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=/MmeapPVGPrPj76iie5/SAtDYOoedIK6ohss1QMpEzM=; b=TjjpaDsVpjd1hW9e3Bgdr525a+PNhQhTcuRDstAEDxhMSYmgn8HTeI3BcjTrEVoOZPWo testW006qHdwF45bMYeEqNhPcKYLQkHTXRNr+cLdjcx5wnhC2/2cljJBMAJAmFF8PJ+l cv9tlH1Wi/1orj/zafG0yAds3gkuuFHHE2huMTzpc0gfvSQ2UH8718K/ak+RotRIi1nR d1GB/3cd8qeRbP1W8SV8EtlRSb5Ia2dzCw68K2uOeAIYAXDWUywl2YOoY3G9iwbjhWjI s/IZsmYJImyBMWwp90WIgUbnO3ntXGmZl6af7lRkkKP+6ZIKDXidZm+Id2I6/klWU0EE OA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 39s8vgvcge-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Jul 2021 14:45:29 -0400 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 16EIY7DD140494; Wed, 14 Jul 2021 14:45:29 -0400 Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com with ESMTP id 39s8vgvcg4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Jul 2021 14:45:29 -0400 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 16EIgRa7018428; Wed, 14 Jul 2021 18:45:28 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma02dal.us.ibm.com with ESMTP id 39qt3cn9sg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Jul 2021 18:45:22 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 16EIjLQJ26607958 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Jul 2021 18:45:21 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7594D112071; Wed, 14 Jul 2021 18:45:21 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6334F112065; Wed, 14 Jul 2021 18:45:21 +0000 (GMT) Received: from [9.47.158.152] (unknown [9.47.158.152]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 14 Jul 2021 18:45:21 +0000 (GMT) Subject: Re: [PATCH] ibmvtpm: Add support for trusted boot using a vTPM 2.0 To: Daniel Kiper , Stefan Berger Cc: grub-devel@gnu.org, rashmica.g@gmail.com, alastair@d-silva.org, nayna@linux.ibm.com, dja@axtens.net, eric.snowberg@oracle.com References: <20210712190219.208790-1-stefanb@linux.vnet.ibm.com> <20210714161657.g2za2i3oyrwgekae@tomti.i.net-space.pl> From: Stefan Berger Message-ID: Date: Wed, 14 Jul 2021 14:45:21 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210714161657.g2za2i3oyrwgekae@tomti.i.net-space.pl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: zCA2knHZbnPNFHHfzofOKnWTInKzoK4B X-Proofpoint-GUID: BV_KOTYFK7fVWm5ACQhncWmmErTHp6R6 Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-14_10:2021-07-14, 2021-07-14 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 mlxscore=0 phishscore=0 bulkscore=0 suspectscore=0 impostorscore=0 mlxlogscore=999 clxscore=1011 spamscore=0 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107140110 Received-SPF: pass client-ip=148.163.156.1; envelope-from=stefanb@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2021 18:45:39 -0000 On 7/14/21 12:16 PM, Daniel Kiper wrote: > CC-ing folks CC-ed in Daniel's patch series and Eric. > > On Mon, Jul 12, 2021 at 03:02:19PM -0400, Stefan Berger wrote: >> From: Stefan Berger >> >> Add support for trusted boot using a vTPM 2.0 on the IBM ieee1275 >> platform. With this patch grub now measures text and binary data >> into the TPM's PCRs 8 and 9 in the same way as the x86_64 platform >> does. >> >> This patch requires Daniel Axtens's patches for claiming more memory. > Would not be it simpler if you take out the memory mgmt changes patches > from Daniel's patch series? You mean reposting this series with his 3 patches upfront? I can certainly do that. > > Daniel, are you OK with it? > > Additionally, please CC Eric when you post IEEE1275 patches next time. Will do. > >> Signed-off-by: Stefan Berger >> --- >> grub-core/Makefile.core.def | 8 ++ >> grub-core/commands/ieee1275/ibmvtpm.c | 118 ++++++++++++++++++++++++++ >> grub-core/kern/ieee1275/ibmvtpm.c | 62 ++++++++++++++ >> include/grub/ieee1275/ibmvtpm.h | 32 +++++++ >> 4 files changed, 220 insertions(+) >> create mode 100644 grub-core/commands/ieee1275/ibmvtpm.c >> create mode 100644 grub-core/kern/ieee1275/ibmvtpm.c >> create mode 100644 include/grub/ieee1275/ibmvtpm.h >> >> diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def >> index 3f3459b2c..e2a64f8ff 100644 >> --- a/grub-core/Makefile.core.def >> +++ b/grub-core/Makefile.core.def >> @@ -1166,6 +1166,14 @@ module = { >> enable = powerpc_ieee1275; >> }; >> >> +module = { >> + name = tpm; >> + common = commands/tpm.c; >> + common = kern/ieee1275/ibmvtpm.c; >> + ieee1275 = commands/ieee1275/ibmvtpm.c; > s/ieee1275/common/? > >> + enable = powerpc_ieee1275; >> +}; >> + >> module = { >> name = terminal; >> common = commands/terminal.c; >> diff --git a/grub-core/commands/ieee1275/ibmvtpm.c b/grub-core/commands/ieee1275/ibmvtpm.c >> new file mode 100644 >> index 000000000..9b06c76d9 >> --- /dev/null >> +++ b/grub-core/commands/ieee1275/ibmvtpm.c >> @@ -0,0 +1,118 @@ >> +/* >> + * GRUB -- GRand Unified Bootloader >> + * Copyright (C) 2021 IBM Corporation > Copyright (C) 2021 Free Software Foundation, Inc. > > Or both if you strongly need IBM... > >> + * GRUB is free software: you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation, either version 3 of the License, or >> + * (at your option) any later version. >> + * >> + * GRUB is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * You should have received a copy of the GNU General Public License >> + * along with GRUB. If not, see . >> + * >> + * IBM vTPM support code. >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +static grub_ieee1275_ihandle_t grub_tpm_ihandle; >> +static grub_uint8_t grub_tpm_version; >> + >> +static void grub_ieee1275_tpm_init (grub_ieee1275_ihandle_t *tpm_ihandle) > You can drop from static functions, variables, etc. names "grub_" prefix. > >> +{ >> + static int init_called = 0; >> + >> + if (!init_called) { >> + init_called = 1; >> + grub_ieee1275_open ("/vdevice/vtpm", &grub_tpm_ihandle); >> + } > Incorrect formatting. It should be > > if (!init_called) > { > init_called = 1; > grub_ieee1275_open ("/vdevice/vtpm", &grub_tpm_ihandle); > } > > You can always refer to grub-core/kern/efi/sb.c to get formatting > examples for various pieces of the GRUB code. > > Please fix similar issues below too. > >> + *tpm_ihandle = grub_tpm_ihandle; >> +} >> + >> +static grub_err_t >> +grub_tpm_get_tpm_version (grub_uint8_t *protocol_version) >> +{ >> + static int version_probed = 0; >> + grub_ieee1275_phandle_t vtpm; >> + char buffer[20]; >> + grub_ssize_t buffer_size; >> + >> + if (!version_probed) { >> + version_probed = 1; >> + if (!grub_ieee1275_finddevice ("/vdevice/vtpm", &vtpm) && >> + !grub_ieee1275_get_property (vtpm, "compatible", buffer, >> + sizeof buffer, &buffer_size) && >> + !grub_strcmp (buffer, "IBM,vtpm20")) { >> + grub_tpm_version = 2; >> + } >> + } >> + *protocol_version = grub_tpm_version; >> + >> + return 0; > You ignore this value later. > > I think the prototype of this function should be following: > grub_uint8_t get_tpm_version (void) > > Which means you should return the TPM version. > >> +} >> + >> +static grub_int8_t > static grub_err_t > >> +grub_tpm_handle_find (grub_ieee1275_ihandle_t *tpm_handle, >> + grub_uint8_t *protocol_version) >> +{ >> + grub_ieee1275_tpm_init (tpm_handle); >> + if (*tpm_handle == NULL) >> + return 0; > return GRUB_ERR_UNKNOWN_DEVICE; > >> + grub_tpm_get_tpm_version (protocol_version); >> + >> + return 1; > return GRUB_ERR_NONE; > >> +} >> + >> +static grub_err_t >> +grub_tpm2_log_event (grub_ieee1275_ihandle_t tpm_handle, unsigned char *buf, >> + grub_size_t size, grub_uint8_t pcr, >> + const char *description) >> +{ >> + static int error_displayed; >> + bool succ; > s/bool/grub_err_t/ > >> + >> + succ = grub_ieee1275_ibmvtpm_2hash_ext_log (tpm_handle, >> + pcr, EV_IPL, >> + description, >> + grub_strlen(description) + 1, >> + buf, size); >> + if (!succ && !error_displayed) { >> + error_displayed = 1; >> + grub_printf("2HASH-EXT-LOG failed: Firmware is likely too old.\n"); > s/grub_printf/grub_error/ > >> + } >> + >> + return 0; >> +} >> + >> +grub_err_t >> +grub_tpm_measure (unsigned char *buf, grub_size_t size, grub_uint8_t pcr, >> + const char *description) >> +{ >> + grub_ieee1275_ihandle_t tpm_handle; >> + grub_uint8_t protocol_version = 0; > It seems to me that you have the same information in the grub_tpm_version > global variable. So, I think you should you use it and drop all instances > of protocol_version. > >> + /* Absence of a TPM isn't a failure. */ >> + if (!grub_tpm_handle_find (&tpm_handle, &protocol_version)) >> + return 0; >> + >> + grub_dprintf ("tpm", "log_event, pcr = %d, size = 0x%" PRIxGRUB_SIZE ", %s\n", >> + pcr, size, description); >> + >> + if (protocol_version == 2) >> + return grub_tpm2_log_event (tpm_handle, buf, size, pcr, description); >> + >> + return 0; >> +} >> diff --git a/grub-core/kern/ieee1275/ibmvtpm.c b/grub-core/kern/ieee1275/ibmvtpm.c >> new file mode 100644 >> index 000000000..525a792b4 >> --- /dev/null >> +++ b/grub-core/kern/ieee1275/ibmvtpm.c >> @@ -0,0 +1,62 @@ >> +/* ibmvtpm.c - Client interface to access the IBM vTPM */ >> +/* >> + * GRUB -- GRand Unified Bootloader >> + * Copyright (C) 2021 IBM Corporation >> + * >> + * GRUB is free software: you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation, either version 3 of the License, or >> + * (at your option) any later version. >> + * >> + * GRUB is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * You should have received a copy of the GNU General Public License >> + * along with GRUB. If not, see . >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> + >> +bool > s/bool/grub_err_t/ > >> +grub_ieee1275_ibmvtpm_2hash_ext_log (grub_uint32_t ihandle, >> + grub_uint8_t pcrindex, >> + grub_uint32_t eventtype, >> + const char *description, >> + grub_size_t description_size, >> + void *buf, grub_size_t size) > I cannot see any reason to make this function part of the GRUB kernel. > I think it should be in grub-core/commands/ieee1275/ibmvtpm.c. > >> +{ >> + struct tpm_2hash_ext_log > Please define this struct before the function, somewhere after includes. > >> + { >> + struct grub_ieee1275_common_hdr common; >> + grub_ieee1275_cell_t method; >> + grub_ieee1275_cell_t ihandle; >> + grub_ieee1275_cell_t size; >> + void *buf; >> + grub_ieee1275_cell_t description_size; >> + const char *description; >> + grub_ieee1275_cell_t eventtype; >> + grub_ieee1275_cell_t pcrindex; >> + grub_ieee1275_cell_t catch_result; >> + grub_ieee1275_cell_t rc; >> + } > GRUB_PACKED? > >> + args; >> + >> + INIT_IEEE1275_COMMON (&args.common, "call-method", 8, 2); >> + args.method = (grub_ieee1275_cell_t) "2hash-ext-log"; >> + args.ihandle = ihandle; >> + args.pcrindex = pcrindex; >> + args.eventtype = eventtype; >> + args.description = description; >> + args.description_size = description_size; >> + args.buf = buf; >> + args.size = (grub_ieee1275_cell_t) size; >> + >> + if (IEEE1275_CALL_ENTRY_FN (&args) == -1) >> + return false; >> + return !!args.rc; >> +} > Daniel