From: "cron2 (Code Review)" Date: Thu, 8 Feb 2024 08:31:15 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="pfAzTXqaZZc="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: test_user_pass: add basic tests for static/dynamic challenges List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --pfAzTXqaZZc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#9) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/475?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: test_user_pass: add basic tests for static/dynamic challeng= es ...................................................................... test_user_pass: add basic tests for static/dynamic challenges Change-Id: I8b5570f6314e917f92dce072279efe415d79b22a Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Message-Id: <20240207171239.86730-1-frank@...2641...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28= 191.html Signed-off-by: Gert Doering --- M tests/unit_tests/openvpn/test_user_pass.c 1 file changed, 61 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/75/475/9 diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/o= penvpn/test_user_pass.c index bd4eb1f..5d3f9b6 100644 --- a/tests/unit_tests/openvpn/test_user_pass.c +++ b/tests/unit_tests/openvpn/test_user_pass.c @@ -267,12 +267,73 @@ assert_string_equal(up.password, "fuser"); } +#ifdef ENABLE_MANAGEMENT +static void +test_get_user_pass_dynamic_challenge(void **state) +{ + struct user_pass up =3D { 0 }; + reset_user_pass(&up); + const char *challenge =3D "CRV1:R,E:Om01u7Fh4LrGBS7uh0SWmzwabUiGiW6l:Y= 3Ix:Please enter token PIN"; + unsigned int flags =3D GET_USER_PASS_DYNAMIC_CHALLENGE; + + expect_string(query_user_exec_builtin, query_user[i].prompt, "CHALLENG= E: Please enter token PIN"); + will_return(query_user_exec_builtin, "challenge_response"); + will_return(query_user_exec_builtin, true); + assert_true(get_user_pass_cr(&up, NULL, "UT", flags, challenge)); + assert_true(up.defined); + assert_string_equal(up.username, "cr1"); + assert_string_equal(up.password, "CRV1::Om01u7Fh4LrGBS7uh0SWmzwabUiGiW= 6l::challenge_response"); +} + +static void +test_get_user_pass_static_challenge(void **state) +{ + struct user_pass up =3D { 0 }; + reset_user_pass(&up); + const char *challenge =3D "Please enter token PIN"; + unsigned int flags =3D GET_USER_PASS_STATIC_CHALLENGE; + + expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT= Username:"); + will_return(query_user_exec_builtin, "cuser"); + expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT= Password:"); + will_return(query_user_exec_builtin, "cpassword"); + will_return(query_user_exec_builtin, true); + expect_string(query_user_exec_builtin, query_user[i].prompt, "CHALLENG= E: Please enter token PIN"); + will_return(query_user_exec_builtin, "challenge_response"); + will_return(query_user_exec_builtin, true); + assert_true(get_user_pass_cr(&up, NULL, "UT", flags, challenge)); + assert_true(up.defined); + assert_string_equal(up.username, "cuser"); + /* SCRV1:cpassword:challenge_response but base64-encoded */ + assert_string_equal(up.password, "SCRV1:Y3Bhc3N3b3Jk:Y2hhbGxlbmdlX3Jlc= 3BvbnNl"); + + reset_user_pass(&up); + + flags |=3D GET_USER_PASS_INLINE_CREDS; + + /*FIXME: query_user_exec() called even though nothing queued */ + will_return(query_user_exec_builtin, true); + expect_string(query_user_exec_builtin, query_user[i].prompt, "CHALLENG= E: Please enter token PIN"); + will_return(query_user_exec_builtin, "challenge_response"); + will_return(query_user_exec_builtin, true); + assert_true(get_user_pass_cr(&up, "iuser\nipassword", "UT", flags, cha= llenge)); + assert_true(up.defined); + assert_string_equal(up.username, "iuser"); + /* SCRV1:ipassword:challenge_response but base64-encoded */ + assert_string_equal(up.password, "SCRV1:aXBhc3N3b3Jk:Y2hhbGxlbmdlX3Jlc= 3BvbnNl"); +} +#endif /* ENABLE_MANAGEMENT */ + const struct CMUnitTest user_pass_tests[] =3D { cmocka_unit_test(test_get_user_pass_defined), cmocka_unit_test(test_get_user_pass_needok), cmocka_unit_test(test_get_user_pass_inline_creds), cmocka_unit_test(test_get_user_pass_authfile_stdin), cmocka_unit_test(test_get_user_pass_authfile_file), +#ifdef ENABLE_MANAGEMENT + cmocka_unit_test(test_get_user_pass_dynamic_challenge), + cmocka_unit_test(test_get_user_pass_static_challenge), +#endif /* ENABLE_MANAGEMENT */ }; int -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/475?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I8b5570f6314e917f92dce072279efe415d79b22a Gerrit-Change-Number: 475 Gerrit-PatchSet: 9 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --pfAzTXqaZZc= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #9 to the change originally cr= eated by flichtenheld.

View Change

The following approvals got outda= ted and were removed: Code-Review+2 by plaisthos

test_user_pass: add basic tests for static/dynam=
ic challenges

Change-Id: I8b5570f6314e917f92dce072279efe415d79b22aSigned-off-by: Frank Lichtenheld <frank@...2641...>
Acked-by: Ar= ne Schwabe <arne-openvpn@...1227...>
Message-Id: <2024020717123= 9.86730-1-frank@...2641...>
URL: https://www.mail-archive.com/openvpn= -devel@lists.sourceforge.net/msg28191.html
Signed-off-by: Gert Doering &= lt;gert@...1296...>
---
M tests/unit_tests/openvpn/test_user_pass.= c
1 file changed, 61 insertions(+), 0 deletions(-)

git pull ss=
h://gerrit.openvpn.net:29418/openvpn refs/changes/75/475/9
diff --=
git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/openvpn/=
test_user_pass.c
index bd4eb1f..5d3f9b6 100644
--- a/tests/unit_tests/openvpn/test_user_pass.c
+++ b/t= ests/unit_tests/openvpn/test_user_pass.c
@@ -267,12 +267,73= @@
assert_string_equal(up.password, "fuser"= );
}

+#ifdef ENABLE_MANAGEMENT
+static void
+test_get_user_pass_dynamic_challenge(void **state)<= br>+{
+ struct user_pass up =3D { 0 };
= + reset_user_pass(&up);<= /span>
+ const char *chal= lenge =3D "CRV1:R,E:Om01u7Fh4LrGBS7uh0SWmzwabUiGiW6l:Y3Ix:Please enter= token PIN";
+ = unsigned int flags =3D GET_USER_PASS_DYNAMIC_CHALLENGE;
+
+ expect_string(query_user_exec_builtin, query_user[i]= .prompt, "CHALLENGE: Please enter token PIN");
+ will_return(query_user_exec_builti= n, "challenge_response");
+ will_return(query_user_exec_builtin, true);
<= span style=3D"color: hsl(120, 100%, 40%);">+ assert_true(get_user_pass_c= r(&up, NULL, "UT", flags, challenge));

+ assert_true(up.defined);
+ assert_string_equal(up.usern= ame, "cr1");
+}
+=
+static void<= br>+test_get_user_pass_static_c= hallenge(void **state)
+ struct user= _pass up =3D { 0 };
+= reset_user_pass(&up);
+ const char *challenge =3D "Please enter token PIN";=
+ unsigned int fl= ags =3D GET_USER_PASS_STATIC_CHALLENGE;
+
= + expect_string(query_user_exec_builtin, query_user[i].prompt, "Ent= er UT Username:");
+ will_return(query_user_exec_builtin, "cuser");
= + expect_string(query_user_e= xec_builtin, query_user[i].prompt, "Enter UT Password:");<= br>+ will_return(query_user_= exec_builtin, "cpassword");
+ will_return(query_user_exec_builtin, true);+ expect_string(query_user_= exec_builtin, query_user[i].prompt, "CHALLENGE: Please enter token PIN= ");
+ will_re= turn(query_user_exec_builtin, "challenge_response");
+ will_return(query_user_exec_= builtin, true);
+ = assert_true(get_user_pass_cr(&up, NULL, "UT", flags, challeng= e));
+ assert_true= (up.defined);
+ as= sert_string_equal(up.username, "cuser");
+ /* SCRV1:cpassword:challenge_response bu= t base64-encoded */
+= assert_string_equal(up.password, "SCRV1:Y3Bhc3N3b3Jk:Y2hhbGxlbmdlX= 3Jlc3BvbnNl");
+=
+ reset_user_pass= (&up);
++ flags |=3D GET_USER_PASS= _INLINE_CREDS;
+
+ /*FIXME: query_user_= exec() called even though nothing queued */
+ will_return(query_user_exec_builtin, true);
+ expect_string(query= _user_exec_builtin, query_user[i].prompt, "CHALLENGE: Please enter tok= en PIN");
+ w= ill_return(query_user_exec_builtin, "challenge_response");=
+ will_return(query_user= _exec_builtin, true);
+ assert_true(get_user_pass_cr(&up, "iuser\nipassword", &= quot;UT", flags, challenge));
+ assert_true(up.defined);
+ assert_string_equal(up.username, "iuser&qu= ot;);
+ /* SCRV1:i= password:challenge_response but base64-encoded */
+ assert_string_equal(up.password, "SC= RV1:aXBhc3N3b3Jk:Y2hhbGxlbmdlX3Jlc3BvbnNl");
+}
+#endif /* ENABLE_MANAGEMENT */
+
const struct CMUnitTest user_pass_= tests[] =3D {
cmocka_unit_test(test_get_user_pass_defi= ned),
cmocka_unit_test(test_get_user_pass_needok),
cmocka_unit_test(test_get_user_pass_inline_creds),=
cmocka_unit_test(test_get_user_pass_authfile_stdin),<= br> cmocka_unit_test(test_get_user_pass_authfile_file),+#ifdef ENABLE_MANAGEMENT
+ cmocka_unit_test(tes= t_get_user_pass_dynamic_challenge),
+ cmocka_unit_test(test_get_user_pass_static_challenge),<= /span>
+#endif /* ENABLE_MAN= AGEMENT */
};

int

To view, visit change 475. To unsubscribe, or for= help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I8b5570f6314e917f92dce072279= efe415d79b22a
Gerrit-Change-Number: 475
Gerrit-PatchSet: 9
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--pfAzTXqaZZc=--