From: "cron2 (Code Review)" Date: Thu, 8 Feb 2024 08:31:18 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="xLN8nztd52o="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: test_user_pass: add basic tests for static/dynamic challenges List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --xLN8nztd52o= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/47= 5?usp=3Demail ) Change subject: test_user_pass: add basic tests for static/dynamic challeng= es ...................................................................... test_user_pass: add basic tests for static/dynamic challenges Change-Id: I8b5570f6314e917f92dce072279efe415d79b22a Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Message-Id: <20240207171239.86730-1-frank@...2641...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28= 191.html Signed-off-by: Gert Doering --- M tests/unit_tests/openvpn/test_user_pass.c 1 file changed, 61 insertions(+), 0 deletions(-) diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/o= penvpn/test_user_pass.c index bd4eb1f..5d3f9b6 100644 --- a/tests/unit_tests/openvpn/test_user_pass.c +++ b/tests/unit_tests/openvpn/test_user_pass.c @@ -267,12 +267,73 @@ assert_string_equal(up.password, "fuser"); } +#ifdef ENABLE_MANAGEMENT +static void +test_get_user_pass_dynamic_challenge(void **state) +{ + struct user_pass up =3D { 0 }; + reset_user_pass(&up); + const char *challenge =3D "CRV1:R,E:Om01u7Fh4LrGBS7uh0SWmzwabUiGiW6l:Y= 3Ix:Please enter token PIN"; + unsigned int flags =3D GET_USER_PASS_DYNAMIC_CHALLENGE; + + expect_string(query_user_exec_builtin, query_user[i].prompt, "CHALLENG= E: Please enter token PIN"); + will_return(query_user_exec_builtin, "challenge_response"); + will_return(query_user_exec_builtin, true); + assert_true(get_user_pass_cr(&up, NULL, "UT", flags, challenge)); + assert_true(up.defined); + assert_string_equal(up.username, "cr1"); + assert_string_equal(up.password, "CRV1::Om01u7Fh4LrGBS7uh0SWmzwabUiGiW= 6l::challenge_response"); +} + +static void +test_get_user_pass_static_challenge(void **state) +{ + struct user_pass up =3D { 0 }; + reset_user_pass(&up); + const char *challenge =3D "Please enter token PIN"; + unsigned int flags =3D GET_USER_PASS_STATIC_CHALLENGE; + + expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT= Username:"); + will_return(query_user_exec_builtin, "cuser"); + expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT= Password:"); + will_return(query_user_exec_builtin, "cpassword"); + will_return(query_user_exec_builtin, true); + expect_string(query_user_exec_builtin, query_user[i].prompt, "CHALLENG= E: Please enter token PIN"); + will_return(query_user_exec_builtin, "challenge_response"); + will_return(query_user_exec_builtin, true); + assert_true(get_user_pass_cr(&up, NULL, "UT", flags, challenge)); + assert_true(up.defined); + assert_string_equal(up.username, "cuser"); + /* SCRV1:cpassword:challenge_response but base64-encoded */ + assert_string_equal(up.password, "SCRV1:Y3Bhc3N3b3Jk:Y2hhbGxlbmdlX3Jlc= 3BvbnNl"); + + reset_user_pass(&up); + + flags |=3D GET_USER_PASS_INLINE_CREDS; + + /*FIXME: query_user_exec() called even though nothing queued */ + will_return(query_user_exec_builtin, true); + expect_string(query_user_exec_builtin, query_user[i].prompt, "CHALLENG= E: Please enter token PIN"); + will_return(query_user_exec_builtin, "challenge_response"); + will_return(query_user_exec_builtin, true); + assert_true(get_user_pass_cr(&up, "iuser\nipassword", "UT", flags, cha= llenge)); + assert_true(up.defined); + assert_string_equal(up.username, "iuser"); + /* SCRV1:ipassword:challenge_response but base64-encoded */ + assert_string_equal(up.password, "SCRV1:aXBhc3N3b3Jk:Y2hhbGxlbmdlX3Jlc= 3BvbnNl"); +} +#endif /* ENABLE_MANAGEMENT */ + const struct CMUnitTest user_pass_tests[] =3D { cmocka_unit_test(test_get_user_pass_defined), cmocka_unit_test(test_get_user_pass_needok), cmocka_unit_test(test_get_user_pass_inline_creds), cmocka_unit_test(test_get_user_pass_authfile_stdin), cmocka_unit_test(test_get_user_pass_authfile_file), +#ifdef ENABLE_MANAGEMENT + cmocka_unit_test(test_get_user_pass_dynamic_challenge), + cmocka_unit_test(test_get_user_pass_static_challenge), +#endif /* ENABLE_MANAGEMENT */ }; int -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/475?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I8b5570f6314e917f92dce072279efe415d79b22a Gerrit-Change-Number: 475 Gerrit-PatchSet: 9 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: merged --xLN8nztd52o= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 submitted this change.

View Change

test_user_pass: add basic tests for static/dyn=
amic challenges

Change-Id: I8b5570f6314e917f92dce072279efe415d79b22a=
Signed-off-by: Frank Lichtenheld <frank@...2641...>
Acked-by: = Arne Schwabe <arne-openvpn@...1227...>
Message-Id: <20240207171= 239.86730-1-frank@...2641...>
URL: https://www.mail-archive.com/openv= pn-devel@lists.sourceforge.net/msg28191.html
Signed-off-by: Gert Doering= <gert@...1296...>
---
M tests/unit_tests/openvpn/test_user_pas= s.c
1 file changed, 61 insertions(+), 0 deletions(-)

diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_test=
s/openvpn/test_user_pass.c
index bd4eb1f..5d3f9b6 100644
--- a/tests/unit_tests/openvpn/test_user_pass.c
+++ b/tests/unit_tests/openvpn/test_user_pass.c

@@ -267,= 12 +267,73 @@
assert_string_equal(up.password, "f= user");
}

+#ifdef ENABLE_MANAGEMENT
+static void
+test_get_user_pass_dynamic_challenge(void **stat= e)
+{
+ struct user_pass up =3D { 0 };<= /span>
+ reset_user_pass(= &up);
+ const = char *challenge =3D "CRV1:R,E:Om01u7Fh4LrGBS7uh0SWmzwabUiGiW6l:Y3Ix:Pl= ease enter token PIN";
+ unsigned int flags =3D GET_USER_PASS_DYNAMIC_CHALLENGE;<= br>+
+ expect_string(query_user_exec_builtin, que= ry_user[i].prompt, "CHALLENGE: Please enter token PIN");+ will_return(query_user_e= xec_builtin, "challenge_response");
+ will_return(query_user_exec_builtin, true);
+ assert_true(get_u= ser_pass_cr(&up, NULL, "UT", flags, challenge));
+ assert_true(up.defined);

+ assert_string_equal= (up.username, "cr1");
+ assert_string_equal(up.password, "CRV1::Om01u7Fh4LrGBS= 7uh0SWmzwabUiGiW6l::challenge_response");
+}
+
+static voi= d
+test_get_user_pass= _static_challenge(void **state)
+{
+ st= ruct user_pass up =3D { 0 };
+ reset_user_pass(&up);
+ const char *challenge =3D "Please enter token P= IN";
+ unsign= ed int flags =3D GET_USER_PASS_STATIC_CHALLENGE;
+
+ expect_string(query_user_exec_builtin, query_user[i].prompt, = "Enter UT Username:");
+ will_return(query_user_exec_builtin, "cuser");
+ expect_string(que= ry_user_exec_builtin, query_user[i].prompt, "Enter UT Password:")= ;
+ will_return(qu= ery_user_exec_builtin, "cpassword");
+ will_return(query_user_exec_builtin, true);<= /span>
+ expect_string(qu= ery_user_exec_builtin, query_user[i].prompt, "CHALLENGE: Please enter = token PIN");
+ = will_return(query_user_exec_builtin, "challenge_response");
+ will_return(query_u= ser_exec_builtin, true);
+ assert_true(get_user_pass_cr(&up, NULL, "UT", flags,= challenge));
+ as= sert_true(up.defined);
+ /* SCRV1:cpassword:challenge_re= sponse but base64-encoded */
+ assert_string_equal(up.password, "SCRV1:Y3Bhc3N3b3Jk:Y2hh= bGxlbmdlX3Jlc3BvbnNl");
+
+ reset_= user_pass(&up);
+=
+ flags |=3D GET_= USER_PASS_INLINE_CREDS;
+
+ /*FIXME: qu= ery_user_exec() called even though nothing queued */
+ will_return(query_user_exec_builtin, = true);
+ expect_st= ring(query_user_exec_builtin, query_user[i].prompt, "CHALLENGE: Please= enter token PIN");
+ will_return(query_user_exec_builtin, "challenge_response"= ;);
+ will_return(= query_user_exec_builtin, true);
+ assert_true(get_user_pass_cr(&up, "iuser\nipasswor= d", "UT", flags, challenge));
+ assert_true(up.defined);
+ assert_string_equal(up.username, &quo= t;iuser");
+ = /* SCRV1:ipassword:challenge_response but base64-encoded */
+ assert_string_equal(up.password= , "SCRV1:aXBhc3N3b3Jk:Y2hhbGxlbmdlX3Jlc3BvbnNl");

+}

+#endif /* ENABLE_MANAGEMENT */
+
const struct CMUnitTest= user_pass_tests[] =3D {
cmocka_unit_test(test_get_use= r_pass_defined),
cmocka_unit_test(test_get_user_pass_n= eedok),
cmocka_unit_test(test_get_user_pass_inline_cre= ds),
cmocka_unit_test(test_get_user_pass_authfile_stdi= n),
cmocka_unit_test(test_get_user_pass_authfile_file)= ,
+#ifdef ENABLE_MANA= GEMENT
+ cmocka_un= it_test(test_get_user_pass_dynamic_challenge),
+ cmocka_unit_test(test_get_user_pass_static_c= hallenge),
+#endif /*= ENABLE_MANAGEMENT */
};

int


To view, visit change 475. To unsubscr= ibe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I8b5570f6314e917f92dce072279= efe415d79b22a
Gerrit-Change-Number: 475
Gerrit-PatchSet: 9
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: merged
--xLN8nztd52o=--