From: "flichtenheld (Code Review)" Date: Sun, 5 Apr 2026 20:39:33 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="el4+xRR0M6U="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: tapctl: Remove unused function dont_mute List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --el4+xRR0M6U= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1615?usp=3Demail to review the following change. Change subject: tapctl: Remove unused function dont_mute ...................................................................... tapctl: Remove unused function dont_mute Identified by cppcheck. Change-Id: I87c40dc94035345add1162e5029e51288811cb09 Signed-off-by: Frank Lichtenheld --- M src/tapctl/error.h M src/tapctl/main.c 2 files changed, 2 insertions(+), 11 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/15/1615/1 diff --git a/src/tapctl/error.h b/src/tapctl/error.h index 9632b2f..f9586dc 100644 --- a/src/tapctl/error.h +++ b/src/tapctl/error.h @@ -109,11 +109,11 @@ return (level & M_DEBUG_LEVEL) <=3D x_debug_level; } -/** Return true if flags represent and enabled, not muted log level */ +/** Return true if flags represent */ static inline bool msg_test(unsigned int flags) { - return check_debug_level(flags) && dont_mute(flags); + return check_debug_level(flags); } #endif /* ifndef ERROR_H */ diff --git a/src/tapctl/main.c b/src/tapctl/main.c index 1d047dd..6a4a240 100644 --- a/src/tapctl/main.c +++ b/src/tapctl/main.c @@ -686,15 +686,6 @@ } -bool -dont_mute(unsigned int flags) -{ - UNREFERENCED_PARAMETER(flags); - - return true; -} - - void x_msg_va(const unsigned int flags, const char *format, va_list arglist) { -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1615?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I87c40dc94035345add1162e5029e51288811cb09 Gerrit-Change-Number: 1615 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --el4+xRR0M6U= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

tapctl: Remove unused function dont_mute
Identified by cppcheck.

Change-Id: I87c40dc94035345add1162e5029= e51288811cb09
Signed-off-by: Frank Lichtenheld <frank@...2641...><= br>---
M src/tapctl/error.h
M src/tapctl/main.c
2 files changed, 2= insertions(+), 11 deletions(-)

git pull ssh://g=
errit.openvpn.net:29418/openvpn refs/changes/15/1615/1
diff --git a=
/src/tapctl/error.h b/src/tapctl/error.h
index 9632b2f..f95= 86dc 100644
--- a/src/tapctl/error.h
+++ b/= src/tapctl/error.h
@@ -109,11 +109,11 @@
= return (level & M_DEBUG_LEVEL) <=3D x_debug_level;
}

= -/** Return true if flags represent and enabled, not muted log level */
+/** Return true if flag= s represent */
static inline bool
msg_tes= t(unsigned int flags)
{
- return check_debug_level(flags) && dont_mute= (flags);
+ return = check_debug_level(flags);
}

#endif /* ifndef ERROR_H */

diff --git a/src/tapctl/ma= in.c b/src/tapctl/main.c
index 1d047dd..6a4a240 100644

--- a/src/tapctl/main.c
+++ b/src/tapctl/main.c=
@@ -686,15 +686,6 @@
}
<= /span>

-bool=
-dont_mute(unsigned in= t flags)
-{
<= span style=3D"color: hsl(0, 100%, 40%);">- UNREFERENCED_PARAMETER(flags)= ;

-
- return true;
-}
-
-
<= span> void
x_msg_va(const unsigned int flags, const char *= format, va_list arglist)
{

To view, visit change 1615. To unsubscribe, or for help writing mail filte= rs, visit settin= gs.

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I87c40dc94035345add1162e5029= e51288811cb09
Gerrit-Change-Number: 1615
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --el4+xRR0M6U=--