To: openembedded-core@lists.openembedded.org
References: <20190820090559.196193-1-kai.kang@windriver.com>
	<20190820090559.196193-2-kai.kang@windriver.com>
From: Ross Burton <ross.burton@intel.com>
Organization: Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way,
	Swindon SN3 1RJ
Message-ID: <e37dbfa4-eea3-ba19-da18-337cb7ec8ec3@intel.com>
Date: Tue, 20 Aug 2019 19:41:59 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0)
	Gecko/20100101 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190820090559.196193-2-kai.kang@windriver.com>
Subject: Re: [PATCH 1/1] adwaita-icon-theme: workaround for do_populate_sysroot failure
Precedence: list
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit

On 20/08/2019 10:05, kai.kang@windriver.com wrote:
> From: Kai Kang <kai.kang@windriver.com>
> 
> It fails to run task do_populate_sysroot of adwaita-icon-theme rarely:
> 
> | DEBUG: Executing shell function sysroot_stage_all
> | cpio: ./icons/Adwaita/16x16/legacy/_inst.21134_: Cannot stat: No such
>    file or directory
> 
> In script ${S}/install-sh, temporary files _inst.* are created and will be
> removed by shell builtin command trap when the script exits:
> 
>      # Make a couple of temp file names in the proper directory.
>      dsttmp=${dstdirslash}_inst.$$_
>      rmtmp=${dstdirslash}_rm.$$_
> 
>      # Trap to clean up those temp files at exit.
>      trap 'ret=$?; rm -f "$dsttmp" "$rmtmp" && exit $ret' 0
> 
> The temporary files should be deleted already after task do_install. But
> somehow they are still exist until the gap between commands find and
> cpio in populate_sysroot function sysroot_stage_dir().

So does this only happen to adwaita-icon-theme?  Is it a bug in 
install-sh, so impacts almost every automake-using package?  Or is it a 
bug in how adwaita-icon-theme is using install-sh?

Ross