From: "cron2 (Code Review)" Date: Wed, 20 Aug 2025 21:13:11 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="rYDFNqnGC48="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Remove use of 'dh dh2048.pem' from sample configs, remove 'dh2048.pem... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , flichtenheld Cc: openvpn-devel --rYDFNqnGC48= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1145?usp=3Demail to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: Remove use of 'dh dh2048.pem' from sample configs, remove '= dh2048.pem' file ...................................................................... Remove use of 'dh dh2048.pem' from sample configs, remove 'dh2048.pem' file Since commit bd9aa06feb41 (Jan 2015) OpenVPN has allowed to use '--dh none' to disable traditional Diffie Hellman, since more secure ECDH algorithms are available that do not use explicit DH parameters. If configured with a suffiently high securelevel (3+), or if running in FIPS mode, OpenSSL 3.5 will refuse 2048 bit DH files, making our tests fail. Thus, remove all the DH2048 stuff from our sample configs. Github: triggered by OpenVPN/openvpn#819 Change-Id: If66438662bd862a195b2a69c4fa45f63838982b7 Signed-off-by: Gert Doering Message-Id: <20250820175459.11227-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32= 632.html Signed-off-by: Gert Doering --- M doc/tests/authentication-plugins.md M sample/sample-config-files/loopback-server M sample/sample-config-files/server.conf D sample/sample-keys/dh2048.pem M sample/sample-plugins/keying-material-exporter-demo/server.ovpn 5 files changed, 4 insertions(+), 17 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/45/1145/4 diff --git a/doc/tests/authentication-plugins.md b/doc/tests/authentication= -plugins.md index b47c544..45fa381 100644 --- a/doc/tests/authentication-plugins.md +++ b/doc/tests/authentication-plugins.md @@ -36,7 +36,7 @@ verb 4 dev tun server 10.8.0.0 255.255.255.0 - dh sample/sample-keys/dh2048.pem + dh none ca sample/sample-keys/ca.crt cert sample/sample-keys/server.crt key sample/sample-keys/server.key diff --git a/sample/sample-config-files/loopback-server b/sample/sample-con= fig-files/loopback-server index 58daeb56..1980218 100644 --- a/sample/sample-config-files/loopback-server +++ b/sample/sample-config-files/loopback-server @@ -17,7 +17,7 @@ verb 3 reneg-sec 10 tls-server -dh sample-keys/dh2048.pem +dh none ca sample-keys/ca.crt key sample-keys/server.key cert sample-keys/server.crt diff --git a/sample/sample-config-files/server.conf b/sample/sample-config-= files/server.conf index f6d9e65..8943c34 100644 --- a/sample/sample-config-files/server.conf +++ b/sample/sample-config-files/server.conf @@ -87,11 +87,6 @@ cert server.crt key server.key # This file should be kept secret -# Diffie hellman parameters. -# Generate your own with: -# openssl dhparam -out dh2048.pem 2048 -dh dh2048.pem - # Allow to connect to really old OpenVPN versions # without AEAD support (OpenVPN 2.3.x or older) # This adds AES-256-CBC as fallback cipher and @@ -306,4 +301,4 @@ # Notify the client that when the server restarts so it # can automatically reconnect. -explicit-exit-notify 1 \ No newline at end of file +explicit-exit-notify 1 diff --git a/sample/sample-keys/dh2048.pem b/sample/sample-keys/dh2048.pem deleted file mode 100644 index d393581..0000000 --- a/sample/sample-keys/dh2048.pem +++ /dev/null @@ -1,8 +0,0 @@ ------BEGIN DH PARAMETERS----- -MIIBCAKCAQEAgGOVdT2c3GUITi1pF9u+yo72PRBW7I7SnNIsHmXCRYibpyPMGxKM -ROK6rduMllC0CjiXQZhMfqCg+GIca9xxBPKtTnwtKWD3eH5wgs24kw86mODITjJk -6lTNM8it2HY4UuIQoFCqCdt5f5Gwgh2nwU5+dy731md6pmw9x9jUEXoyh67CeZfb -C45x5ttzjpSBvYe5ZIiUypYKumYhdiZhk0RLefEtlUYF9oXrUExDqfYDpSO/1/X3 -oHC0O0EV3Lh1boZTG7+FjcvMYLIKYUDTmxHpII6/OAHhprg7U9ui1i7GyQRv1lze -QV3FGO4UwLntnv352iYy91b0ls2mwD+zTwIBAg=3D=3D ------END DH PARAMETERS----- diff --git a/sample/sample-plugins/keying-material-exporter-demo/server.ovp= n b/sample/sample-plugins/keying-material-exporter-demo/server.ovpn index 5c670b1..1aabcb9 100644 --- a/sample/sample-plugins/keying-material-exporter-demo/server.ovpn +++ b/sample/sample-plugins/keying-material-exporter-demo/server.ovpn @@ -8,7 +8,7 @@ ca ../../sample-keys/ca.crt cert ../../sample-keys/server.crt key ../../sample-keys/server.key -dh ../../sample-keys/dh2048.pem +dh none server 10.8.0.0 255.255.255.0 port 1194 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1145?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: If66438662bd862a195b2a69c4fa45f63838982b7 Gerrit-Change-Number: 1145 Gerrit-PatchSet: 4 Gerrit-Owner: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --rYDFNqnGC48= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #4 to this change.

View Change

The following approvals got outdated and were removed: Code-Review+2 by plaisthos

Remove use of 'dh dh2048.pem' from sampl=
e configs, remove 'dh2048.pem' file

Since commit bd9aa06feb4= 1 (Jan 2015) OpenVPN has allowed to use
'--dh none' to disable t= raditional Diffie Hellman, since more secure
ECDH algorithms are availab= le that do not use explicit DH parameters.

If configured with a suff= iently high securelevel (3+), or if running in
FIPS mode, OpenSSL 3.5 wi= ll refuse 2048 bit DH files, making our tests
fail.

Thus, remove = all the DH2048 stuff from our sample configs.

Github: triggered by O= penVPN/openvpn#819

Change-Id: If66438662bd862a195b2a69c4fa45f6383898= 2b7
Signed-off-by: Gert Doering <gert@...1296...>
Message-Id: &= lt;20250820175459.11227-1-gert@...1296...>
URL: https://www.mail-arch= ive.com/openvpn-devel@lists.sourceforge.net/msg32632.html
Signed-off-by:= Gert Doering <gert@...1296...>
---
M doc/tests/authentication-= plugins.md
M sample/sample-config-files/loopback-server
M sample/samp= le-config-files/server.conf
D sample/sample-keys/dh2048.pem
M sample/= sample-plugins/keying-material-exporter-demo/server.ovpn
5 files changed= , 4 insertions(+), 17 deletions(-)

git pull ssh://gerrit.openvpn.=
net:29418/openvpn refs/changes/45/1145/4
diff --git a/doc/tests/aut=
hentication-plugins.md b/doc/tests/authentication-plugins.md
index b47c544..45fa381 100644
--- a/doc/tests/authenticat= ion-plugins.md
+++ b/doc/tests/authentication-plugins.md
@@ -36,7 +36,7 @@
verb 4
dev tun

server 10.8.0.0 255.255.255.0

- dh sample/sample-key= s/dh2048.pem
+ d= h none
ca sample/sample-keys/ca.crt
= cert sample/sample-keys/server.crt
key sample= /sample-keys/server.key
diff --git a/sample/sample-config-f= iles/loopback-server b/sample/sample-config-files/loopback-serverindex 58daeb56..1980218 100644
--- a/sample/sample-c= onfig-files/loopback-server
+++ b/sample/sample-config-file= s/loopback-server
@@ -17,7 +17,7 @@
verb 3=
reneg-sec 10
tls-server
-dh sample-keys/dh2048.pem
+dh none
ca samp= le-keys/ca.crt
key sample-keys/server.key
= cert sample-keys/server.crt
diff --git a/sample/sample-con= fig-files/server.conf b/sample/sample-config-files/server.conf
index f6d9e65..8943c34 100644
--- a/sample/sample-confi= g-files/server.conf
+++ b/sample/sample-config-files/server= .conf
@@ -87,11 +87,6 @@
cert server.crt
key server.key # This file should be kept secret
-# Diffie hell= man parameters.
-# Gene= rate your own with:
-# = openssl dhparam -out dh2048.pem 2048
-dh dh2048.pem
-
# Allow to connect to really old OpenVPN version= s
# without AEAD support (OpenVPN 2.3.x or older) # This adds AES-256-CBC as fallback cipher and
@@ = -306,4 +301,4 @@

# Notify the client tha= t when the server restarts so it
# can automatically recon= nect.
-explicit-exit-no= tify 1
\ No newline at end of file
+explicit-exit-notify 1
diff = --git a/sample/sample-keys/dh2048.pem b/sample/sample-keys/dh2048.pem
deleted file mode 100644
index d393581..0000000<= /span>
--- a/sample/sample-keys/dh2048.pem
+++ /de= v/null
@@ -1,8 +0,0 @@
------BEGIN DH PARAM= ETERS-----
-MIIBCAKCAQE= AgGOVdT2c3GUITi1pF9u+yo72PRBW7I7SnNIsHmXCRYibpyPMGxKM
-ROK6rduMllC0CjiXQZhMfqCg+GIca9xxBPKtTnwtKWD= 3eH5wgs24kw86mODITjJk
-= 6lTNM8it2HY4UuIQoFCqCdt5f5Gwgh2nwU5+dy731md6pmw9x9jUEXoyh67CeZfb
= -C45x5ttzjpSBvYe5ZIiUypYKumYhdiZh= k0RLefEtlUYF9oXrUExDqfYDpSO/1/X3
-oHC0O0EV3Lh1boZTG7+FjcvMYLIKYUDTmxHpII6/OAHhprg7U9ui1i7GyQRv1lze=
-QV3FGO4UwLntnv352iYy9= 1b0ls2mwD+zTwIBAg=3D=3D
------END DH PARAMETERS-----=
diff --git a/sample/sample-plugins/keying-material-exporter-demo/= server.ovpn b/sample/sample-plugins/keying-material-exporter-demo/server.ov= pn
index 5c670b1..1aabcb9 100644
--- a/samp= le/sample-plugins/keying-material-exporter-demo/server.ovpn
+++ b/sample/sample-plugins/keying-material-exporter-demo/server.ovpn
@@ -8,7 +8,7 @@
ca ../../sample-keys/ca.cr= t
cert ../../sample-keys/server.crt
key= ../../sample-keys/server.key
-dh ../../sample-keys/dh2048.pem
+dh none

s= erver 10.8.0.0 255.255.255.0
port 1194

To view, visit change 1145. To unsubscribe, or for help writin= g mail filters, visit settin= gs.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If66438662bd862a195b2a69c4fa= 45f63838982b7
Gerrit-Change-Number: 1145
Gerrit-PatchSet: 4
Gerrit-Owner: cron2 <gert@...1296...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--rYDFNqnGC48=--