Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03EB8C433E0 for ; Thu, 11 Jun 2020 11:52:40 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF90720691 for ; Thu, 11 Jun 2020 11:52:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF90720691 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jjLkf-0000Cu-Rl; Thu, 11 Jun 2020 11:52:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jjLkd-0000CB-S6 for xen-devel@lists.xenproject.org; Thu, 11 Jun 2020 11:52:07 +0000 X-Inumbo-ID: f9261914-abd9-11ea-b509-12813bfff9fa Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f9261914-abd9-11ea-b509-12813bfff9fa; Thu, 11 Jun 2020 11:52:07 +0000 (UTC) Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: dDEC1pmsvKf7uyrBf7jK0HYgkq9fr62btkvQ1EKAdtjvXO20kvRD4/wEfjqGoECBjHg11vLwem v7te6OCNgczEwj6F/4TSbaEKgeebUlRpzIxUguWD2Np5o6J4pNe63CTyyIZNqGyWMSS7OyTWt4 egysWBFwbs9/dVJKi+yIHcr426rL+fZ3HycKMkItWO1DaLOeaXjjvTV+CAcAm6xh4FF7PORiUg 6oKWt0eTfa23Z4dlISJeHZxg6slMD+eHUaiortTdgyWyOShnD4TZvs8/i04mv5tZaU7SB4o7qU RdE= X-SBRS: 2.7 X-MesageID: 20124596 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,499,1583211600"; d="scan'208";a="20124596" Subject: Re: [PATCH] libacpi: Widen TPM detection To: Jason Andryuk , References: <20200611035518.379297-1-jandryuk@gmail.com> From: Andrew Cooper Message-ID: Date: Thu, 11 Jun 2020 12:52:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200611035518.379297-1-jandryuk@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson , Jan Beulich , Wei Liu , Paul Durrant Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 11/06/2020 04:55, Jason Andryuk wrote: > The hardcoded tpm_signature is too restrictive to detect many TPMs. For > instance, it doesn't accept a QEMU emulated TPM (VID 0x1014 DID 0x0001). > Make the TPM detection match that in rombios which accepts a wider > range. > > With this change, the TPM's TCPA ACPI table is generated and the guest > OS can automatically load the tpm_tis driver. It also allows seabios to > detect and use the TPM. However, seabios skips some TPM initialization > when running under Xen, so it will not populate any PCRs unless modified > to run the initialization under Xen. > > Signed-off-by: Jason Andryuk Reviewed-by: Andrew Cooper This looks like it wants backporting, so CC'ing Paul for a 4.14 release ack.