Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=quantatw.com (client-ip=220.128.79.91; helo=mx02.quantatw.com; envelope-from=prvs=465f16df2=duke.du@quantatw.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=quantatw.com Received: from mx02.quantatw.com (mx02.quantatw.com [220.128.79.91]) by lists.ozlabs.org (Postfix) with ESMTP id 4BBTvQ0lPPzDqQZ for ; Wed, 22 Jul 2020 19:00:25 +1000 (AEST) IronPort-SDR: PGAnCBJvjGEL7zK5A621QCm+ldvtmrNxvHY/x31O9QHHcBXj7K97A28xAy5d7u/uANF/G0OT2s r5iepFPDlZaw== Received: from unknown (HELO mailbx06.quanta.corp) ([10.243.91.101]) by mx02.quantatw.com with ESMTP; 22 Jul 2020 17:00:22 +0800 Received: from mailbx12.quanta.corp (10.243.91.109) by mailbx06.quanta.corp (10.243.91.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Wed, 22 Jul 2020 17:00:19 +0800 Received: from mailbx12.quanta.corp ([192.168.57.12]) by mailbx12.quanta.corp ([192.168.57.12]) with mapi id 15.01.2044.004; Wed, 22 Jul 2020 17:00:19 +0800 From: =?big5?B?RHVrZSBEdSAop/myu7nFKQ==?= To: Matt Spinler CC: "openbmc@lists.ozlabs.org" , =?big5?B?RnJhbiBIc3UgKK59u3jBvik=?= , =?big5?B?R2VvcmdlIEh1bmcgKKx4qb63cSk=?= , =?big5?B?RWRkaWUgTHUgKLOwpnSpoyk=?= Subject: Hwmon scale timing issue Thread-Topic: Hwmon scale timing issue Thread-Index: AdZgBbqu9AOTYqxsRwKjfSZ6PyCHmw== Date: Wed, 22 Jul 2020 09:00:19 +0000 Message-ID: Accept-Language: en-US, zh-TW Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.243.91.252] x-tm-snts-smtp: 8F4BE6400617BCC0EA7180CECD78F65FABE002288E1B5F12E9BA983964D445AA2000:8 Content-Type: multipart/alternative; boundary="_000_e44cf80b68864cba9db6c71d23a5c5fbquantatwcom_" MIME-Version: 1.0 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2020 09:00:35 -0000 --_000_e44cf80b68864cba9db6c71d23a5c5fbquantatwcom_ Content-Type: text/plain; charset="big5" Content-Transfer-Encoding: base64 SGkgTWF0dCwNCiAgIFRoYW5rcyBmb3Igc29sdmluZyBzZW5zb3IgdHlwZSBpc3N1ZSwgYnV0IEkg Zm91bmQgYW5vdGhlciBpc3N1ZSwgdGhlIHNjYWxlIHdvdWxkIG5vdCBhcHBseSB3aGVuDQpod21v biB1cGRhdGVkIHZhbHVlIGluIGZpcnN0IHRpbWUuIEZvciBleGFtcGxlLCBteSBiYXR0ZXJ5IDMu MDUxIHZvbHRhZ2Ugd291bGQgcmVjb3JkIDMwNTEgb24gZGJ1cw0KaW5zdGVhZCBvZiAzLjA1MSB1 bnRpbCBod21vbiB1cGRhdGUgYWdhaW4uIEkgdGhpbmsgdGhpcyBpcyBzY2FsZSB0aW1pbmcgaXNz dWUgZm9yIGh3bW9uIHVwZGF0ZSB2YWx1ZQ0KaW4gZmlyc3QgdGltZS4gU29tZSBzZW5zb3JzIGlu dGVydmFsIGNvbmZpZ3VyYXRpb24gaXMgc28gbG9uZyBzdWNoIGFzIG9uZSBkYXkgdGhhdCB3b3Vs ZCBsZWFkIHRvDQpyZWNvcmQgd3JvbmcgdmFsdWUgZm9yIGEgbG9uZyB0aW1lLg0KDQpJIGFtIG5v dCBzdXJlIHRoaXMgbGluZSB3b3VsZCBsZWFkIHRvIGh3bW9uIHVwZGF0ZSB2YWx1ZSB3aXRoIGlu Y29ycmVjdCBzY2FsZSBpbiBmaXJzdCB0aW1lLg0KaHR0cHM6Ly9naXRodWIuY29tL29wZW5ibWMv cGhvc3Bob3ItaHdtb24vYmxvYi9tYXN0ZXIvc2Vuc29yLmNwcCNMMTcwDQoNClRoYW5rcw0KRHVr ZQ0K --_000_e44cf80b68864cba9db6c71d23a5c5fbquantatwcom_ Content-Type: text/html; charset="big5" Content-Transfer-Encoding: quoted-printable

Hi Matt,

   Thanks for solving= sensor type issue, but I found another issue, the scale would not apply wh= en

hwmon updated value in first ti= me. For example, my battery 3.051 voltage would record 3051 on dbus

instead of 3.051 until hwmon up= date again. I think this is scale timing issue for hwmon update value

in first time. Some sensors int= erval configuration is so long such as one day that would lead to

record wrong value for a long t= ime.

 

I am not sure this line would l= ead to hwmon update value with incorrect scale in first time.

https://github.com/openbmc/phos= phor-hwmon/blob/master/sensor.cpp#L170

 

Thanks

Duke

--_000_e44cf80b68864cba9db6c71d23a5c5fbquantatwcom_--