Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30E05C33CA7 for ; Sun, 12 Jan 2020 01:38:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 053B320848 for ; Sun, 12 Jan 2020 01:38:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731890AbgALBiS (ORCPT ); Sat, 11 Jan 2020 20:38:18 -0500 Received: from mga03.intel.com ([134.134.136.65]:33938 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731889AbgALBiS (ORCPT ); Sat, 11 Jan 2020 20:38:18 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2020 17:38:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,423,1571727600"; d="scan'208";a="247388749" Received: from allen-box.sh.intel.com (HELO [10.239.159.136]) ([10.239.159.136]) by fmsmga004.fm.intel.com with ESMTP; 11 Jan 2020 17:38:14 -0800 Cc: baolu.lu@linux.intel.com, Bjorn Helgaas , Lorenzo Pieralisi , Keith Busch , Joerg Roedel , Christoph Hellwig , David Woodhouse Subject: Re: [RFC 2/5] iommu/vt-d: Unlink device if failed to add to group To: Jon Derrick , iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org References: <1577823863-3303-1-git-send-email-jonathan.derrick@intel.com> <1577823863-3303-3-git-send-email-jonathan.derrick@intel.com> From: Lu Baolu Message-ID: Date: Sun, 12 Jan 2020 09:36:56 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <1577823863-3303-3-git-send-email-jonathan.derrick@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 1/1/20 4:24 AM, Jon Derrick wrote: > If the device fails to be added to the group, make sure to unlink the > reference before returning. > > Signed-off-by: Jon Derrick Queued for v5.6. Best regards, baolu