Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E387C433EF for ; Thu, 10 Mar 2022 13:52:52 +0000 (UTC) Received: from localhost ([::1]:57776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nSJDm-0004Pu-RF for qemu-devel@archiver.kernel.org; Thu, 10 Mar 2022 08:52:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSJAC-0002ce-9J for qemu-devel@nongnu.org; Thu, 10 Mar 2022 08:49:08 -0500 Received: from mga01.intel.com ([192.55.52.88]:40494) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSJA9-0008T7-Ui for qemu-devel@nongnu.org; Thu, 10 Mar 2022 08:49:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646920145; x=1678456145; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Xeux2v0eDGEXfF5ihnPr4aD6Dva59CbQLnKOCogFaNw=; b=EuxzXgTvbGS3NOicwPWtP/IaSjF2WeEDwryHdktlMQdQOMxCRjsVafA0 vRnRCn7wFoI8MYbPv3hgDL/ylu3T/FDu27vXgc0tTnA3SYntZ0/ajUHEj hadd49hyq5traO1w2t17gNbIJldWuBe84sITafPA+292yYcyuS5ckKHGG yeHhSc/HdveMa89KuC+4BDvI31DQpZybeIL9lmKezvLDChq9bGpy/Vg9Y Yh2UT2LBNSyDWWk0RNacwwlpM0xRajRHwyOyb3ks8cXekOcpX7kXPHMgT xY3DdbMo1eyT/S4/6MUQe9k30EcP1opAq4PAlDpNnhbunjWV9TSDJK5ed A==; X-IronPort-AV: E=McAfee;i="6200,9189,10281"; a="279988736" X-IronPort-AV: E=Sophos;i="5.90,170,1643702400"; d="scan'208";a="279988736" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2022 05:49:02 -0800 X-IronPort-AV: E=Sophos;i="5.90,170,1643702400"; d="scan'208";a="554647656" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.249.168.152]) ([10.249.168.152]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2022 05:48:57 -0800 Message-ID: Date: Thu, 10 Mar 2022 21:48:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.6.1 Subject: Re: [PATCH RESEND v1 0/2] i386: Make PIT and PIC the property of common x86 base machine type Content-Language: en-US To: "Michael S. Tsirkin" References: <20220310122811.807794-1-xiaoyao.li@intel.com> <20220310080630-mutt-send-email-mst@kernel.org> From: Xiaoyao Li In-Reply-To: <20220310080630-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=192.55.52.88; envelope-from=xiaoyao.li@intel.com; helo=mga01.intel.com X-Spam_score_int: -51 X-Spam_score: -5.2 X-Spam_bar: ----- X-Spam_report: (-5.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HK_RANDOM_ENVFROM=0.998, HK_RANDOM_FROM=0.998, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Sergio Lopez , Richard Henderson , qemu-devel@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/10/2022 9:07 PM, Michael S. Tsirkin wrote: > On Thu, Mar 10, 2022 at 08:28:09PM +0800, Xiaoyao Li wrote: >> For PIT, it's straightforward to merge microvm::pit and >> pc_machine::pit_enabled into x86ms::pit >> >> For PIC, move microvm::pic to x86ms:pic, which gives PC machine the >> ability to dis-/en-able PIC and it's the preparation for future TDX >> support. > > > Looks ok but we are in freeze. I will tag this but pls do ping me > after the release to make sure it's not lost. Thanks! Sure, thanks! >> --- >> Resend: >> - collect Reviewed-by; >> - rebase to 2048c4eba2b4 ("Merge remote-tracking branch 'remotes/philmd/tags/pmbus-20220308' into staging") >> >> Xiaoyao Li (2): >> hw/i386: Make pit a property of common x86 base machine type >> hw/i386: Make pic a property of common x86 base machine type >> >> hw/i386/microvm.c | 54 ++------------------------------------- >> hw/i386/pc.c | 24 +++-------------- >> hw/i386/pc_piix.c | 4 ++- >> hw/i386/pc_q35.c | 4 ++- >> hw/i386/x86.c | 50 ++++++++++++++++++++++++++++++++++++ >> include/hw/i386/microvm.h | 4 --- >> include/hw/i386/pc.h | 2 -- >> include/hw/i386/x86.h | 4 +++ >> 8 files changed, 65 insertions(+), 81 deletions(-) >> >> -- >> 2.27.0 >